Re: Forgive trailing semicolons inside of config files

2023-07-11 Thread Tom Lane
Andres Freund writes: > Looks like we could make this easier in core postgres by adding one more > sd_notify() call, with something like > STATUS=reload failed due to syntax error in file > "/srv/dev/pgdev-dev/postgresql.conf" line 821, near end of line Seems reasonable to investigate. The

Re: Forgive trailing semicolons inside of config files

2023-07-11 Thread Andres Freund
Hi, On 2023-07-11 12:21:46 -0400, Greg Sabino Mullane wrote: > On Tue, Jul 11, 2023 at 11:04 AM Isaac Morland > > Or maybe there could be a "check configuration" subcommand which checks > > the configuration. > > > > There are things inside of Postgres once it has started, but yeah, > something

Re: Forgive trailing semicolons inside of config files

2023-07-11 Thread Greg Sabino Mullane
On Tue, Jul 11, 2023 at 11:04 AM Isaac Morland wrote: > Please, no! > > There is no end to accepting sloppy syntax. What next, allow "SET > random_page_cost = 2.5;" (with or without semicolon) in config files? > Well yes, there is an end. A single, trailing semicolon. Full stop. It's not a

Re: Forgive trailing semicolons inside of config files

2023-07-11 Thread Tom Lane
Isaac Morland writes: > On Tue, 11 Jul 2023 at 10:43, Greg Sabino Mullane >> # Add settings for extensions here >> random_page_cost = 2.5; >> >> Boom! Server will not start. Surely, we can be a little more liberal in >> what we accept? Attached patch allows a single trailing semicolon to be >>

Re: Forgive trailing semicolons inside of config files

2023-07-11 Thread Isaac Morland
On Tue, 11 Jul 2023 at 10:43, Greg Sabino Mullane wrote: > This has been a long-standing annoyance of mine. Who hasn't done something > like this?: > > psql> SET random_page_cost = 2.5; > (do some stuff, realize that rpc was too high) > > Let's put that inside of postgresql.conf: > > >

Forgive trailing semicolons inside of config files

2023-07-11 Thread Greg Sabino Mullane
This has been a long-standing annoyance of mine. Who hasn't done something like this?: psql> SET random_page_cost = 2.5; (do some stuff, realize that rpc was too high) Let's put that inside of postgresql.conf: #-- #