On Sun, Dec 11, 2022 at 04:20:17PM +0900, Michael Paquier wrote:
> Looks OK seen from here. Thanks for the patch! I don't have much
> freshness and time today, but I can get back to this thread tomorrow.
Applied as of eae7fe4.
--
Michael
signature.asc
Description: PGP signature
On Sat, Dec 10, 2022 at 11:03:38PM -0800, Maciek Sakrejda wrote:
> Sure. My C is pretty limited, but I think it's just the attached? I
> patterned the usage on the way this is done in CreateRole. It passes
> check-world here.
Looks OK seen from here. Thanks for the patch! I don't have much
Sure. My C is pretty limited, but I think it's just the attached? I
patterned the usage on the way this is done in CreateRole. It passes
check-world here.
From c7cae5d3e8d179505f26851f1241436a3748f9a8 Mon Sep 17 00:00:00 2001
From: Maciek Sakrejda
Date: Sat, 10 Dec 2022 22:51:02 -0800
Subject:
Michael Paquier writes:
> On Sat, Dec 10, 2022 at 07:11:13PM -0500, Tom Lane wrote:
>> Yeah, that looks like somebody didn't read the memo.
>> Want to submit a patch?
> The comment has been added in e3ce2de but the call originates from
> 6566133, so that's a HEAD-only issue.
Ah, good that the
On Sat, Dec 10, 2022 at 07:11:13PM -0500, Tom Lane wrote:
> Yeah, that looks like somebody didn't read the memo.
> Want to submit a patch?
The comment has been added in e3ce2de but the call originates from
6566133, so that's a HEAD-only issue.
--
Michael
signature.asc
Description: PGP signature
Maciek Sakrejda writes:
> While browsing through varsup.c, I noticed this comment on GetNewObjectId:
> * Hence, this routine should generally not be used directly. The only direct
> * callers should be GetNewOidWithIndex() and GetNewRelFileNumber() in
> * catalog/catalog.c.
> But AddRoleMems in
While browsing through varsup.c, I noticed this comment on GetNewObjectId:
* Hence, this routine should generally not be used directly. The only direct
* callers should be GetNewOidWithIndex() and GetNewRelFileNumber() in
* catalog/catalog.c.
But AddRoleMems in user.c appears to also call the
