Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery

2024-03-11 Thread Mats Kindahl
On Mon, Mar 11, 2024 at 12:42 AM Michael Paquier wrote: > On Thu, Mar 07, 2024 at 07:45:01AM +0900, Michael Paquier wrote: > > That's nice. You would be able to shave quite a bit of code. If > > there are no objections, I propose to apply the change of this thread > > to have this standard

Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery

2024-03-10 Thread Michael Paquier
On Thu, Mar 07, 2024 at 07:45:01AM +0900, Michael Paquier wrote: > That's nice. You would be able to shave quite a bit of code. If > there are no objections, I propose to apply the change of this thread > to have this standard explain wrapper at the beginning of next week. > If others have any

Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery

2024-03-06 Thread Michael Paquier
On Wed, Mar 06, 2024 at 10:32:01AM +0100, Jelte Fennema-Nio wrote: > This patch would definitely be useful for Citus. We indeed currently > copy all of that code into our own explain hook. And it seems we > actually have some bug. Because the es->memory branches were not > copied (probably because

Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery

2024-03-06 Thread Jelte Fennema-Nio
This patch would definitely be useful for Citus. We indeed currently copy all of that code into our own explain hook. And it seems we actually have some bug. Because the es->memory branches were not copied (probably because this code didn't exist when we copied it).

Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery

2024-03-05 Thread Mats Kindahl
On Wed, Mar 6, 2024 at 3:27 AM Andrei Lepikhov wrote: > On 6/3/2024 06:25, Michael Paquier wrote: > >> Just to elaborate: the intention was to allow a section to be added to > >> every node in the plan containing information from further down and also > >> allow this information to propagate

Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery

2024-03-05 Thread Andrei Lepikhov
On 6/3/2024 06:25, Michael Paquier wrote: Just to elaborate: the intention was to allow a section to be added to every node in the plan containing information from further down and also allow this information to propagate upwards. We happen to have buffer information right now, but allowing

Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery

2024-03-05 Thread Michael Paquier
On Tue, Mar 05, 2024 at 08:21:34AM +0100, Mats Kindahl wrote: > I realize that a more advanced system is possible to create where you can > customize the output even more, but in this case I just wanted to add a > section with some additional information related to plan execution. Also, > the code

Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery

2024-03-04 Thread Mats Kindahl
On Tue, Mar 5, 2024 at 7:31 AM Michael Paquier wrote: > On Mon, Mar 04, 2024 at 03:41:16PM +0300, Aleksander Alekseev wrote: > >> I wanted to hook into the EXPLAIN output for queries and add some > >> extra information, but since there is no standard_ExplainOneQuery() I > >> had to copy the code

Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery

2024-03-04 Thread Michael Paquier
On Mon, Mar 04, 2024 at 03:41:16PM +0300, Aleksander Alekseev wrote: >> I wanted to hook into the EXPLAIN output for queries and add some >> extra information, but since there is no standard_ExplainOneQuery() I >> had to copy the code and create my own version. >> >> Since the pattern with other

Re: Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery

2024-03-04 Thread Aleksander Alekseev
Hi, > I wanted to hook into the EXPLAIN output for queries and add some extra > information, but since there is no standard_ExplainOneQuery() I had to copy > the code and create my own version. > > Since the pattern with other hooks for a function WhateverFunction() seems to > be that there is

Hooking into ExplainOneQuery() complicated by missing standard_ExplainOneQuery

2024-03-04 Thread Mats Kindahl
Hi hackers, I wanted to hook into the EXPLAIN output for queries and add some extra information, but since there is no standard_ExplainOneQuery() I had to copy the code and create my own version. Since the pattern with other hooks for a function WhateverFunction() seems to be that there is a