Re: Improve pg_dump dumping publication tables

2021-01-15 Thread Tom Lane
"Hsu, John" writes: > I was wondering if there's a good reason in pg_dump getPublicationTables() > to iterate through all tables one by one and querying to see if it has a > corresponding publication other than memory concerns? I just came across this entry in the CommitFest, and I see that

Re: Improve pg_dump dumping publication tables

2020-10-26 Thread John Hsu
Hi Cary, Thanks for taking a look. I agree there's a risk since there's more memory usage on client side, and if you're dumping say millions of publicationTables then that could be problematic. I'd like to think this isn't any riskier than existing pg_dump code such as in getTables(...)

Re: Improve pg_dump dumping publication tables

2020-10-13 Thread Cary Huang
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Hi I applied the patch to PG master branch successfully and the