Re: Lockless exit path for ReplicationOriginExitCleanup

2024-01-15 Thread Alvaro Herrera
Thanks, pushed. I reworded the comment again, though. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/

Re: Lockless exit path for ReplicationOriginExitCleanup

2023-11-22 Thread Bharath Rupireddy
On Wed, Nov 22, 2023 at 3:06 PM Alvaro Herrera wrote: > > Hello, > > On 2023-Nov-22, Bharath Rupireddy wrote: > > > While looking at the use of session_replication_state, I noticed that > > ReplicationOriginLock is acquired in ReplicationOriginExitCleanup() > > even if session_replication_state

Re: Lockless exit path for ReplicationOriginExitCleanup

2023-11-22 Thread Bharath Rupireddy
On Wed, Nov 22, 2023 at 2:28 PM Amit Kapila wrote: > > On Wed, Nov 22, 2023 at 2:12 PM Bharath Rupireddy > wrote: > > > > While looking at the use of session_replication_state, I noticed that > > ReplicationOriginLock is acquired in ReplicationOriginExitCleanup() > > even if

Re: Lockless exit path for ReplicationOriginExitCleanup

2023-11-22 Thread Alvaro Herrera
Hello, On 2023-Nov-22, Bharath Rupireddy wrote: > While looking at the use of session_replication_state, I noticed that > ReplicationOriginLock is acquired in ReplicationOriginExitCleanup() > even if session_replication_state is reset to NULL by > replorigin_session_reset(). Why can't there be a

Re: Lockless exit path for ReplicationOriginExitCleanup

2023-11-22 Thread Amit Kapila
On Wed, Nov 22, 2023 at 2:12 PM Bharath Rupireddy wrote: > > While looking at the use of session_replication_state, I noticed that > ReplicationOriginLock is acquired in ReplicationOriginExitCleanup() > even if session_replication_state is reset to NULL by > replorigin_session_reset(). Why can't

Lockless exit path for ReplicationOriginExitCleanup

2023-11-22 Thread Bharath Rupireddy
Hi, While looking at the use of session_replication_state, I noticed that ReplicationOriginLock is acquired in ReplicationOriginExitCleanup() even if session_replication_state is reset to NULL by replorigin_session_reset(). Why can't there be a lockless exit path something like [1] similar to