On 2023-09-25 15:27, torikoshia wrote:
Ugh, regression tests failed and it appears to be due to reasons
related to meson.
I'm going to investigate it.
ISTM
On 2023-10-06 19:49, Peter Eisentraut wrote:
On 25.09.23 08:27, torikoshia wrote:
So in summary, I think 80 is a decent soft limit, but
On 25.09.23 08:27, torikoshia wrote:
So in summary, I think 80 is a decent soft limit, but let's not stress
out about some lines going over that, and make a hard limit of perhaps
120.
+1. It may be a good compromise.
For enforcing the hard limit, is it better to add a regression test like
On 2023-09-25 15:27, torikoshia wrote:
On Tue, Sep 19, 2023 at 3:23 AM Greg Sabino Mullane
wrote:
Thanks for your investigation!
On Fri, Sep 15, 2023 at 11:11 AM torikoshia
wrote:
I do not intend to adhere to this rule(my terminals are usually
bigger
than 80 chars per line), but wouldn't
On Tue, Sep 19, 2023 at 3:23 AM Greg Sabino Mullane
wrote:
Thanks for your investigation!
On Fri, Sep 15, 2023 at 11:11 AM torikoshia
wrote:
I do not intend to adhere to this rule(my terminals are usually bigger
than 80 chars per line), but wouldn't it be a not bad direction to use
80
On 31.08.23 09:47, torikoshia wrote:
BTW, psql --help outputs the content of PGHOST, which caused a failure
in the test:
```
-h, --host=HOSTNAME database server host or socket directory
(default:
"/var/folders/m7/9snkd5b54cx_b4lxkl9ljlccgn/T/LobrmSUf7t")
On Fri, Sep 15, 2023 at 11:11 AM torikoshia
wrote:
> I do not intend to adhere to this rule(my terminals are usually bigger
> than 80 chars per line), but wouldn't it be a not bad direction to use
> 80 characters for all commands?
>
Well, that's the question du jour, isn't it? The 80 character
On 2023-09-12 15:27, Peter Eisentraut wrote:
Also, it would be very useful if the TAP test function could print out
the violating lines if a test fails. (Similar to how is() and like()
print the failing values.)
Attached patch for this.
Below are the the outputs when test failed:
```
$ cd
On Tue, Jul 4, 2023 at 9:47 PM torikoshia
wrote:
> Since it seems preferable to have consistent line break policy and some
> people use 80-column terminal, wouldn't it be better to make all commands
> in 80
> columns per line?
>
All this seems an awful lot of work to support this mythical
On 2023-09-12 15:27, Peter Eisentraut wrote:
I like this work a lot. It's good to give developers easy to verify
guidance about formatting the --help messages.
However, I think instead of just adding a bunch of line breaks to
satisfy the test, we should really try to make the lines shorter by
I like this work a lot. It's good to give developers easy to verify
guidance about formatting the --help messages.
However, I think instead of just adding a bunch of line breaks to
satisfy the test, we should really try to make the lines shorter by
rewording. Otherwise, chances are we are
m_help_ok, but
left as they are because they are not commands that users execute
directly.
--
Regards,
--
Atsushi Torikoshi
NTT DATA Group CorporationFrom 4728cab3e39f7994b8b6dd41787cac90b5cb64f6 Mon Sep 17 00:00:00 2001
From: Atsushi Torikoshi
Date: Thu, 31 Aug 2023 16:22:39 +0900
Subject: [PATCH v2]
Hi,
On 2023-08-22 22:57, torikoshia wrote:
On 2023-08-21 13:08, Masahiro Ikeda wrote:
(2)
Is there any reason that only src/bin commands are targeted? I found
that
we also need to fix vacuumlo with the above test. I think it's better
to
fix it because it's a contrib module.
$ vacuumlo
On 2023-08-21 13:08, Masahiro Ikeda wrote:
Thanks for your review!
(1)
Why don't you add test for the purpose? It could be overkill...
I though the following function is the best place.
diff --git a/src/test/perl/PostgreSQL/Test/Utils.pm
b/src/test/perl/PostgreSQL/Test/Utils.pm
index
On 2023-07-05 10:47, torikoshia wrote:
Hi,
As discussed in [1], outputs of --help for some commands fits into 80
columns
per line, while others do not.
Since it seems preferable to have consistent line break policy and some
people
use 80-column terminal, wouldn't it be better to make all
4505bbcf0efe199e34159696d64bd9f8cc60fb37 Mon Sep 17 00:00:00 2001
From: Atsushi Torikoshi
Date: Wed, 5 Jul 2023 10:14:58 +0900
Subject: [PATCH v1] Make --help output fit within 80 columns per line
Outputs of --help for some commands fits into 80 columns per line,
while others do not.
For the consistency and for 80-column
15 matches
Mail list logo
