Re: Meson add host_system to PG_VERSION_STR

2022-12-09 Thread Andres Freund
Hi, On 2022-12-09 14:53:10 +0100, Juan José Santamaría Flecha wrote: > I've added an entry [1] in the commitfest so we don't miss this subject. I indeed had forgotten. Pushed now. Greetings, Andres Freund

Re: Meson add host_system to PG_VERSION_STR

2022-12-09 Thread Juan José Santamaría Flecha
On Thu, Nov 17, 2022 at 3:35 AM Michael Paquier wrote: > > Ah, thanks. I was not following this point. Adding the host > information for consistency makes sense, indeed. > I've added an entry [1] in the commitfest so we don't miss this subject. [1] https://commitfest.postgresql.org/41/4057/

Re: Meson add host_system to PG_VERSION_STR

2022-11-16 Thread Michael Paquier
On Wed, Nov 16, 2022 at 02:12:05PM +0100, Juan José Santamaría Flecha wrote: > On Wed, Nov 16, 2022 at 10:50 AM Peter Eisentraut < > peter.eisentr...@enterprisedb.com> wrote: >> Perhaps some examples before and after on different platforms could be >> shown. > > Yes, that would make clear what

Re: Meson add host_system to PG_VERSION_STR

2022-11-16 Thread Juan José Santamaría Flecha
On Wed, Nov 16, 2022 at 8:02 PM Andres Freund wrote: > > Given we're looking at improving this, should we also add 32/64-bit piece? > > If so, we probably should move building PG_VERSION_STR to later so we can > use > SIZEOF_VOID_P - configure.ac does that too. > > With extra_version set to

Re: Meson add host_system to PG_VERSION_STR

2022-11-16 Thread Andres Freund
Hi, On 2022-11-16 09:01:04 +0900, Michael Paquier wrote: > On Wed, Nov 16, 2022 at 12:08:56AM +0100, Juan José Santamaría Flecha wrote: > > As mentioned here [1] it might be interesting to complete the returned > > information by version() when compiled with meson by including the > >

Re: Meson add host_system to PG_VERSION_STR

2022-11-16 Thread Juan José Santamaría Flecha
On Wed, Nov 16, 2022 at 10:50 AM Peter Eisentraut < peter.eisentr...@enterprisedb.com> wrote: > On 16.11.22 01:01, Michael Paquier wrote: > > > > The meson build provides extra_version, which would be able to do the > > same, no? The information would be appended to PG_VERSION_STR through > >

Re: Meson add host_system to PG_VERSION_STR

2022-11-16 Thread Peter Eisentraut
On 16.11.22 01:01, Michael Paquier wrote: On Wed, Nov 16, 2022 at 12:08:56AM +0100, Juan José Santamaría Flecha wrote: As mentioned here [1] it might be interesting to complete the returned information by version() when compiled with meson by including the host_system. The meson build

Re: Meson add host_system to PG_VERSION_STR

2022-11-15 Thread Michael Paquier
On Wed, Nov 16, 2022 at 12:08:56AM +0100, Juan José Santamaría Flecha wrote: > As mentioned here [1] it might be interesting to complete the returned > information by version() when compiled with meson by including the > host_system. The meson build provides extra_version, which would be able to

Meson add host_system to PG_VERSION_STR

2022-11-15 Thread Juan José Santamaría Flecha
Hello all, As mentioned here [1] it might be interesting to complete the returned information by version() when compiled with meson by including the host_system. [1] https://www.postgresql.org/message-id/20221115195318.5v5ynapmkusgyzks%40awork3.anarazel.de Regards, Juan José Santamaría Flecha