Re: Meson doesn't define HAVE_LOCALE_T for mscv

On Tue, Nov 15, 2022 at 9:02 PM Andres Freund wrote: > > On 2022-11-15 15:35:31 +0100, Juan José Santamaría Flecha wrote: > > On Tue, Nov 15, 2022 at 1:49 AM Andres Freund > wrote: > > > Hm. Is it right that the changes are only done for msvc? win32_port.h > > > defines the types for mingw as

Re: Meson doesn't define HAVE_LOCALE_T for mscv

On Tue, Nov 15, 2022 at 8:53 PM Andres Freund wrote: > > I don't think we should print mingw - that's really just redundant with > gcc. But including host_system seems like a good idea. Not sure why I > didn't > do that. > > I'll open a new thread for this. Also, I think this is skipping

Re: Meson doesn't define HAVE_LOCALE_T for mscv

Hi, Hm, the quoting was odd, making me think you had written a separate email about the define issue. Hence the separate email... On 2022-11-15 15:35:31 +0100, Juan José Santamaría Flecha wrote: > On Tue, Nov 15, 2022 at 1:49 AM Andres Freund wrote: > > Hm. Is it right that the changes are

Re: Meson doesn't define HAVE_LOCALE_T for mscv

Hi, On 2022-11-15 15:35:31 +0100, Juan José Santamaría Flecha wrote: > I've seen that when building with meson on MinGW the output for version() > is 'PostgreSQL 16devel on x86_64, compiled by gcc-12.2.0', which is not > wrong but I cannot tell that it was done on MinGW. Should we include the >

Re: Meson doesn't define HAVE_LOCALE_T for mscv

On Tue, Nov 15, 2022 at 1:49 AM Andres Freund wrote: > > Hm. Is it right that the changes are only done for msvc? win32_port.h > defines > the types for mingw as well afaict. > > Yes, it does, but configure does nothing with them, so adding those defines is a new feature for MinGW but a

Re: Meson doesn't define HAVE_LOCALE_T for mscv

Hi, On 2022-11-10 10:59:41 +0100, Juan José Santamaría Flecha wrote: > Meson doesn't see the redefinition of locale_t done > in src/include/port/win32_port.h, so is not defining > HAVE_LOCALE_T, HAVE_WCSTOMBS_L nor HAVE_MBSTOWCS_L as the > current src/tools/msvc/build.pl script does. > > Please

Re: Meson doesn't define HAVE_LOCALE_T for mscv

On 10.11.22 10:59, Juan José Santamaría Flecha wrote: Meson doesn't see the redefinition of locale_t done in src/include/port/win32_port.h, so is not defining HAVE_LOCALE_T, HAVE_WCSTOMBS_L nor HAVE_MBSTOWCS_L as the current src/tools/msvc/build.pl script does. Please find

Meson doesn't define HAVE_LOCALE_T for mscv

Hello all, Meson doesn't see the redefinition of locale_t done in src/include/port/win32_port.h, so is not defining HAVE_LOCALE_T, HAVE_WCSTOMBS_L nor HAVE_MBSTOWCS_L as the current src/tools/msvc/build.pl script does. Please find attached a patch for so. Regards, Juan José Santamaría Flecha