On Mon, Mar 20, 2023 at 04:04:31PM +0800, Richard Guo wrote:
> Agreed. +1 to remove the counts.
Thanks. Adjusted this way, then.
--
Michael
signature.asc
Description: PGP signature
On Mon, Mar 20, 2023 at 10:21:28AM -0400, Tom Lane wrote:
> Is similar knowledge missing in the meson build files?
src/backend/nodes/meson.build and src/include/nodes/meson.build are
the two meson files that have the knowledge about the files generated
by gen_node_support.pl, and the query
Michael Paquier writes:
> Nathan has reported to me offlist that maintainer-clean was not doing
> its job for the files generated by gen_node_support.pl in
> src/backend/nodes/ for the query jumbling. Attached is a patch to
> take care of this issue.
> While on it, I have found a comment in the
On Mon, Mar 20, 2023 at 3:49 PM Daniel Gustafsson wrote:
> > On 20 Mar 2023, at 08:46, Michael Paquier wrote:
> > How about removing the "fout/five" entirely here
> > and make that simpler? I would propose:
> > "For some classes of node types, you don't need all the support
> > functions."
>
>
> On 20 Mar 2023, at 08:46, Michael Paquier wrote:
> How about removing the "fout/five" entirely here
> and make that simpler? I would propose:
> "For some classes of node types, you don't need all the support
> functions."
Yes please, keeping such counts in sync is always error-prone.
--
On Mon, Mar 20, 2023 at 03:18:17PM +0800, Richard Guo wrote:
> A minor comment for the README is that now we have five support
> functions not four.
>
> - outcome. (For some classes of node types, you don't need all four support
> + outcome. (For some classes of node types, you don't need all
On Mon, Mar 20, 2023 at 2:43 PM Michael Paquier wrote:
> Nathan has reported to me offlist that maintainer-clean was not doing
> its job for the files generated by gen_node_support.pl in
> src/backend/nodes/ for the query jumbling. Attached is a patch to
> take care of this issue.
>
> While on
Hi all,
Nathan has reported to me offlist that maintainer-clean was not doing
its job for the files generated by gen_node_support.pl in
src/backend/nodes/ for the query jumbling. Attached is a patch to
take care of this issue.
While on it, I have found a comment in the related README that was
