Re: Output affected rows in EXPLAIN

2023-11-22 Thread John Naylor
On Wed, Nov 15, 2023 at 2:17 PM wrote: > > We can check the number of updated rows from execute plan, > I think there is no need to return the command tag > when EXPLAIN(ANALYZE) is executed by default. Given that several people have voiced an opinion against this patch, I'm marking it rejected.

Re: Output affected rows in EXPLAIN

2023-11-14 Thread kuroda . keisuke
own as returning zero rows, because that's what it did. If you'd written "insert ... returning", you'd have gotten a different result: Maybe I didn't understand you correctly, but I didn't touch the number of affected rows in EXPLAIN output. It's just a simple patch that adds 1 row aft

Re: Output affected rows in EXPLAIN

2023-09-07 Thread Damir Belyalov
y, but I didn't touch the number of affected rows in EXPLAIN output. It's just a simple patch that adds 1 row after using commands: EXPLAIN INSERT, EXPLAIN UPDATE, EXPLAIN DELETE. It was done because the commands INSERT/UPDATE/DELETE return one row after execution: "UPDATE 7" or "INSERT 0

Re: Output affected rows in EXPLAIN

2023-09-06 Thread Tom Lane
Damir Belyalov writes: > I create a patch that outputs affected rows in EXPLAIN that occur by > INSERT/UPDATE/DELETE. > Despite the fact that commands in EXPLAIN ANALYZE query are executed as > usual, EXPLAIN doesn't show outputting affected rows as in these commands. > The patch fixes this

Re: Output affected rows in EXPLAIN

2023-09-06 Thread Daniel Gustafsson
> On 6 Sep 2023, at 14:49, Damir Belyalov wrote > The patch fixes this problem. Given that EXPLAIN ANALYZE has worked like for a very long time, which problem is it you have identified? I'm also not convinced that the added "EXPLAIN" in the below plan is an improvement in any way. postgres=#

Output affected rows in EXPLAIN

2023-09-06 Thread Damir Belyalov
ss tests yet. Regards, Damir Belyalov Postgres Professional From c6cbc6fa9ddf24f29bc19ff115224dd76e351db1 Mon Sep 17 00:00:00 2001 From: Damir Belyalov Date: Tue, 5 Sep 2023 15:04:01 +0300 Subject: [PATCH] Output affected rows in EXPLAIN. --- src/backend/commands/explain.c | 10 +- src/