Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-06-02 Thread Greg Stark
On Tue, 31 May 2022 at 12:00, Vladimir Sitnikov wrote: > > Please, do not suggest me avoid 65535 parameters. What I wanted was just to > test that the driver was able to handle 65535 parameters. I don't think we have regression tests to cover things at these limits, that might be worth adding

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Tom Lane
David Rowley writes: > Maybe "columns per result set" would have been a better title for consistency. I can't quite put my finger on why, but that wording seems odd to me, even though "columns per table" is natural enough. "In a" reads much better here IMO. Anyway, I see you committed it that

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread David Rowley
On Wed, 1 Jun 2022 at 12:42, Tom Lane wrote: > > David Rowley writes: > > I've adjusted the patch to use the wording proposed by Alvaro. See attached. > > Should we also change the adjacent item to "columns in a table", > for consistency of wording? Not sure though, because s/per/in a/ >

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Gavin Flower
On 1/06/22 12:42, Tom Lane wrote: David Rowley writes: I've adjusted the patch to use the wording proposed by Alvaro. See attached. Should we also change the adjacent item to "columns in a table", for consistency of wording? Not sure though, because s/per/in a/ throughout the list doesn't

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Tom Lane
David Rowley writes: > I've adjusted the patch to use the wording proposed by Alvaro. See attached. Should we also change the adjacent item to "columns in a table", for consistency of wording? Not sure though, because s/per/in a/ throughout the list doesn't seem like it'd be an improvement.

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Dave Cramer
On Tue, 31 May 2022 at 20:33, David Rowley wrote: > On Wed, 1 Jun 2022 at 07:08, Dave Cramer > wrote: > > > > On Tue, 31 May 2022 at 14:51, Tom Lane wrote: > >> > >> Alvaro Herrera writes: > >> > I think it's reasonable to have two adjacent rows in the table for > these > >> > two closely

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread David Rowley
On Wed, 1 Jun 2022 at 07:08, Dave Cramer wrote: > > On Tue, 31 May 2022 at 14:51, Tom Lane wrote: >> >> Alvaro Herrera writes: >> > I think it's reasonable to have two adjacent rows in the table for these >> > two closely related things, but rather than "columns per tuple" I would >> > label

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Bruce Momjian
On Tue, May 31, 2022 at 01:22:44PM -0400, Dave Cramer wrote: > > > On Tue, 31 May 2022 at 10:49, Tom Lane wrote: > > Dave Cramer writes: > > On Tue, 31 May 2022 at 10:16, Tom Lane wrote: > >> We've generally felt that the existing "columns per table" limit is > >> sufficient

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Dave Cramer
On Tue, 31 May 2022 at 14:51, Tom Lane wrote: > Alvaro Herrera writes: > > I think it's reasonable to have two adjacent rows in the table for these > > two closely related things, but rather than "columns per tuple" I would > > label the second one "columns in a result set". This is easy

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Tom Lane
Alvaro Herrera writes: > I think it's reasonable to have two adjacent rows in the table for these > two closely related things, but rather than "columns per tuple" I would > label the second one "columns in a result set". This is easy enough to > understand and to differentiate from the other

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Alvaro Herrera
On 2022-May-31, Tom Lane wrote: > Detail is far from "free". Most readers are going to spend more time > wondering what the difference is between "columns per table" and "columns > per tuple", and which limit applies when, than they are going to save by > having the docs present them with two

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Dave Cramer
On Tue, 31 May 2022 at 10:49, Tom Lane wrote: > Dave Cramer writes: > > On Tue, 31 May 2022 at 10:16, Tom Lane wrote: > >> We've generally felt that the existing "columns per table" limit is > >> sufficient detail here. > > > ISTM that adding detail is free whereas the readers time to figure

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Vladimir Sitnikov
>ost readers are going to spend more time >wondering what the difference is between "columns per table" and "columns >per tuple" "tuple" is already mentioned 10 times on "limits" page, so adding "columns per tuple" is not really obscure. The comment could be like "for instance, max number of

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Tom Lane
Dave Cramer writes: > On Tue, 31 May 2022 at 10:16, Tom Lane wrote: >> We've generally felt that the existing "columns per table" limit is >> sufficient detail here. > ISTM that adding detail is free whereas the readers time to figure out why > and where this number came from is not. Detail is

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Dave Cramer
On Tue, 31 May 2022 at 10:16, Tom Lane wrote: > Amul Sul writes: > > On Tue, May 31, 2022 at 12:46 PM Vladimir Sitnikov > > wrote: > >> I suggest that the limit of "1664 columns per tuple" (or whatever is > the right term) should be added > >> to the list at

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Tom Lane
Amul Sul writes: > On Tue, May 31, 2022 at 12:46 PM Vladimir Sitnikov > wrote: >> I suggest that the limit of "1664 columns per tuple" (or whatever is the >> right term) should be added >> to the list at https://www.postgresql.org/docs/current/limits.html e.g. >> after "columns per table".

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Dave Cramer
> > > > > On Tue, 31 May 2022 at 09:56, Amul Sul wrote: > >> On Tue, May 31, 2022 at 12:46 PM Vladimir Sitnikov >> wrote: >> > >> > Hi, >> > >> > Today I hit "ERROR: target lists can have at most 1664 entries", and I >> was surprised the limit was not documented. >> > >> > I suggest that the

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Dave Cramer
On Tue, 31 May 2022 at 09:56, Amul Sul wrote: > On Tue, May 31, 2022 at 12:46 PM Vladimir Sitnikov > wrote: > > > > Hi, > > > > Today I hit "ERROR: target lists can have at most 1664 entries", and I > was surprised the limit was not documented. > > > > I suggest that the limit of "1664 columns

Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Amul Sul
On Tue, May 31, 2022 at 12:46 PM Vladimir Sitnikov wrote: > > Hi, > > Today I hit "ERROR: target lists can have at most 1664 entries", and I was > surprised the limit was not documented. > > I suggest that the limit of "1664 columns per tuple" (or whatever is the > right term) should be added >

PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Vladimir Sitnikov
Hi, Today I hit "ERROR: target lists can have at most 1664 entries", and I was surprised the limit was not documented. I suggest that the limit of "1664 columns per tuple" (or whatever is the right term) should be added to the list at https://www.postgresql.org/docs/current/limits.html e.g.