Re: Question regarding "Make archiver process an auxiliary process. commit"

2023-01-31 Thread Michael Paquier
On Tue, Jan 31, 2023 at 08:30:13PM -0800, Nathan Bossart wrote: > I'm not sure why I thought time.h was no longer needed. time() is clearly > used elsewhere in this file. Here's a new version with that added back. Ah, I see. The key point is that curtime and last_copy_time will most likely be

Re: Question regarding "Make archiver process an auxiliary process. commit"

2023-01-31 Thread Nathan Bossart
On Fri, Jan 20, 2023 at 11:39:56AM -0800, Nathan Bossart wrote: > I noticed that time.h is no longer needed by the archiver, so I removed > that and fixed an indentation nitpick in the attached v2. I'm going to set > the commitfest entry to ready-for-committer shortly after sending this >

Re: Question regarding "Make archiver process an auxiliary process. commit"

2023-01-20 Thread Nathan Bossart
On Wed, Jan 04, 2023 at 11:35:33AM +0530, Sravan Kumar wrote: > I have added the thread to the commitfest: > https://commitfest.postgresql.org/42/ > Did you get a chance to review the patch? Please let me know if you > need anything from my end. This seems like worthwhile simplification to me.

Re: Question regarding "Make archiver process an auxiliary process. commit"

2023-01-03 Thread Sravan Kumar
I have added the thread to the commitfest: https://commitfest.postgresql.org/42/ Did you get a chance to review the patch? Please let me know if you need anything from my end. Thanks & Regards, Sravan Velagandula EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed,

Re: Question regarding "Make archiver process an auxiliary process. commit"

2022-12-06 Thread Kyotaro Horiguchi
At Wed, 7 Dec 2022 11:28:23 +0530, Sravan Kumar wrote in > On Tue, Dec 6, 2022 at 5:24 PM Bharath Rupireddy < > bharath.rupireddyforpostg...@gmail.com> wrote: > > > On Tue, Dec 6, 2022 at 4:57 PM Sravan Kumar > > wrote: > > > > > > Thank you for the feedback. > > > > > > I'll be glad to help

Re: Question regarding "Make archiver process an auxiliary process. commit"

2022-12-06 Thread Kyotaro Horiguchi
At Tue, 6 Dec 2022 17:23:50 +0530, Bharath Rupireddy wrote in > Thanks. +1 for fixing this. > > I would like to quote recent discussions on reducing the useless > wakeups or increasing the sleep/hibernation times in various processes > to reduce the power savings [1] [2] [3] [4] [5]. With that

Re: Question regarding "Make archiver process an auxiliary process. commit"

2022-12-06 Thread Sravan Kumar
On Tue, Dec 6, 2022 at 5:24 PM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > On Tue, Dec 6, 2022 at 4:57 PM Sravan Kumar > wrote: > > > > Thank you for the feedback. > > > > I'll be glad to help with the fix. Here's the patch for review. > > Thanks. +1 for fixing this. >>

Re: Question regarding "Make archiver process an auxiliary process. commit"

2022-12-06 Thread Bharath Rupireddy
On Tue, Dec 6, 2022 at 4:57 PM Sravan Kumar wrote: > > Thank you for the feedback. > > I'll be glad to help with the fix. Here's the patch for review. Thanks. +1 for fixing this. I would like to quote recent discussions on reducing the useless wakeups or increasing the sleep/hibernation times

Re: Question regarding "Make archiver process an auxiliary process. commit"

2022-12-06 Thread Sravan Kumar
Thank you for the feedback. I'll be glad to help with the fix. Here's the patch for review. On Tue, Dec 6, 2022 at 1:54 PM Kyotaro Horiguchi wrote: > At Mon, 5 Dec 2022 12:06:11 +0530, Sravan Kumar > wrote in > > timeout = PGARCH_AUTOWAKE_INTERVAL - (curtime - last_copy_time); > > It so

Re: Question regarding "Make archiver process an auxiliary process. commit"

2022-12-06 Thread Kyotaro Horiguchi
At Mon, 5 Dec 2022 12:06:11 +0530, Sravan Kumar wrote in > timeout = PGARCH_AUTOWAKE_INTERVAL - (curtime - last_copy_time); > It so happens that last_copy_time and curtime are always set at the same > time which always makes timeout equal (actually roughly equal) to > PGARCH_AUTOWAKE_INTERVAL.

Question regarding "Make archiver process an auxiliary process. commit"

2022-12-04 Thread Sravan Kumar
Hi, I see that in the archiver code, in the function pgarch_MainLoop, the archiver sleeps for a certain time or until there's a signal. The time it sleeps for is represented by: timeout = PGARCH_AUTOWAKE_INTERVAL - (curtime - last_copy_time); It so happens that last_copy_time and curtime are