On Mon, Jan 29, 2024 at 14:50 Amit Kapila wrote:
> Pushed!
Thanks for pushing.
Regards,
Wang Wei
On Fri, Jan 26, 2024 at 6:47 AM Wei Wang (Fujitsu)
wrote:
>
> It looks good to me. So, I updated the patch as suggested.
>
Pushed!
--
With Regards,
Amit Kapila.
On Thu, Jan 25, 2024 at 20:33 Amit Kapila wrote:
> On Thu, Jan 25, 2024 at 4:01 PM Wei Wang (Fujitsu)
> wrote:
> >
> >
> > Yes, agree. I think these two parts have become slightly outdated after the
> > commit 1632ea4. So also tried to fix the first part of the comment.
> > Attach the new patch.
On Thu, Jan 25, 2024 at 4:01 PM Wei Wang (Fujitsu)
wrote:
>
>
> Yes, agree. I think these two parts have become slightly outdated after the
> commit 1632ea4. So also tried to fix the first part of the comment.
> Attach the new patch.
>
How about changing it to something simple like:
diff --git
On Thu, Jan 25, 2024 at 18:39 Amit Kapila wrote:
>
Thanks for your review.
> On Thu, Jan 25, 2024 at 2:57 PM Wei Wang (Fujitsu)
> wrote:
> >
> > In the function ReplicationSlotAcquire(), I found there is a missing in the
> > below comments:
> >
> > ```
> > /*
> > * Search for
On Thu, Jan 25, 2024 at 2:57 PM Wei Wang (Fujitsu)
wrote:
>
> In the function ReplicationSlotAcquire(), I found there is a missing in the
> below comments:
>
> ```
> /*
> * Search for the slot with the specified name if the slot to acquire
> is
> * not given. If the
