Re: Relids instead of Bitmapset * in plannode.h

2023-11-08 Thread Tom Lane
Ashutosh Bapat writes: > On Tue, Nov 7, 2023 at 8:54 PM Tom Lane wrote: >> Yes, I'm pretty sure that's exactly the reason, and I'm strongly >> against the initially-proposed patch. The include footprint of >> pathnodes.h would be greatly expanded, for no real benefit. > As I mentioned in [1]

Re: Relids instead of Bitmapset * in plannode.h

2023-11-08 Thread Ashutosh Bapat
On Tue, Nov 7, 2023 at 8:54 PM Tom Lane wrote: > > Alvaro Herrera writes: > > On 2023-Oct-31, Ashutosh Bapat wrote: > >> For some reason plannode.h has declared variable to hold RTIs as > >> Bitmapset * instead of Relids like other places. Here's patch to fix > >> it. This is superficial change

Re: Relids instead of Bitmapset * in plannode.h

2023-11-07 Thread Tom Lane
Alvaro Herrera writes: > On 2023-Oct-31, Ashutosh Bapat wrote: >> For some reason plannode.h has declared variable to hold RTIs as >> Bitmapset * instead of Relids like other places. Here's patch to fix >> it. This is superficial change as Relids is typedefed to Bitmapset *. >> Build succeeds for

Re: Relids instead of Bitmapset * in plannode.h

2023-11-07 Thread Alvaro Herrera
t attribute numbers of an UPDATE */ + List *updateColnos pg_node_attr(query_jumble_ignore); +} MergeAction; + /* * CoerceToDomain * -- 2.39.2 >From 02987af92cea736dfe6819200304f7e122c842f5 Mon Sep 17 00:00:00 2001 From: Ashutosh Bapat Date: Tue, 31 Oct 2023 11:29:29 +0530 Subject: [PATCH

Relids instead of Bitmapset * in plannode.h

2023-10-31 Thread Ashutosh Bapat
1458cbd5dade42670b9a0499b65213758790b71f Mon Sep 17 00:00:00 2001 From: Ashutosh Bapat Date: Tue, 31 Oct 2023 11:29:29 +0530 Subject: [PATCH] Use Relids instead of Bitmapset * in plannode.h Most of the planner code uses Relids instead of Bitmapset * to declare a bitmapset of RTIs. Fix plannode.h