> On 28 Nov 2022, at 15:15, Tom Lane wrote:
> My viewpoint is that this change is misguided. Even if the current
> coding of qual_is_pushdown_safe doesn't happen to reference the
> subquery, it might need to in future.
If I understand the code correctly the variable has some value in terms of
Michael Paquier writes:
> On Mon, Nov 28, 2022 at 11:54:45AM +0900, Michael Paquier wrote:
>> On Fri, Nov 25, 2022 at 04:05:13PM +0800, Richard Guo wrote:
> I wonder if we need to revise the comment atop qual_is_pushdown_safe()
> too which says
>
> * rinfo is a restriction clause applying to the
On Mon, Nov 28, 2022 at 3:40 PM Michael Paquier wrote:
> > On Fri, Nov 25, 2022 at 04:05:13PM +0800, Richard Guo wrote:
> >> I wonder if we need to revise the comment atop qual_is_pushdown_safe()
> >> too which says
> >>
> >> * rinfo is a restriction clause applying to the given subquery (whose
On Mon, 28 Nov 2022 16:40:52 +0900
Michael Paquier wrote:
> On Mon, Nov 28, 2022 at 11:54:45AM +0900, Michael Paquier wrote:
> > On Fri, Nov 25, 2022 at 04:05:13PM +0800, Richard Guo wrote:
> >> I wonder if we need to revise the comment atop qual_is_pushdown_safe()
> >> too which says
> >>
> >>
On Mon, Nov 28, 2022 at 11:54:45AM +0900, Michael Paquier wrote:
> On Fri, Nov 25, 2022 at 04:05:13PM +0800, Richard Guo wrote:
>> I wonder if we need to revise the comment atop qual_is_pushdown_safe()
>> too which says
>>
>> * rinfo is a restriction clause applying to the given subquery (whose
On Fri, Nov 25, 2022 at 04:05:13PM +0800, Richard Guo wrote:
> +1. In 964c0d0f the checks in qual_is_pushdown_safe() that need to
> reference 'subquery' were moved to subquery_is_pushdown_safe(), so param
> 'subquery' is not used any more. I think we can just remove it.
>
> I wonder if we need
On Fri, Nov 25, 2022 at 2:27 PM Yugo NAGATA wrote:
> I found that qual_is_pushdown_safe() has an argument "subquery"
> that is not used in the function. This argument has not been
> referred to since the commit 964c0d0f80e485dd3a4073e073ddfd9bfdda90b2.
>
> I think we can remove this if there is
Hello,
I found that qual_is_pushdown_safe() has an argument "subquery"
that is not used in the function. This argument has not been
referred to since the commit 964c0d0f80e485dd3a4073e073ddfd9bfdda90b2.
I think we can remove this if there is no special reason.
Regards,
Yugo Nagata
--
Yugo
