Re: Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2019-07-08 Thread Dave Cramer
On Mon, 8 Jul 2019 at 06:40, Thomas Munro wrote: > On Thu, Mar 7, 2019 at 8:19 PM David Steele wrote: > > On 2/16/19 10:38 PM, Dave Cramer wrote: > > > Thanks for looking at this. FYI, I did not originally write this, > rather > > > the original author has not replied to requests. > > > JDBC

Re: Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2019-07-08 Thread Thomas Munro
On Thu, Mar 7, 2019 at 8:19 PM David Steele wrote: > On 2/16/19 10:38 PM, Dave Cramer wrote: > > Thanks for looking at this. FYI, I did not originally write this, rather > > the original author has not replied to requests. > > JDBC could use this, I assume others could as well. > > > > That said

Re: Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2019-03-06 Thread David Steele
On 2/16/19 10:38 PM, Dave Cramer wrote: Thanks for looking at this. FYI, I did not originally write this, rather the original author has not replied to requests. JDBC could use this, I assume others could as well. That said I'm certainly open to suggestions on how to do this. Craig, do you

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2019-02-16 Thread Dave Cramer
Andres, Thanks for looking at this. FYI, I did not originally write this, rather the original author has not replied to requests. JDBC could use this, I assume others could as well. That said I'm certainly open to suggestions on how to do this. Craig, do you have any other ideas? Dave Cramer

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2019-02-15 Thread Andres Freund
Hi, On 2018-12-03 06:38:43 -0500, Dave Cramer wrote: > From 4d023cfc1fed0b5852b4da1aad6a32549b03ce26 Mon Sep 17 00:00:00 2001 > From: Dave Cramer > Date: Fri, 30 Nov 2018 18:23:49 -0500 > Subject: [PATCH 1/5] Respect client initiated CopyDone in walsender > > --- >

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2019-01-20 Thread Dave Cramer
Dave Cramer On Tue, 15 Jan 2019 at 07:53, Dave Cramer wrote: > > Dave Cramer > > > On Sun, 13 Jan 2019 at 23:19, Craig Ringer wrote: > >> On Mon, 3 Dec 2018 at 19:38, Dave Cramer wrote: >> >>> Dmitry, >>> >>> Please see attached rebased patches >>> >> >> I'm fine with patch 0001, though I

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2019-01-15 Thread Dave Cramer
Dave Cramer On Sun, 13 Jan 2019 at 23:19, Craig Ringer wrote: > On Mon, 3 Dec 2018 at 19:38, Dave Cramer wrote: > >> Dmitry, >> >> Please see attached rebased patches >> > > I'm fine with patch 0001, though I find this comment a bit hard to follow: > > + * The send_data callback must enqueue

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2019-01-13 Thread Craig Ringer
On Mon, 3 Dec 2018 at 19:38, Dave Cramer wrote: > Dmitry, > > Please see attached rebased patches > I'm fine with patch 0001, though I find this comment a bit hard to follow: + * The send_data callback must enqueue complete CopyData messages to libpq + * using pq_putmessage_noblock or similar,

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2018-12-03 Thread Dave Cramer
Dmitry, Please see attached rebased patches Dave Cramer On Fri, 30 Nov 2018 at 18:52, Dmitry Dolgov <9erthali...@gmail.com> wrote: > >On Sat, Dec 1, 2018 at 12:49 AM Dave Cramer wrote: > > > > Thanks, I have done a preliminary check and it seems pretty > straightforward. > > > > I will clean

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2018-11-30 Thread Dmitry Dolgov
>On Sat, Dec 1, 2018 at 12:49 AM Dave Cramer wrote: > > Thanks, I have done a preliminary check and it seems pretty straightforward. > > I will clean it up for Monday Great, thank you!

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2018-11-30 Thread Dave Cramer
Dmitry, Thanks, I have done a preliminary check and it seems pretty straightforward. I will clean it up for Monday Thanks for your patience! Dave Cramer On Fri, 30 Nov 2018 at 18:22, Dmitry Dolgov <9erthali...@gmail.com> wrote: > On Sat, Dec 1, 2018 at 12:17 AM Dave Cramer wrote: > > > >

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2018-11-30 Thread Dmitry Dolgov
On Sat, Dec 1, 2018 at 12:17 AM Dave Cramer wrote: > > Why is this being closed? I did not see the first email looking for > clarification. Well, mostly due total absence of response and broken mind reading crystal ball. > I can certainly rebase it. Yes, please do. I'll change the CF item

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2018-11-30 Thread Dave Cramer
Why is this being closed? I did not see the first email looking for clarification. The history is the original author dropped off the planet (no idea where he is) I can certainly rebase it. Dave Cramer On Fri, 30 Nov 2018 at 18:00, Dmitry Dolgov <9erthali...@gmail.com> wrote: > > On Mon, Nov

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2018-11-30 Thread Dmitry Dolgov
> On Mon, Nov 19, 2018 at 4:58 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > On Tue, Jul 24, 2018 at 5:52 PM Dave Cramer wrote: > > > > Back in 2016 a patch was proposed that seems to have died on the vine. See > >

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2018-11-19 Thread Dmitry Dolgov
> On Tue, Jul 24, 2018 at 5:52 PM Dave Cramer wrote: > > Back in 2016 a patch was proposed that seems to have died on the vine. See > https://www.postgresql.org/message-id/flat/cafgjrd3hdyoa33m69tbeofnner2bzbwa8ffjt2v5vfztbvu...@mail.gmail.com > for the history and

Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

2018-07-24 Thread Dave Cramer
Back in 2016 a patch was proposed that seems to have died on the vine. See https://www.postgresql.org/message-id/flat/cafgjrd3hdyoa33m69tbeofnner2bzbwa8ffjt2v5vfztbvu...@mail.gmail.com for the history and https://commitfest.postgresql.org/10/621/ for the commitfest entry. I've rebased the