Re: Skip collecting decoded changes of already-aborted transactions

2024-03-27 Thread Masahiko Sawada
On Wed, Mar 27, 2024 at 8:49 PM Ajin Cherian wrote: > > > > On Mon, Mar 18, 2024 at 7:50 PM Masahiko Sawada wrote: >> >> >> In addition to these changes, I've made some changes to the latest >> patch. Here is the summary: >> >> - Use txn_flags field to record the transaction status instead of

Re: Skip collecting decoded changes of already-aborted transactions

2024-03-27 Thread Ajin Cherian
On Mon, Mar 18, 2024 at 7:50 PM Masahiko Sawada wrote: > > In addition to these changes, I've made some changes to the latest > patch. Here is the summary: > > - Use txn_flags field to record the transaction status instead of two > 'committed' and 'aborted' flags. > - Add regression tests. > -

Re: Skip collecting decoded changes of already-aborted transactions

2024-03-18 Thread Masahiko Sawada
On Fri, Mar 15, 2024 at 1:21 PM Ajin Cherian wrote: > > > > On Fri, Mar 15, 2024 at 3:17 PM Masahiko Sawada wrote: >> >> >> I resumed working on this item. I've attached the new version patch. >> >> I rebased the patch to the current HEAD and updated comments and >> commit messages. The patch is

Re: Skip collecting decoded changes of already-aborted transactions

2024-03-14 Thread Ajin Cherian
On Fri, Mar 15, 2024 at 3:17 PM Masahiko Sawada wrote: > > I resumed working on this item. I've attached the new version patch. > > I rebased the patch to the current HEAD and updated comments and > commit messages. The patch is straightforward and I'm somewhat > satisfied with it, but I'm

Re: Skip collecting decoded changes of already-aborted transactions

2024-02-14 Thread Masahiko Sawada
On Fri, Feb 2, 2024 at 12:48 AM vignesh C wrote: > > On Tue, 3 Oct 2023 at 15:54, vignesh C wrote: > > > > On Mon, 3 Jul 2023 at 07:16, Masahiko Sawada wrote: > > > > > > On Fri, Jun 23, 2023 at 12:39 PM Dilip Kumar > > > wrote: > > > > > > > > On Fri, Jun 9, 2023 at 10:47 AM Masahiko Sawada

Re: Skip collecting decoded changes of already-aborted transactions

2024-02-01 Thread vignesh C
On Tue, 3 Oct 2023 at 15:54, vignesh C wrote: > > On Mon, 3 Jul 2023 at 07:16, Masahiko Sawada wrote: > > > > On Fri, Jun 23, 2023 at 12:39 PM Dilip Kumar wrote: > > > > > > On Fri, Jun 9, 2023 at 10:47 AM Masahiko Sawada > > > wrote: > > > > > > > > Hi, > > > > > > > > In logical decoding,

Re: Skip collecting decoded changes of already-aborted transactions

2023-10-03 Thread vignesh C
On Mon, 3 Jul 2023 at 07:16, Masahiko Sawada wrote: > > On Fri, Jun 23, 2023 at 12:39 PM Dilip Kumar wrote: > > > > On Fri, Jun 9, 2023 at 10:47 AM Masahiko Sawada > > wrote: > > > > > > Hi, > > > > > > In logical decoding, we don't need to collect decoded changes of > > > aborted

Re: Skip collecting decoded changes of already-aborted transactions

2023-07-02 Thread Masahiko Sawada
On Fri, Jun 23, 2023 at 12:39 PM Dilip Kumar wrote: > > On Fri, Jun 9, 2023 at 10:47 AM Masahiko Sawada wrote: > > > > Hi, > > > > In logical decoding, we don't need to collect decoded changes of > > aborted transactions. While streaming changes, we can detect > > concurrent abort of the

Re: Skip collecting decoded changes of already-aborted transactions

2023-06-22 Thread Dilip Kumar
On Fri, Jun 9, 2023 at 10:47 AM Masahiko Sawada wrote: > > Hi, > > In logical decoding, we don't need to collect decoded changes of > aborted transactions. While streaming changes, we can detect > concurrent abort of the (sub)transaction but there is no mechanism to > skip decoding changes of

Re: Skip collecting decoded changes of already-aborted transactions

2023-06-22 Thread Amit Kapila
On Wed, Jun 21, 2023 at 8:12 AM Masahiko Sawada wrote: > > On Thu, Jun 15, 2023 at 7:50 PM Amit Kapila wrote: > > > > On Tue, Jun 13, 2023 at 2:06 PM Masahiko Sawada > > wrote: > > > > > > On Sun, Jun 11, 2023 at 5:31 AM Andres Freund wrote: > > > > > > > > A separate issue is that

Re: Skip collecting decoded changes of already-aborted transactions

2023-06-20 Thread Masahiko Sawada
On Thu, Jun 15, 2023 at 7:50 PM Amit Kapila wrote: > > On Tue, Jun 13, 2023 at 2:06 PM Masahiko Sawada wrote: > > > > On Sun, Jun 11, 2023 at 5:31 AM Andres Freund wrote: > > > > > > A separate issue is that TransactionIdDidAbort() can end up being very > > > slow if > > > a lot of

Re: Skip collecting decoded changes of already-aborted transactions

2023-06-15 Thread Amit Kapila
On Tue, Jun 13, 2023 at 2:06 PM Masahiko Sawada wrote: > > On Sun, Jun 11, 2023 at 5:31 AM Andres Freund wrote: > > > > A separate issue is that TransactionIdDidAbort() can end up being very slow > > if > > a lot of transactions are in progress concurrently. As soon as the clog > > buffers are

Re: Skip collecting decoded changes of already-aborted transactions

2023-06-13 Thread Masahiko Sawada
On Sun, Jun 11, 2023 at 5:31 AM Andres Freund wrote: > > Hi, > > On 2023-06-09 14:16:44 +0900, Masahiko Sawada wrote: > > In logical decoding, we don't need to collect decoded changes of > > aborted transactions. While streaming changes, we can detect > > concurrent abort of the (sub)transaction

Re: Skip collecting decoded changes of already-aborted transactions

2023-06-10 Thread Andres Freund
Hi, On 2023-06-09 14:16:44 +0900, Masahiko Sawada wrote: > In logical decoding, we don't need to collect decoded changes of > aborted transactions. While streaming changes, we can detect > concurrent abort of the (sub)transaction but there is no mechanism to > skip decoding changes of

Skip collecting decoded changes of already-aborted transactions

2023-06-08 Thread Masahiko Sawada
Hi, In logical decoding, we don't need to collect decoded changes of aborted transactions. While streaming changes, we can detect concurrent abort of the (sub)transaction but there is no mechanism to skip decoding changes of transactions that are known to already be aborted. With the attached WIP