On Fri, 20 Jan 2023 at 15:30, vignesh C wrote:
>
> On Wed, 16 Nov 2022 at 15:35, vignesh C wrote:
> >
> > On Wed, 16 Nov 2022 at 09:34, Ian Lawrence Barwick
> > wrote:
> > >
> > > 2022年11月7日(月) 22:39 vignesh C :
> > > >
> > > > On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick
> > > > wrote:
On Wed, 16 Nov 2022 at 15:35, vignesh C wrote:
>
> On Wed, 16 Nov 2022 at 09:34, Ian Lawrence Barwick wrote:
> >
> > 2022年11月7日(月) 22:39 vignesh C :
> > >
> > > On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick
> > > wrote:
> > > >
> > > > Hi
> > > >
> > > > cfbot reports the patch no longer
On Wed, 16 Nov 2022 at 09:34, Ian Lawrence Barwick wrote:
>
> 2022年11月7日(月) 22:39 vignesh C :
> >
> > On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick wrote:
> > >
> > > Hi
> > >
> > > cfbot reports the patch no longer applies [1]. As CommitFest 2022-11 is
> > > currently underway, this would
2022年11月7日(月) 22:39 vignesh C :
>
> On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick wrote:
> >
> > Hi
> >
> > cfbot reports the patch no longer applies [1]. As CommitFest 2022-11 is
> > currently underway, this would be an excellent time to update the patch.
> >
> > [1]
On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick wrote:
>
> Hi
>
> cfbot reports the patch no longer applies [1]. As CommitFest 2022-11 is
> currently underway, this would be an excellent time to update the patch.
>
> [1] http://cfbot.cputube.org/patch_40_3646.log
Here is an updated patch which
2022年8月19日(金) 2:41 vignesh C :
>
> On Mon, Aug 8, 2022 at 2:53 PM vignesh C wrote:
> >
> > On Mon, Aug 8, 2022 at 12:46 PM vignesh C wrote:
> > >
> > > On Fri, Jun 3, 2022 at 3:36 PM vignesh C wrote:
> > > >
> > > > On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com
> > > > wrote:
> >
On Mon, Aug 8, 2022 at 2:53 PM vignesh C wrote:
>
> On Mon, Aug 8, 2022 at 12:46 PM vignesh C wrote:
> >
> > On Fri, Jun 3, 2022 at 3:36 PM vignesh C wrote:
> > >
> > > On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com
> > > wrote:
> > > >
> > > > On Monday, May 23, 2022 2:13 PM
On Thu, Aug 18, 2022 at 12:33 PM Nitin Jadhav
wrote:
>
> I spent some time on understanding the proposal and the patch. Here
> are a few comments wrt the test cases.
>
> > +ALTER PUBLICATION testpub_reset ADD TABLE pub_sch1.tbl1;
> > +
> > +-- Verify that tables associated with the publication
I spent some time on understanding the proposal and the patch. Here
are a few comments wrt the test cases.
> +ALTER PUBLICATION testpub_reset ADD TABLE pub_sch1.tbl1;
> +
> +-- Verify that tables associated with the publication are dropped after RESET
> +\dRp+ testpub_reset
> +ALTER PUBLICATION
On Mon, Aug 8, 2022 at 12:46 PM vignesh C wrote:
>
> On Fri, Jun 3, 2022 at 3:36 PM vignesh C wrote:
> >
> > On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > On Monday, May 23, 2022 2:13 PM vignesh C wrote:
> > > > Attached v7 patch which fixes the buildfarm
On Fri, Jun 3, 2022 at 3:36 PM vignesh C wrote:
>
> On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Monday, May 23, 2022 2:13 PM vignesh C wrote:
> > > Attached v7 patch which fixes the buildfarm warning for an unused warning
> > > in
> > > release mode as in
On Tue, Jun 14, 2022 at 9:10 AM houzj.f...@fujitsu.com
wrote:
>
> On Wednesday, June 8, 2022 7:04 PM Amit Kapila
> wrote:
> >
> > On Fri, Jun 3, 2022 at 3:37 PM vignesh C wrote:
> > >
> > > Thanks for the comments, the attached v8 patch has the changes for the
> > same.
> > >
> >
> > AFAICS,
On Wednesday, June 8, 2022 7:04 PM Amit Kapila wrote:
>
> On Fri, Jun 3, 2022 at 3:37 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v8 patch has the changes for the
> same.
> >
>
> AFAICS, the summary of this proposal is that we want to support
> exclude of certain objects
On Fri, Jun 3, 2022 at 3:37 PM vignesh C wrote:
>
> Thanks for the comments, the attached v8 patch has the changes for the same.
>
AFAICS, the summary of this proposal is that we want to support
exclude of certain objects from publication with two kinds of
variants. The first variant is to add
On Tue, May 31, 2022 at 11:51 AM Peter Smith wrote:
>
> Here are my review comments for patch v7-0002.
>
> ==
>
> 1. doc/src/sgml/logical-replication.sgml
>
> @@ -1167,8 +1167,9 @@ CONTEXT: processing remote data for replication
> origin "pg_16395" during "INSER
>
> To add tables to
'On Mon, May 30, 2022 at 1:51 PM Peter Smith wrote:
>
> Here are some minor review comments for v7-0001.
>
> ==
>
> 1. General
>
> Probably the commit message and all the PG docs and code comments
> should be changed to refer to "publication parameters" instead of
> (currently) "publication
On Thu, May 26, 2022 at 7:04 PM osumi.takami...@fujitsu.com
wrote:
>
> On Monday, May 23, 2022 2:13 PM vignesh C wrote:
> > Attached v7 patch which fixes the buildfarm warning for an unused warning in
> > release mode as in [1].
> Hi, thank you for the patches.
>
>
> I'll share several review
Here are my review comments for patch v7-0002.
==
1. doc/src/sgml/logical-replication.sgml
@@ -1167,8 +1167,9 @@ CONTEXT: processing remote data for replication
origin "pg_16395" during "INSER
To add tables to a publication, the user must have ownership rights on the
table. To
Here are some minor review comments for v7-0001.
==
1. General
Probably the commit message and all the PG docs and code comments
should be changed to refer to "publication parameters" instead of
(currently) "publication options". This is because these things are
really called
On Monday, May 23, 2022 2:13 PM vignesh C wrote:
> Attached v7 patch which fixes the buildfarm warning for an unused warning in
> release mode as in [1].
Hi, thank you for the patches.
I'll share several review comments.
For v7-0001.
(1) I'll suggest some minor rewording.
+
+ The RESET
On Sat, May 21, 2022 at 11:06 AM vignesh C wrote:
>
> On Fri, May 20, 2022 at 11:23 AM Peter Smith wrote:
> >
> > Below are my review comments for v6-0002.
> >
> > ==
> >
> > 1. Commit message.
> > The psql \d family of commands to display excluded tables.
> >
> > SUGGESTION
> > The psql \d
On Fri, May 20, 2022 at 11:23 AM Peter Smith wrote:
>
> Below are my review comments for v6-0002.
>
> ==
>
> 1. Commit message.
> The psql \d family of commands to display excluded tables.
>
> SUGGESTION
> The psql \d family of commands can now display excluded tables.
Modified
> ~~~
>
> 2.
On Fri, May 20, 2022 at 5:49 AM Peter Smith wrote:
>
> FYI, although the v6-0002 patch applied cleanly, I found that the SGML
> was malformed and so the pg docs build fails.
>
> ~~~
> e.g.
>
> [postgres@CentOS7-x64 sgml]$ make STYLE=website html
> { \
> echo ""; \
> echo ""; \
> } >
On Thu, May 19, 2022 at 1:49 PM Peter Smith wrote:
>
> Below are my review comments for v6-0001.
>
> ==
>
> 1. General.
>
> The patch failed 'publication' tests in the make check phase.
>
> Please add this work to the commit-fest so that the 'cfbot' can report
> such errors sooner.
Added
Below are my review comments for v6-0002.
==
1. Commit message.
The psql \d family of commands to display excluded tables.
SUGGESTION
The psql \d family of commands can now display excluded tables.
~~~
2. doc/src/sgml/ref/alter_publication.sgml
@@ -22,6 +22,7 @@ PostgreSQL documentation
On Fri, May 20, 2022 at 10:19 AM Peter Smith wrote:
>
> FYI, although the v6-0002 patch applied cleanly, I found that the SGML
> was malformed and so the pg docs build fails.
>
> ~~~
> e.g.
>
> [postgres@CentOS7-x64 sgml]$ make STYLE=website html
> { \
> echo ""; \
> echo ""; \
> } >
FYI, although the v6-0002 patch applied cleanly, I found that the SGML
was malformed and so the pg docs build fails.
~~~
e.g.
[postgres@CentOS7-x64 sgml]$ make STYLE=website html
{ \
echo ""; \
echo ""; \
} > version.sgml
'/usr/bin/perl' ./mk_feature_tables.pl YES
Below are my review comments for v6-0001.
==
1. General.
The patch failed 'publication' tests in the make check phase.
Please add this work to the commit-fest so that the 'cfbot' can report
such errors sooner.
~~~
2. src/backend/commands/publicationcmds.c - AlterPublicationReset
+/*
+ *
On Tue, May 17, 2022 at 7:35 AM Peter Smith wrote:
>
> Below are my review comments for v5-0002.
>
> There may be an overlap with comments recently posted by Osumi-san [1].
>
> (I also have review comments for v5-0002; will post them tomorrow)
>
> ==
>
> 1. General
>
> Is it really necessary
On Thursday, May 19, 2022 2:45 AM vignesh C wrote:
> On Mon, May 16, 2022 at 8:32 AM osumi.takami...@fujitsu.com
> wrote:
> > (3) src/test/regress/expected/publication.out
> >
> > +-- Verify that only superuser can reset a publication ALTER
> > +PUBLICATION testpub_reset OWNER TO
On Mon, May 16, 2022 at 2:00 PM osumi.takami...@fujitsu.com
wrote:
>
> On Saturday, May 14, 2022 10:33 PM vignesh C wrote:
> > Thanks for the comments, the attached v5 patch has the changes for the same.
> > Also I have made the changes for SKIP Table based on the new syntax, the
> > changes for
On Wed, May 18, 2022 at 8:30 AM shiy.f...@fujitsu.com
wrote:
>
> On Sat, May 14, 2022 9:33 PM vignesh C wrote:
> >
> > Thanks for the comments, the attached v5 patch has the changes for the
> > same. Also I have made the changes for SKIP Table based on the new
> > syntax, the changes for the
On Mon, May 16, 2022 at 2:53 PM Peter Smith wrote:
>
> Below are my review comments for v5-0001.
>
> There is some overlap with comments recently posted by Osumi-san [1].
>
> (I also have review comments for v5-0002; will post them tomorrow)
>
> ==
>
> 1. Commit message
>
> This patch adds a
On Mon, May 16, 2022 at 8:32 AM osumi.takami...@fujitsu.com
wrote:
>
> On Saturday, May 14, 2022 10:33 PM vignesh C wrote:
> > Thanks for the comments, the attached v5 patch has the changes for the same.
> > Also I have made the changes for SKIP Table based on the new syntax, the
> > changes for
On Sat, May 14, 2022 9:33 PM vignesh C wrote:
>
> Thanks for the comments, the attached v5 patch has the changes for the
> same. Also I have made the changes for SKIP Table based on the new
> syntax, the changes for the same are available in
>
On Tue, May 17, 2022 at 1:56 PM Amit Kapila wrote:
>
> On Tue, May 17, 2022 at 7:35 AM Peter Smith wrote:
> >
> > Below are my review comments for v5-0002.
> >
> > There may be an overlap with comments recently posted by Osumi-san [1].
> >
> > (I also have review comments for v5-0002; will post
On Tue, May 17, 2022 at 7:35 AM Peter Smith wrote:
>
> Below are my review comments for v5-0002.
>
> There may be an overlap with comments recently posted by Osumi-san [1].
>
> (I also have review comments for v5-0002; will post them tomorrow)
>
> ==
>
> 1. General
>
> Is it really necessary
Below are my review comments for v5-0002.
There may be an overlap with comments recently posted by Osumi-san [1].
(I also have review comments for v5-0002; will post them tomorrow)
==
1. General
Is it really necessary to have to say "EXCEPT TABLE" instead of just
"EXCEPT". It seems
Below are my review comments for v5-0001.
There is some overlap with comments recently posted by Osumi-san [1].
(I also have review comments for v5-0002; will post them tomorrow)
==
1. Commit message
This patch adds a new RESET clause to ALTER PUBLICATION which will reset
the publication
On Saturday, May 14, 2022 10:33 PM vignesh C wrote:
> Thanks for the comments, the attached v5 patch has the changes for the same.
> Also I have made the changes for SKIP Table based on the new syntax, the
> changes for the same are available in
>
On Saturday, May 14, 2022 10:33 PM vignesh C wrote:
> Thanks for the comments, the attached v5 patch has the changes for the same.
> Also I have made the changes for SKIP Table based on the new syntax, the
> changes for the same are available in
>
On Fri, May 13, 2022 at 9:37 AM Peter Smith wrote:
>
> On Thu, May 12, 2022 at 2:24 PM vignesh C wrote:
> >
> ...
> > The attached patch has the implementation for "ALTER PUBLICATION
> > pubname RESET". This command will reset the publication to default
> > state which includes resetting the
On Thu, May 12, 2022 at 2:24 PM vignesh C wrote:
>
...
> The attached patch has the implementation for "ALTER PUBLICATION
> pubname RESET". This command will reset the publication to default
> state which includes resetting the publication options, setting ALL
> TABLES option to false and
On Tue, May 10, 2022 at 9:08 AM vignesh C wrote:
>
> On Fri, May 6, 2022 at 8:05 AM Peter Smith wrote:
> >
> > On Thu, Apr 28, 2022 at 9:32 PM Amit Kapila wrote:
> > >
> > ...
> > >
> > > Another idea that occurred to me today for tables this is as follows:
> > > 1. Allow to mention except
On Fri, May 6, 2022 at 8:05 AM Peter Smith wrote:
>
> On Thu, Apr 28, 2022 at 9:32 PM Amit Kapila wrote:
> >
> ...
> >
> > Another idea that occurred to me today for tables this is as follows:
> > 1. Allow to mention except during create publication ... For All Tables.
> > CREATE PUBLICATION
On Thu, Apr 28, 2022 at 9:32 PM Amit Kapila wrote:
>
...
>
> Another idea that occurred to me today for tables this is as follows:
> 1. Allow to mention except during create publication ... For All Tables.
> CREATE PUBLICATION pub1 FOR ALL TABLES EXCEPT TABLE t1,t2;
> 2. Allow to Reset it. This
On Thu, May 5, 2022 at 9:20 AM Amit Kapila wrote:
>
> On Wed, May 4, 2022 at 7:05 PM Peter Eisentraut
> wrote:
> >
> > On 14.04.22 15:47, Peter Eisentraut wrote:
> > > That said, I'm not sure this feature is worth the trouble. If this is
> > > useful, what about "whole database except these
On Wed, May 4, 2022 at 7:05 PM Peter Eisentraut
wrote:
>
> On 14.04.22 15:47, Peter Eisentraut wrote:
> > That said, I'm not sure this feature is worth the trouble. If this is
> > useful, what about "whole database except these schemas"? What about
> > "create this database from this template
On 14.04.22 15:47, Peter Eisentraut wrote:
That said, I'm not sure this feature is worth the trouble. If this is
useful, what about "whole database except these schemas"? What about
"create this database from this template except these schemas". This
could get out of hand. I think we
On Tue, May 3, 2022 at 2:24 PM Peter Smith wrote:
>
> On Thu, Apr 28, 2022 at 9:32 PM Amit Kapila wrote:
> >
> ...
> > Another idea that occurred to me today for tables this is as follows:
> > 1. Allow to mention except during create publication ... For All Tables.
> > CREATE PUBLICATION pub1
On Thu, Apr 28, 2022 at 9:32 PM Amit Kapila wrote:
>
...
> Another idea that occurred to me today for tables this is as follows:
> 1. Allow to mention except during create publication ... For All Tables.
> CREATE PUBLICATION pub1 FOR ALL TABLES EXCEPT TABLE t1,t2;
> 2. Allow to Reset it. This new
On Thu, Apr 28, 2022 at 4:50 PM osumi.takami...@fujitsu.com
wrote:
>
> On Wednesday, April 27, 2022 9:50 PM vignesh C wrote:
> > Thanks for the comments, the attached v3 patch has the changes for the same.
> Hi
>
> Thank you for updating the patch. Several minor comments on v3.
>
> (1) commit
On Fri, Apr 22, 2022 at 9:39 PM Bharath Rupireddy
wrote:
>
> On Tue, Mar 22, 2022 at 12:39 PM vignesh C wrote:
> >
> > This feature adds an option to skip changes of all tables in specified
> > schema while creating publication.
> > This feature is helpful for use cases where the user wants to
>
On Wednesday, April 27, 2022 9:50 PM vignesh C wrote:
> Thanks for the comments, the attached v3 patch has the changes for the same.
Hi
Thank you for updating the patch. Several minor comments on v3.
(1) commit message
The new syntax allows specifying schemas. For example:
CREATE PUBLICATION
On Tue, Apr 26, 2022 at 11:32 AM osumi.takami...@fujitsu.com
wrote:
>
> On Thursday, April 21, 2022 12:15 PM vignesh C wrote:
> > Updated patch by changing the syntax to use EXCEPT instead of SKIP.
> Hi
>
>
> This is my review comments on the v2 patch.
>
> (1) gram.y
>
> I think we can make a
On Thursday, April 21, 2022 12:15 PM vignesh C wrote:
> Updated patch by changing the syntax to use EXCEPT instead of SKIP.
Hi
This is my review comments on the v2 patch.
(1) gram.y
I think we can make a unified function that merges
preprocess_alltables_pubobj_list with
On Sat, Apr 23, 2022 at 2:09 AM Bharath Rupireddy
wrote:
>
> On Tue, Mar 22, 2022 at 12:39 PM vignesh C wrote:
> >
> > Hi,
> >
> > This feature adds an option to skip changes of all tables in specified
> > schema while creating publication.
> > This feature is helpful for use cases where the
On Tue, Mar 22, 2022 at 12:39 PM vignesh C wrote:
>
> Hi,
>
> This feature adds an option to skip changes of all tables in specified
> schema while creating publication.
> This feature is helpful for use cases where the user wants to
> subscribe to all the changes except for the changes present
On Mon, Apr 18, 2022 at 12:32 PM Amit Kapila wrote:
>
> On Fri, Apr 15, 2022 at 1:26 AM Euler Taveira wrote:
> >
> > On Thu, Apr 14, 2022, at 10:47 AM, Peter Eisentraut wrote:
> >
> > On 12.04.22 08:23, vignesh C wrote:
> > > I have also included the implementation for skipping a few tables from
On Thu, Apr 14, 2022 at 7:18 PM Peter Eisentraut
wrote:
>
> On 12.04.22 08:23, vignesh C wrote:
> > I have also included the implementation for skipping a few tables from
> > all tables publication, the 0002 patch has the implementation for the
> > same.
> > This feature is helpful for use cases
On Fri, Apr 15, 2022 at 1:26 AM Euler Taveira wrote:
>
> On Thu, Apr 14, 2022, at 10:47 AM, Peter Eisentraut wrote:
>
> On 12.04.22 08:23, vignesh C wrote:
> > I have also included the implementation for skipping a few tables from
> > all tables publication, the 0002 patch has the implementation
On Thu, Apr 14, 2022, at 10:47 AM, Peter Eisentraut wrote:
> On 12.04.22 08:23, vignesh C wrote:
> > I have also included the implementation for skipping a few tables from
> > all tables publication, the 0002 patch has the implementation for the
> > same.
> > This feature is helpful for use cases
On 12.04.22 08:23, vignesh C wrote:
I have also included the implementation for skipping a few tables from
all tables publication, the 0002 patch has the implementation for the
same.
This feature is helpful for use cases where the user wants to
subscribe to all the changes except for the changes
On Tue, Apr 12, 2022 at 2:23 PM vignesh C wrote:
> The patch does not apply on top of HEAD because of the recent commit,
> attached patch is rebased on top of HEAD.
Thanks for your patches.
Here are some comments for v1-0001:
1.
I found the patch add the following two new functions in gram.y:
On Tue, Apr 12, 2022 2:23 PM vignesh C wrote:
>
> The patch does not apply on top of HEAD because of the recent commit,
> attached patch is rebased on top of HEAD.
>
Thanks for your patch. Here are some comments for 0001 patch.
1. doc/src/sgml/catalogs.sgml
@@ -6438,6 +6438,15 @@
On Wed, Apr 13, 2022 at 2:40 PM Amit Kapila wrote:
>
> On Wed, Apr 13, 2022 at 8:45 AM vignesh C wrote:
> >
> > On Tue, Apr 12, 2022 at 4:46 PM Amit Kapila wrote:
> > >
> > > I understand that part but what I pointed out was that it might be
> > > better to avoid using ADD keyword in this
On Wed, Apr 13, 2022 at 8:45 AM vignesh C wrote:
>
> On Tue, Apr 12, 2022 at 4:46 PM Amit Kapila wrote:
> >
> > I understand that part but what I pointed out was that it might be
> > better to avoid using ADD keyword in this syntax like: ALTER
> > PUBLICATION pub1 SKIP TABLE t1,t2;
>
> Currently
On Tue, Apr 12, 2022 at 4:46 PM Amit Kapila wrote:
>
> On Tue, Apr 12, 2022 at 4:17 PM vignesh C wrote:
> >
> > On Tue, Apr 12, 2022 at 12:19 PM Amit Kapila
> > wrote:
> > >
> > >
> > > For the second syntax (Alter Publication ...), isn't it better to
> > > avoid using ADD? It looks odd to me
On Tue, Apr 12, 2022 at 4:17 PM vignesh C wrote:
>
> On Tue, Apr 12, 2022 at 12:19 PM Amit Kapila wrote:
> >
> >
> > For the second syntax (Alter Publication ...), isn't it better to
> > avoid using ADD? It looks odd to me because we are not adding anything
> > in publication with this sytax.
>
On Tue, Apr 12, 2022 at 12:19 PM Amit Kapila wrote:
>
> On Tue, Apr 12, 2022 at 11:53 AM vignesh C wrote:
> >
> > On Sat, Mar 26, 2022 at 7:37 PM vignesh C wrote:
> > >
> > > On Tue, Mar 22, 2022 at 12:38 PM vignesh C wrote:
> > > >
> > > > Hi,
> > > >
> > > > This feature adds an option to
On Tue, Apr 12, 2022 at 11:53 AM vignesh C wrote:
>
> On Sat, Mar 26, 2022 at 7:37 PM vignesh C wrote:
> >
> > On Tue, Mar 22, 2022 at 12:38 PM vignesh C wrote:
> > >
> > > Hi,
> > >
> > > This feature adds an option to skip changes of all tables in specified
> > > schema while creating
On Tue, Mar 22, 2022 at 12:38 PM vignesh C wrote:
>
> Hi,
>
> This feature adds an option to skip changes of all tables in specified
> schema while creating publication.
> This feature is helpful for use cases where the user wants to
> subscribe to all the changes except for the changes present
Hi,
This feature adds an option to skip changes of all tables in specified
schema while creating publication.
This feature is helpful for use cases where the user wants to
subscribe to all the changes except for the changes present in a few
schemas.
Ex:
CREATE PUBLICATION pub1 FOR ALL TABLES SKIP
73 matches
Mail list logo
