Re: Small miscellaneous fixes

On Sat, Nov 26, 2022 at 11:30:07AM -0300, Ranier Vilela wrote: > Thank you Michael, for taking care of it. (As of 1e31484, after finishing the tests I wanted.) -- Michael signature.asc Description: PGP signature

Re: Small miscellaneous fixes

Em sex., 25 de nov. de 2022 às 22:21, Michael Paquier escreveu: > On Fri, Nov 25, 2022 at 01:15:40PM +0100, Peter Eisentraut wrote: > > Is this something you want to follow up on, since you were involved in > that > > patch? Is the redundant assignment simply to be deleted, or do you want > to

Re: Small miscellaneous fixes

On Fri, Nov 25, 2022 at 01:15:40PM +0100, Peter Eisentraut wrote: > Is this something you want to follow up on, since you were involved in that > patch? Is the redundant assignment simply to be deleted, or do you want to > check the original patch again for context? Most of the changes of this

Re: Small miscellaneous fixes

On 04.10.22 06:18, Michael Paquier wrote: On Mon, Oct 03, 2022 at 08:05:57AM -0300, Ranier Vilela wrote: Em seg., 3 de out. de 2022 às 05:01, Masahiko Sawada escreveu: On Fri, Sep 30, 2022 at 9:08 AM Ranier Vilela wrote: 1. Avoid useless reassigning var _logsegno

Re: Small miscellaneous fixes

Em qua., 16 de nov. de 2022 às 03:59, Michael Paquier escreveu: > On Tue, Oct 04, 2022 at 08:23:16AM -0300, Ranier Vilela wrote: > > Both are correct, I missed the pqsignal calls. > > > > Attached patch to change this. > > The change for pgbench is missing and this is only changing >

Re: Small miscellaneous fixes

On Tue, Oct 04, 2022 at 08:23:16AM -0300, Ranier Vilela wrote: > Both are correct, I missed the pqsignal calls. > > Attached patch to change this. The change for pgbench is missing and this is only changing pg_test_fsync. Switching to sig_atomic_t would be fine on non-WIN32 as these are used in

Re: Small miscellaneous fixes

Em ter., 4 de out. de 2022 às 01:18, Michael Paquier escreveu: > On Mon, Oct 03, 2022 at 08:05:57AM -0300, Ranier Vilela wrote: > > Em seg., 3 de out. de 2022 às 05:01, Masahiko Sawada < > sawada.m...@gmail.com> > > escreveu: > >> On Fri, Sep 30, 2022 at 9:08 AM Ranier Vilela > wrote: > >>> 1.

Re: Small miscellaneous fixes

On Mon, Oct 03, 2022 at 08:05:57AM -0300, Ranier Vilela wrote: > Em seg., 3 de out. de 2022 às 05:01, Masahiko Sawada > escreveu: >> On Fri, Sep 30, 2022 at 9:08 AM Ranier Vilela wrote: >>> 1. Avoid useless reassigning var _logsegno >> (src/backend/access/transam/xlog.c) >>> Commit 7d70809 left

Re: Small miscellaneous fixes

Em seg., 3 de out. de 2022 às 05:01, Masahiko Sawada escreveu: > On Fri, Sep 30, 2022 at 9:08 AM Ranier Vilela wrote: > > > > Hi. > > > > There are assorted fixes to the head branch. > > > > 1. Avoid useless reassigning var _logsegno > (src/backend/access/transam/xlog.c) > > Commit 7d70809 left

Re: Small miscellaneous fixes

On Fri, Sep 30, 2022 at 9:08 AM Ranier Vilela wrote: > > Hi. > > There are assorted fixes to the head branch. > > 1. Avoid useless reassigning var _logsegno (src/backend/access/transam/xlog.c) > Commit 7d70809 left a little oversight. > XLByteToPrevSeg and XLByteToSeg are macros, and both assign

Small miscellaneous fixes

Hi. There are assorted fixes to the head branch. 1. Avoid useless reassigning var _logsegno (src/backend/access/transam/xlog.c) Commit 7d70809 left a little oversight. XLByteToPrevSeg and XLByteToSeg are