On Thu, 29 Feb 2024 at 09:50, Alvaro Herrera wrote:
>
> By all means let's get the feature out there. It's not a frequently
> requested thing but it does seem to come up.
>
Pushed. Thanks for reviewing.
Regards,
Dean
On 2024-Feb-29, Dean Rasheed wrote:
> Going over this again, I spotted a bug -- the UPDATE path in
> ExecMergeMatched() wasn't calling ExecUpdateEpilogue() for
> trigger-updatable views, because it wasn't setting updateCxt.updated
> to true. (This matters if you have an auto-updatable view WITH
On 2024-Jan-29, Dean Rasheed wrote:
> Yeah, for all practical purposes, that check in CheckValidResultRel()
> has been dead code since d751ba5235, but I think it's still worth
> doing, and if we're going to do it, we should do it properly. I don't
> like using elog() in some cases and ereport()
Thanks for working on this. The patch looks well finished. I didn't
try to run it, though. I gave it a read and found nothing to complain
about, just these two pretty minor comments:
On 2024-Jan-26, Dean Rasheed wrote:
> diff --git a/src/backend/executor/execMain.c
On Mon, 30 Oct 2023 at 15:04, Dean Rasheed wrote:
>
> On Sun, 29 Oct 2023 at 17:17, Dean Rasheed wrote:
> >
> > On Sat, 28 Oct 2023 at 09:35, jian he wrote:
> > >
> > > Do we need to add > >
> > We don't want to include MERGE in that sentence, because MERGE
On Sat, 28 Oct 2023 at 09:35, jian he wrote:
>
> hi.
> Excellent work! regress test passed! The code looks so intuitive!
>
Thanks for looking!
> doc/src/sgml/ref/create_view.sgml.
> Do we need to add
> If the view or any of its base
> relations has an
hi.
Excellent work! regress test passed! The code looks so intuitive!
doc/src/sgml/ref/create_view.sgml.
Do we need to add
