Re: Track Oldest Initialized WAL Buffer Page

2023-10-17 Thread Bharath Rupireddy
On Mon, Jul 3, 2023 at 6:57 PM Heikki Linnakangas wrote: > Thanks a lot for responding. Sorry for being late. > On 07/02/2023 16:00, Bharath Rupireddy wrote: > > Hi, > > > > While working on [1], I was looking for a quick way to tell if a WAL > > record is present in the WAL buffers array

Re: Track Oldest Initialized WAL Buffer Page

2023-08-03 Thread Daniel Gustafsson
> On 3 Jul 2023, at 15:27, Heikki Linnakangas wrote: > But I don't see the point of tracking OldestInitializedPage. It seems cheap > enough that we could, if there's a need for it, but I don't see the need. Based on the above comments, and the thread stalling, I am marking this returned with

Re: Track Oldest Initialized WAL Buffer Page

2023-07-03 Thread Heikki Linnakangas
On 07/02/2023 16:00, Bharath Rupireddy wrote: Hi, While working on [1], I was looking for a quick way to tell if a WAL record is present in the WAL buffers array without scanning but I couldn't find one. /* The end-ptr of the page that contains the record */ expectedEndPtr += XLOG_BLCKSZ -

Re: Track Oldest Initialized WAL Buffer Page

2023-02-28 Thread Bharath Rupireddy
On Wed, Mar 1, 2023 at 9:49 AM Nathan Bossart wrote: > > On Tue, Feb 28, 2023 at 11:12:29AM +0530, Bharath Rupireddy wrote: > > On Tue, Feb 28, 2023 at 5:52 AM Nathan Bossart > > wrote: > >> It's confusing to me that OldestInitializedPage is set to NewPageBeginPtr. > >> Doesn't that set it to

Re: Track Oldest Initialized WAL Buffer Page

2023-02-28 Thread Nathan Bossart
On Tue, Feb 28, 2023 at 11:12:29AM +0530, Bharath Rupireddy wrote: > On Tue, Feb 28, 2023 at 5:52 AM Nathan Bossart > wrote: >> It's confusing to me that OldestInitializedPage is set to NewPageBeginPtr. >> Doesn't that set it to the beginning of the newest initialized page? > > Yes, that's the

Re: Track Oldest Initialized WAL Buffer Page

2023-02-27 Thread Bharath Rupireddy
gt;OldestInitializedPage != XLogCtl->InitializedUpTo); Thanks for looking at it. I'm attaching v2 patch with the above review comment addressed for further review. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com From b20ddef1ca

Re: Track Oldest Initialized WAL Buffer Page

2023-02-27 Thread Nathan Bossart
On Tue, Feb 07, 2023 at 07:30:00PM +0530, Bharath Rupireddy wrote: > + /* > + * Try updating oldest initialized XLog buffer page. > + * > + * Update it if we are initializing an XLog buffer page for the > first > + * time or if XLog

Track Oldest Initialized WAL Buffer Page

2023-02-07 Thread Bharath Rupireddy
PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com From 683f8f2764970ca5737039577d64c91e491908d6 Mon Sep 17 00:00:00 2001 From: Bharath Rupireddy Date: Mon, 6 Feb 2023 06:58:54 + Subject: [PATCH v1] Track Oldest Initialized WAL Buffer Page --- src