On Tue, Apr 18, 2023 at 11:35:41AM -0400, Robert Haas wrote:
> On Mon, Apr 17, 2023 at 1:30 AM Michael Paquier wrote:
>> FWIW, doing that now rather than the beginning of July is OK for me
>> for this stuff.
>
> OK, committed.
Thanks!
--
Michael
signature.asc
Description: PGP signature
On Mon, Apr 17, 2023 at 1:30 AM Michael Paquier wrote:
> FWIW, doing that now rather than the beginning of July is OK for me
> for this stuff.
OK, committed.
--
Robert Haas
EDB: http://www.enterprisedb.com
On Fri, Apr 14, 2023 at 04:11:47PM -0400, Robert Haas wrote:
> Do people think it's OK to do that now, or should I wait until we've
> branched? I personally think this is bug-fix-ish enough that now is
> OK, but I'll certainly forebear if others disagree.
FWIW, doing that now rather than the
On Tue, Mar 28, 2023 at 9:40 PM Michael Paquier wrote:
> Looking at the patch, nothing really stands out..
It doesn't seem like anyone's unhappy about this patch. I don't think
it's necessary to back-patch it, given that in-place tablespaces are
intended for developer use, not real-world use,
On Tue, Mar 28, 2023 at 05:15:25PM +1300, Thomas Munro wrote:
> The commit message explains pretty well, and it seems to work in
> simple testing, and yeah commit c6f2f016 was not a work of art.
> pg_basebackeup --format=plain "worked", but your way is better. I
> guess we should add a test of
On Tue, Mar 28, 2023 at 5:15 PM Thomas Munro wrote:
> I guess we should add a test of -Fp too, to keep it working?
Oops, that was already tested in existing tests, so I take that back.
The commit message explains prettty well, and it seems to work in
simple testing, and yeah commit c6f2f016 was not a work of art.
pg_basebackeup --format=plain "worked", but your way is better. I
guess we should add a test of -Fp too, to keep it working? Here's one
of those.
I know it's not
On Tue, Mar 21, 2023 at 7:59 PM Michael Paquier wrote:
> On Mon, Mar 20, 2023 at 07:56:42AM -0400, Robert Haas wrote:
> > Anyone want to comment on this?
>
> I have not checked the patch in details, but perhaps this needs at
> least one test?
Sure. I was sort of hoping to get feedback on the
On Mon, Mar 20, 2023 at 07:56:42AM -0400, Robert Haas wrote:
> Anyone want to comment on this?
I have not checked the patch in details, but perhaps this needs at
least one test?
--
Michael
signature.asc
Description: PGP signature
On Thu, Mar 9, 2023 at 4:15 PM Robert Haas wrote:
> Now that I'm done grumbling, here's a patch.
Anyone want to comment on this?
--
Robert Haas
EDB: http://www.enterprisedb.com
On Wed, Mar 8, 2023 at 9:52 PM Thomas Munro wrote:
> Yeah. We knew that this didn't work (was discussed in a couple of
> other threads), but you might be right that an error would be better
> for now. It's absolutely not a user facing mode of operation, it was
> intended just for the
At Thu, 09 Mar 2023 11:53:26 +0900 (JST), I wrote
> It turned out to be not as simple as I thought, though...
The error message and the location where the error condition is
checked don't match, but making the messages more generic may not be
helpful for users..
regards.
--
Kyotaro Horiguchi
At Thu, 09 Mar 2023 10:58:41 +0900 (JST), I wrote
> behavior for that purpose. I believe it is reasonable to make
> basebackup error-out when it encounters an in-place tablespace
> directory when TABLESPACE_MAP is activated.
It turned out to be not as simple as I thought, though...
regards.
--
On Thu, Mar 9, 2023 at 2:58 PM Kyotaro Horiguchi
wrote:
> At Wed, 8 Mar 2023 16:30:05 -0500, Robert Haas wrote
> in
> > I'm not sure how messy it's going to be to clean this up. I think each
> > tablespace really needs to go into a separate ${TSOID}.tar file,
> > because we've got tons of code
At Wed, 8 Mar 2023 16:30:05 -0500, Robert Haas wrote in
> Commit 7170f2159fb21b62c263acd458d781e2f3c3f8bb, which introduced
> in-place tablespaces, didn't make any adjustments to pg_basebackup.
> The resulting behavior is pretty bizarre.
>
> If you take a plain-format backup using pg_basebackup
Commit 7170f2159fb21b62c263acd458d781e2f3c3f8bb, which introduced
in-place tablespaces, didn't make any adjustments to pg_basebackup.
The resulting behavior is pretty bizarre.
If you take a plain-format backup using pg_basebackup -Fp, then the
files in the in-place tablespace are backed up, but
16 matches
Mail list logo
