Justin Pryzby writes:
> Some modest cleanups I've accumulated
Hi Justin.
0001:
Regarding initializer {0}, the problem is still with old compilers, which
don't initialize exactly like memset.
Only more modern compilers fill in any "holes" that may exist.
This means that as old compilers are not
On Thu, Nov 24, 2022 at 12:53 AM Tom Lane wrote:
>
> Justin Pryzby writes:
> > Some modest cleanups I've accumulated.
> 0004: Right, somebody injected code in a poorly chosen place
> (yet another victim of the "add at the end" anti-pattern).
I've pushed 0004.
--
John Naylor
EDB:
On Wed, Nov 23, 2022 at 12:53 PM Tom Lane wrote:
> at least for bool arrays, that's true of memset'ing as well. But this,
> if you decide you need something other than zeroes, is a foot-gun.
> In particular, someone whose C is a bit weak might mistakenly think that
>
> bool
Justin Pryzby writes:
> Some modest cleanups I've accumulated.
Hmm ...
I don't especially care for either 0001 or 0002, mainly because
I do not agree that this is good style:
- boolnulls[PG_STAT_GET_RECOVERY_PREFETCH_COLS];
+ bool
Some modest cleanups I've accumulated.
>From 9c5846cc3f04c6797696a234fac0953815e09e4b Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Sun, 23 Oct 2022 14:52:48 -0500
Subject: [PATCH 1/6] WIP: do not loop to set an array to false
See also:
9fd45870c1436b477264c0c82eb195df52bc0919
