Re: docs: note ownership requirement for refreshing materialized views

2018-08-18 Thread Michael Paquier
On Fri, Aug 17, 2018 at 05:12:42PM -0400, Jonathan S. Katz wrote: >> On Aug 17, 2018, at 9:21 AM, Tom Lane wrote: >> Dave Cramer writes: >>> So it seems this patch is being ignored in this thread. >> >> Well, Jonathan did kind of hijack what appears to be a thread about >> documentation (with

Re: docs: note ownership requirement for refreshing materialized views

2018-08-17 Thread Jonathan S. Katz
> On Aug 17, 2018, at 9:21 AM, Tom Lane wrote: > > Dave Cramer writes: >> So it seems this patch is being ignored in this thread. > > Well, Jonathan did kind of hijack what appears to be a thread about > documentation (with an already-committed fix). I apologize if it was interpreted as

Re: docs: note ownership requirement for refreshing materialized views

2018-08-17 Thread Tom Lane
Dave Cramer writes: > So it seems this patch is being ignored in this thread. Well, Jonathan did kind of hijack what appears to be a thread about documentation (with an already-committed fix). I'd suggest reposting that patch in its own thread and adding it to the next CF.

Re: docs: note ownership requirement for refreshing materialized views

2018-08-17 Thread Dian Fay
Jonathan's patch seems like a good idea to me from a user POV, but then I just showed up the other day so I don't really have anything of substance to add. On 8/17/18 9:08 AM, Dave Cramer wrote: Dave Cramer On Thu, 16 Aug 2018 at 18:27, Jonathan S. Katz

Re: docs: note ownership requirement for refreshing materialized views

2018-08-17 Thread Dave Cramer
Dave Cramer On Thu, 16 Aug 2018 at 18:27, Jonathan S. Katz < jonathan.k...@excoventures.com> wrote: > > On Aug 16, 2018, at 1:05 AM, Jonathan S. Katz < > jonathan.k...@excoventures.com> wrote: > > > On Aug 15, 2018, at 9:15 PM, Michael Paquier wrote: > > On Wed, Aug 15, 2018 at 09:06:34PM

Re: docs: note ownership requirement for refreshing materialized views

2018-08-16 Thread Michael Paquier
On Thu, Aug 16, 2018 at 09:36:29AM -0400, Dian Fay wrote: > Fair enough! Here's a new version. Thanks, pushed. Instead of putting the new sentence in the "Notes" section, I have added it in the "Description" section, which is more consistent with other commands, like DROP MATERIALIZED VIEW, etc.

Re: docs: note ownership requirement for refreshing materialized views

2018-08-16 Thread Jonathan S. Katz
> On Aug 16, 2018, at 1:05 AM, Jonathan S. Katz > wrote: > >> >> On Aug 15, 2018, at 9:15 PM, Michael Paquier wrote: >> >> On Wed, Aug 15, 2018 at 09:06:34PM -0400, Jonathan S. Katz wrote: >>> I played around with this feature a bit and did see this was the case. >>> Also while playing

Re: docs: note ownership requirement for refreshing materialized views

2018-08-16 Thread Dian Fay
Fair enough! Here's a new version. On 8/16/18 12:07 AM, Tom Lane wrote: Dian Fay writes: I feel resorting to the infinitive asks more involvement of the reader, while leading with the responsible role(s) helps shortcut the process of determining whether what follows is relevant. Efficiency

Re: docs: note ownership requirement for refreshing materialized views

2018-08-15 Thread Jonathan S. Katz
> On Aug 15, 2018, at 9:15 PM, Michael Paquier wrote: > > On Wed, Aug 15, 2018 at 09:06:34PM -0400, Jonathan S. Katz wrote: >> I played around with this feature a bit and did see this was the case. >> Also while playing around I noticed the error message was as such: >> >> test=> REFRESH

Re: docs: note ownership requirement for refreshing materialized views

2018-08-15 Thread Tom Lane
Dian Fay writes: > I feel resorting to the infinitive asks more involvement of the reader, > while leading with the responsible role(s) helps shortcut the process of > determining whether what follows is relevant. Efficiency is always a > virtue, although this is admittedly more than a little

Re: docs: note ownership requirement for refreshing materialized views

2018-08-15 Thread Dian Fay
I feel resorting to the infinitive asks more involvement of the reader, while leading with the responsible role(s) helps shortcut the process of determining whether what follows is relevant. Efficiency is always a virtue, although this is admittedly more than a little academic for a

Re: docs: note ownership requirement for refreshing materialized views

2018-08-15 Thread Michael Paquier
On Wed, Aug 15, 2018 at 09:06:34PM -0400, Jonathan S. Katz wrote: > I played around with this feature a bit and did see this was the case. > Also while playing around I noticed the error message was as such: > > test=> REFRESH MATERIALIZED VIEW blah; > ERROR: must be owner of relation

Re: docs: note ownership requirement for refreshing materialized views

2018-08-15 Thread Jonathan S. Katz
Hi Dian, > On Aug 15, 2018, at 7:46 PM, Dian Fay wrote: > > hi all! I discovered today that the REFRESH MATERIALIZED VIEW documentation > doesn't mention that only the owner (or a superuser) may actually perform the > refresh operation. This patch adds a note to that effect. I played around

Re: docs: note ownership requirement for refreshing materialized views

2018-08-15 Thread Michael Paquier
On Wed, Aug 15, 2018 at 07:46:49PM -0400, Dian Fay wrote: > hi all! I discovered today that the REFRESH MATERIALIZED VIEW documentation > doesn't mention that only the owner (or a superuser) may actually perform > the refresh operation. This patch adds a note to that effect. I think that's a good

docs: note ownership requirement for refreshing materialized views

2018-08-15 Thread Dian Fay
hi all! I discovered today that the REFRESH MATERIALIZED VIEW documentation doesn't mention that only the owner (or a superuser) may actually perform the refresh operation. This patch adds a note to that effect. Dian Fay diff --git a/doc/src/sgml/ref/refresh_materialized_view.sgml