Re: libpqrcv_connect() leaks PGconn

2023-01-23 Thread Andres Freund
On 2023-01-21 23:14:08 -0800, Noah Misch wrote: > On Sat, Jan 21, 2023 at 12:04:53PM -0800, Andres Freund wrote: > > On 2023-01-21 08:16:42 -0800, Noah Misch wrote: > > > On Fri, Jan 20, 2023 at 06:50:37PM -0800, Andres Freund wrote: > > > > I seems we don't have any tests for creating a

Re: libpqrcv_connect() leaks PGconn

2023-01-21 Thread Noah Misch
On Sat, Jan 21, 2023 at 12:04:53PM -0800, Andres Freund wrote: > On 2023-01-21 08:16:42 -0800, Noah Misch wrote: > > On Fri, Jan 20, 2023 at 06:50:37PM -0800, Andres Freund wrote: > > > I seems we don't have any tests for creating a subscription that fails > > > during > > > connection

Re: libpqrcv_connect() leaks PGconn

2023-01-21 Thread Andres Freund
Hi, On 2023-01-21 08:16:42 -0800, Noah Misch wrote: > On Fri, Jan 20, 2023 at 06:50:37PM -0800, Andres Freund wrote: > > On 2023-01-20 17:12:37 -0800, Andres Freund wrote: > > > We have code like this in libpqrcv_connect(): > > It's bit worse than I earlier thought: We use walrv_connect() during

Re: libpqrcv_connect() leaks PGconn

2023-01-21 Thread Noah Misch
On Fri, Jan 20, 2023 at 06:50:37PM -0800, Andres Freund wrote: > On 2023-01-20 17:12:37 -0800, Andres Freund wrote: > > We have code like this in libpqrcv_connect(): > > > > conn = palloc0(sizeof(WalReceiverConn)); > > conn->streamConn = PQconnectStartParams(keys, vals, > >

Re: libpqrcv_connect() leaks PGconn

2023-01-20 Thread Andres Freund
Hi, On 2023-01-20 17:12:37 -0800, Andres Freund wrote: > We have code like this in libpqrcv_connect(): > > conn = palloc0(sizeof(WalReceiverConn)); > conn->streamConn = PQconnectStartParams(keys, vals, > >

libpqrcv_connect() leaks PGconn

2023-01-20 Thread Andres Freund
Hi, We have code like this in libpqrcv_connect(): conn = palloc0(sizeof(WalReceiverConn)); conn->streamConn = PQconnectStartParams(keys, vals, /* expand_dbname = */ true); if