Re: low wal_retrieve_retry_interval causes missed signals on Windows

2023-01-11 Thread Nathan Bossart
On Wed, Jan 11, 2023 at 04:40:14PM -0800, Andres Freund wrote: > On 2023-01-11 15:26:45 -0800, Nathan Bossart wrote: >> On Wed, Jan 11, 2023 at 12:48:36PM -0800, Andres Freund wrote: >> > Given that we check for interrupts in other parts of recovery with >> > HandleStartupProcInterrupt(), which

Re: low wal_retrieve_retry_interval causes missed signals on Windows

2023-01-11 Thread Andres Freund
Hi, On 2023-01-11 15:26:45 -0800, Nathan Bossart wrote: > On Wed, Jan 11, 2023 at 12:48:36PM -0800, Andres Freund wrote: > > Given that we check for interrupts in other parts of recovery with > > HandleStartupProcInterrupt(), which doesn't interact with latches, isn't the > > actual bug that

Re: low wal_retrieve_retry_interval causes missed signals on Windows

2023-01-11 Thread Nathan Bossart
On Wed, Jan 11, 2023 at 12:48:36PM -0800, Andres Freund wrote: > Given that we check for interrupts in other parts of recovery with > HandleStartupProcInterrupt(), which doesn't interact with latches, isn't the > actual bug that HandleStartupProcInterrupt() doesn't contain the same black > magic

Re: low wal_retrieve_retry_interval causes missed signals on Windows

2023-01-11 Thread Andres Freund
Hi, On 2023-01-10 22:11:16 -0800, Nathan Bossart wrote: > The attached patch fixes this by always calling WaitLatch(), even if > wal_retrieve_retry_interval milliseconds have already elapsed and the > timeout is 0. It doesn't seem right to call WaitLatch() just for that purpose - nor necessarily

low wal_retrieve_retry_interval causes missed signals on Windows

2023-01-10 Thread Nathan Bossart
I discussed this elsewhere [0], but I thought it deserved its own thread. After setting wal_retrieve_retry_interval to 1ms in the tests, I noticed that some of the archiving tests began consistently failing on Windows. I believe the problem is that WaitForWALToBecomeAvailable() depends on the