Re: meson vs make: missing/inconsistent ENV

2023-03-08 Thread Michael Paquier
On Wed, Mar 08, 2023 at 05:59:13PM -0800, Andres Freund wrote: > I now pushed a fix for the two obvious cases pointed out by Justin. Thanks! -- Michael signature.asc Description: PGP signature

Re: meson vs make: missing/inconsistent ENV

2023-03-08 Thread Andres Freund
Hi, On 2023-03-09 09:36:52 +0900, Michael Paquier wrote: > On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote: > > On 2023-02-26 16:52:39 -0600, Justin Pryzby wrote: > >> Also, e6927270c added ZSTD to src/bin/pg_basebackup/meson.build, but > >> it's not in ./Makefile ?? Maybe that was

Re: meson vs make: missing/inconsistent ENV

2023-03-08 Thread Michael Paquier
On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote: > On 2023-02-26 16:52:39 -0600, Justin Pryzby wrote: >> Also, e6927270c added ZSTD to src/bin/pg_basebackup/meson.build, but >> it's not in ./Makefile ?? Maybe that was for consistency with other >> places, or pre-emptive in case the

Re: meson vs make: missing/inconsistent ENV

2023-02-27 Thread Andrew Dunstan
On 2023-02-27 Mo 07:33, Andrew Dunstan wrote: On 2023-02-27 Mo 06:17, Dagfinn Ilmari Mannsåker wrote: Justin Pryzby writes: On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote: Is there any consideration of promoting these or other warnings to fatal? You mean the perl

Re: meson vs make: missing/inconsistent ENV

2023-02-27 Thread Andrew Dunstan
On 2023-02-27 Mo 06:17, Dagfinn Ilmari Mannsåker wrote: Justin Pryzby writes: On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote: Is there any consideration of promoting these or other warnings to fatal? You mean the perl warnings? Yes - it'd be nice if the warnings caused an

Re: meson vs make: missing/inconsistent ENV

2023-02-27 Thread Dagfinn Ilmari Mannsåker
Dagfinn Ilmari Mannsåker writes: > Justin Pryzby writes: > >> On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote: >>> > Is there any consideration of promoting these or other warnings to >>> > fatal? >>> >>> You mean the perl warnings? >> >> Yes - it'd be nice if the warnings caused

Re: meson vs make: missing/inconsistent ENV

2023-02-27 Thread Dagfinn Ilmari Mannsåker
Justin Pryzby writes: > On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote: >> > Is there any consideration of promoting these or other warnings to >> > fatal? >> >> You mean the perl warnings? > > Yes - it'd be nice if the warnings caused an obvious failure to allow > addressing the

Re: meson vs make: missing/inconsistent ENV

2023-02-26 Thread Justin Pryzby
On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote: > > Is there any consideration of promoting these or other warnings to > > fatal? > > You mean the perl warnings? Yes - it'd be nice if the warnings caused an obvious failure to allow addressing the issue. I noticed the icu warning

Re: meson vs make: missing/inconsistent ENV

2023-02-26 Thread Andres Freund
Hi, On 2023-02-26 16:52:39 -0600, Justin Pryzby wrote: > I noticed warnings: > Use of uninitialized value $ENV{"with_icu"} in string eq at > /home/pryzbyj/src/postgres/src/bin/pg_dump/t/002_pg_dump.pl line 56. > > and looked through: git grep ^export '*/Makefile' > > and found that: >

meson vs make: missing/inconsistent ENV

2023-02-26 Thread Justin Pryzby
I noticed warnings: Use of uninitialized value $ENV{"with_icu"} in string eq at /home/pryzbyj/src/postgres/src/bin/pg_dump/t/002_pg_dump.pl line 56. and looked through: git grep ^export '*/Makefile' and found that: src/bin/pg_dump/meson.build is missing with_icu since 396d348b0 Also, e6927270c