On Tue, Jul 11, 2023 at 5:59 PM Amit Kapila wrote:
> >
>
> I have pushed this work. But feel free to propose further
> improvements, if you have any better ideas.
>
Thanks. We have fixed the problem. So things are better than they
were. I have been busy with something else so couldn't reply.
On Thu, Jul 6, 2023 at 2:06 PM Amit Kapila wrote:
>
> On Wed, Jul 5, 2023 at 7:20 PM Ashutosh Bapat
> wrote:
> >
> > On Wed, Jul 5, 2023 at 2:29 PM Amit Kapila wrote:
> > >
> > > On Wed, Jul 5, 2023 at 2:28 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Mon, Jul 3, 2023 at 4:49 PM vignesh C
On Wed, Jul 5, 2023 at 7:20 PM Ashutosh Bapat
wrote:
>
> On Wed, Jul 5, 2023 at 2:29 PM Amit Kapila wrote:
> >
> > On Wed, Jul 5, 2023 at 2:28 PM Amit Kapila wrote:
> > >
> > > On Mon, Jul 3, 2023 at 4:49 PM vignesh C wrote:
> > > >
> > > > +1 for the first version patch, I also felt the first
On Wed, Jul 5, 2023 at 2:29 PM Amit Kapila wrote:
>
> On Wed, Jul 5, 2023 at 2:28 PM Amit Kapila wrote:
> >
> > On Mon, Jul 3, 2023 at 4:49 PM vignesh C wrote:
> > >
> > > +1 for the first version patch, I also felt the first version is
> > > easily understandable.
> > >
> >
> > Okay, please
On Wed, Jul 5, 2023 at 2:28 PM Amit Kapila wrote:
>
> On Mon, Jul 3, 2023 at 4:49 PM vignesh C wrote:
> >
> > +1 for the first version patch, I also felt the first version is
> > easily understandable.
> >
>
> Okay, please find the slightly updated version (changed a comment and
> commit
On Mon, Jul 3, 2023 at 4:49 PM vignesh C wrote:
>
> +1 for the first version patch, I also felt the first version is
> easily understandable.
>
Okay, please find the slightly updated version (changed a comment and
commit message). Unless there are more comments, I'll push this in a
day or two.
On Fri, 30 Jun 2023 at 09:55, Amit Kapila wrote:
>
> On Thu, Jun 29, 2023 at 9:40 PM vignesh C wrote:
> >
> > On Thu, 29 Jun 2023 at 09:58, Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > On Thursday, June 29, 2023 12:06 PM vignesh C wrote:
> > > >
> > >
> > > Thanks for the patches.
> > >
> > > I
On Thu, Jun 29, 2023 at 9:40 PM vignesh C wrote:
>
> On Thu, 29 Jun 2023 at 09:58, Zhijie Hou (Fujitsu)
> wrote:
> >
> > On Thursday, June 29, 2023 12:06 PM vignesh C wrote:
> > >
> >
> > Thanks for the patches.
> >
> > I tried to understand the following check:
> >
> > /*
> >
On Wed, Jun 28, 2023 at 7:26 PM Ashutosh Bapat
wrote:
>
> Hi Vignesh,
> Thanks for working on this.
>
> On Wed, Jun 28, 2023 at 4:52 PM vignesh C wrote:
> >
> > Here is a patch having the fix for the same. I have not added any
> > tests as the existing tests cover this scenario. The same issue
On Thu, 29 Jun 2023 at 09:58, Zhijie Hou (Fujitsu)
wrote:
>
> On Thursday, June 29, 2023 12:06 PM vignesh C wrote:
> >
> > On Wed, 28 Jun 2023 at 19:26, Ashutosh Bapat
> > wrote:
> > >
> > > Hi Vignesh,
> > > Thanks for working on this.
> > >
> > > On Wed, Jun 28, 2023 at 4:52 PM vignesh C
On Thursday, June 29, 2023 12:06 PM vignesh C wrote:
>
> On Wed, 28 Jun 2023 at 19:26, Ashutosh Bapat
> wrote:
> >
> > Hi Vignesh,
> > Thanks for working on this.
> >
> > On Wed, Jun 28, 2023 at 4:52 PM vignesh C wrote:
> > >
> > > Here is a patch having the fix for the same. I have not added
On Wed, 28 Jun 2023 at 19:26, Ashutosh Bapat
wrote:
>
> Hi Vignesh,
> Thanks for working on this.
>
> On Wed, Jun 28, 2023 at 4:52 PM vignesh C wrote:
> >
> > Here is a patch having the fix for the same. I have not added any
> > tests as the existing tests cover this scenario. The same issue is
Hi Vignesh,
Thanks for working on this.
On Wed, Jun 28, 2023 at 4:52 PM vignesh C wrote:
>
> Here is a patch having the fix for the same. I have not added any
> tests as the existing tests cover this scenario. The same issue is
> present in back branches too.
Interesting, we have a test for
On Mon, 26 Jun 2023 at 15:51, Amit Kapila wrote:
>
> On Mon, Jun 26, 2023 at 3:07 PM Ashutosh Bapat
> wrote:
> >
> > Hi All,
> > Every pg_decode routine except pg_decode_message that decodes a
> > transactional change, has following block
> > /* output BEGIN if we haven't yet */
> > if
On Mon, Jun 26, 2023 at 3:07 PM Ashutosh Bapat
wrote:
>
> Hi All,
> Every pg_decode routine except pg_decode_message that decodes a
> transactional change, has following block
> /* output BEGIN if we haven't yet */
> if (data->skip_empty_xacts && !txndata->xact_wrote_changes)
> {
>
Hi All,
Every pg_decode routine except pg_decode_message that decodes a
transactional change, has following block
/* output BEGIN if we haven't yet */
if (data->skip_empty_xacts && !txndata->xact_wrote_changes)
{
pg_output_begin(ctx, data, txn, false);
}
txndata->xact_wrote_changes = true;
But
16 matches
Mail list logo
