Re: pg_upgrade - a function parameter shadows global 'new_cluster'

2023-08-23 Thread Peter Smith
On Wed, Aug 23, 2023 at 6:00 PM Daniel Gustafsson wrote: > > On 23 Aug 2023, at 03:28, Peter Smith wrote: > > > PSA a small patch to remove the unnecessary parameter, and so eliminate > this shadowing. > > Agreed, applied. Thanks! > > Thanks for pushing! -- Kind Regards, Peter Smith.

Re: pg_upgrade - a function parameter shadows global 'new_cluster'

2023-08-23 Thread Daniel Gustafsson
> On 23 Aug 2023, at 03:28, Peter Smith wrote: > PSA a small patch to remove the unnecessary parameter, and so eliminate this > shadowing. Agreed, applied. Thanks! -- Daniel Gustafsson

pg_upgrade - a function parameter shadows global 'new_cluster'

2023-08-22 Thread Peter Smith
Hi hackers. During a recent review of nearby code I noticed that there was a shadowing of the 'new_cluster' global variable by a function parameter: Here: static void check_for_new_tablespace_dir(ClusterInfo *new_cluster); ~~~ It looks like it has been like this for a couple of years. I guess