Re: pgsql: Doc: Explain about Column List feature.

2022-12-23 Thread Alvaro Herrera
On 2022-Dec-21, Peter Smith wrote: > On Wed, Dec 21, 2022 at 6:59 PM Alvaro Herrera > wrote: > > > Oh, I see. It's been so long that I haven't looked at the PDFs, that I > > failed to realize that they don't use color. I agree that would be a > > problem. Maybe we can change the title to

Re: pgsql: Doc: Explain about Column List feature.

2022-12-21 Thread Peter Smith
On Wed, Dec 21, 2022 at 6:59 PM Alvaro Herrera wrote: > > On 2022-Dec-21, Peter Smith wrote: > > > By "searching" I also meant just scanning visually, although I was > > thinking more about scanning the PDF. > > > > Right now, the intention of any text box is obvious at a glance > > because of

Re: pgsql: Doc: Explain about Column List feature.

2022-12-20 Thread Alvaro Herrera
On 2022-Dec-21, Peter Smith wrote: > By "searching" I also meant just scanning visually, although I was > thinking more about scanning the PDF. > > Right now, the intention of any text box is obvious at a glance > because of those titles like "Caution", "Tip", "Note", "Warning". > Sure, the HTML

Re: pgsql: Doc: Explain about Column List feature.

2022-12-20 Thread Peter Smith
On Tue, Dec 20, 2022 at 7:21 PM Alvaro Herrera wrote: > > On 2022-Dec-20, Peter Smith wrote: > > > If you change this warning title then it becomes the odd one out - > > every other warning in all the pg docs just says "Warning". IMO > > maintaining consistency throughout is best. e.g. I can

Re: pgsql: Doc: Explain about Column List feature.

2022-12-20 Thread Alvaro Herrera
On 2022-Dec-20, Amit Kapila wrote: > + > +Combining Column Lists from Multiple Subscriptions > > Shouldn't the title be "Combining Column Lists from Multiple > Publications"? We can define column lists while defining publications > so the proposed title doesn't seem to be conveying the

Re: pgsql: Doc: Explain about Column List feature.

2022-12-20 Thread Alvaro Herrera
On 2022-Dec-20, Peter Smith wrote: > If you change this warning title then it becomes the odd one out - > every other warning in all the pg docs just says "Warning". IMO > maintaining consistency throughout is best. e.g. I can imagine maybe > someone searching for "Warning" in the docs, and now

Re: pgsql: Doc: Explain about Column List feature.

2022-12-19 Thread Peter Smith
On Tue, Dec 20, 2022 at 3:47 AM Alvaro Herrera wrote: > > On 2022-Sep-15, Alvaro Herrera wrote: > > > On 2022-Sep-15, Alvaro Herrera wrote: > > > > > Looking at the rendered docs again, I notice that section "31.4.5. > > > Combining Multiple Column Lists" is *only* the red-tinted Warning block. >

Re: pgsql: Doc: Explain about Column List feature.

2022-12-19 Thread Amit Kapila
On Mon, Dec 19, 2022 at 10:17 PM Alvaro Herrera wrote: > > On 2022-Sep-15, Alvaro Herrera wrote: > > > On 2022-Sep-15, Alvaro Herrera wrote: > > > > > Looking at the rendered docs again, I notice that section "31.4.5. > > > Combining Multiple Column Lists" is *only* the red-tinted Warning block.

Re: pgsql: Doc: Explain about Column List feature.

2022-09-15 Thread Alvaro Herrera
On 2022-Sep-15, Alvaro Herrera wrote: > Looking at the rendered docs again, I notice that section "31.4.5. > Combining Multiple Column Lists" is *only* the red-tinted Warning block. > That seems quite odd. I am tempted to remove the sect2 heading for that > one too. Pushed. I didn't modify

Re: pgsql: Doc: Explain about Column List feature.

2022-09-15 Thread Alvaro Herrera
On 2022-Sep-14, Peter Smith wrote: > On Tue, Sep 13, 2022 at 10:11 PM Alvaro Herrera > wrote: > > On 2022-Sep-07, Amit Kapila wrote: > > One more thing. There's a sect2 about combining column list. Part of it > > seems pretty judgmental and I see no reason to have it in there; I > > propose

Re: pgsql: Doc: Explain about Column List feature.

2022-09-14 Thread Peter Smith
On Wed, Sep 14, 2022 at 7:40 PM Alvaro Herrera wrote: > > On 2022-Sep-14, Peter Smith wrote: > > > PSA a new patch for the "Column Lists" page. AFAIK this is the same as > > everything that you suggested > > I don't get it. You send me my patch back, and claim it is a new patch? > > I kindly

Re: pgsql: Doc: Explain about Column List feature.

2022-09-14 Thread Alvaro Herrera
On 2022-Sep-14, Peter Smith wrote: > PSA a new patch for the "Column Lists" page. AFAIK this is the same as > everything that you suggested I don't get it. You send me my patch back, and claim it is a new patch? I kindly request that when you review a patch, you do not hijack the submitter's

Re: pgsql: Doc: Explain about Column List feature.

2022-09-13 Thread Peter Smith
On Tue, Sep 13, 2022 at 10:11 PM Alvaro Herrera wrote: > > On 2022-Sep-07, Amit Kapila wrote: > > > Doc: Explain about Column List feature. > > > > Add a new logical replication section for "Column Lists" (analogous to the > > Row Filters page). This explains how the feature can be used and the >

Re: pgsql: Doc: Explain about Column List feature.

2022-09-13 Thread Alvaro Herrera
On 2022-Sep-07, Amit Kapila wrote: > Doc: Explain about Column List feature. > > Add a new logical replication section for "Column Lists" (analogous to the > Row Filters page). This explains how the feature can be used and the > caveats in it. > > Author: Peter Smith > Reviewed-by: Shi yu,