Re: pgsql: Harden new test case against force_parallel_mode = regress.

2023-03-03 Thread Tom Lane
Robert Haas writes: > On Fri, Mar 3, 2023 at 12:46 PM Tom Lane wrote: >> Couldn't we install the leader's snapshot into both transactions? > Yeah, maybe that would Just Work. Not sure. Well, IIUC the worker is currently getting a brand new snapshot for its startup transaction, which is exactly

Re: pgsql: Harden new test case against force_parallel_mode = regress.

2023-03-03 Thread Robert Haas
On Fri, Mar 3, 2023 at 12:46 PM Tom Lane wrote: > Couldn't we install the leader's snapshot into both transactions? Yeah, maybe that would Just Work. Not sure. -- Robert Haas EDB: http://www.enterprisedb.com

Re: pgsql: Harden new test case against force_parallel_mode = regress.

2023-03-03 Thread Tom Lane
Robert Haas writes: > On Fri, Mar 3, 2023 at 11:37 AM Tom Lane wrote: >> +ERROR: role "regress_psql_user" does not exist >> +CONTEXT: while setting parameter "session_authorization" to >> "regress_psql_user" > Oh, that's interesting (and sad). A parallel worker has a "startup > transaction"

Re: pgsql: Harden new test case against force_parallel_mode = regress.

2023-03-03 Thread Robert Haas
On Fri, Mar 3, 2023 at 11:37 AM Tom Lane wrote: > The workers were failing at startup, eg (from [1]): > > +ERROR: role "regress_psql_user" does not exist > +CONTEXT: while setting parameter "session_authorization" to > "regress_psql_user" > > Maybe this says that worker startup needs to

Re: pgsql: Harden new test case against force_parallel_mode = regress.

2023-03-03 Thread Tom Lane
I wrote: > The workers were failing at startup, eg (from [1]): argh, forgot to add the link: [1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hippopotamus=2023-03-02%2022%3A31%3A17 regards, tom lane

Re: pgsql: Harden new test case against force_parallel_mode = regress.

2023-03-03 Thread Matthias van de Meent
On Fri, 3 Mar 2023 at 17:16, Robert Haas wrote: > > On Thu, Mar 2, 2023 at 5:47 PM Tom Lane wrote: > > Harden new test case against force_parallel_mode = regress. > > > > Per buildfarm: worker processes can't see a role created in > > the current transaction. > > Now why would that happen?

Re: pgsql: Harden new test case against force_parallel_mode = regress.

2023-03-03 Thread Tom Lane
Robert Haas writes: > On Thu, Mar 2, 2023 at 5:47 PM Tom Lane wrote: >> Per buildfarm: worker processes can't see a role created in >> the current transaction. > Now why would that happen? Surely the snapshot for each command is > passed down from leader to worker, and the worker is not free to

Re: pgsql: Harden new test case against force_parallel_mode = regress.

2023-03-03 Thread Robert Haas
On Thu, Mar 2, 2023 at 5:47 PM Tom Lane wrote: > Harden new test case against force_parallel_mode = regress. > > Per buildfarm: worker processes can't see a role created in > the current transaction. Now why would that happen? Surely the snapshot for each command is passed down from leader to