Re: pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants.

2023-02-23 Thread Justin Pryzby
On Fri, Feb 24, 2023 at 01:56:05PM +1300, Thomas Munro wrote: > On Fri, Feb 24, 2023 at 1:20 PM Justin Pryzby wrote: > > These patches cause warnings under MSVC. > > > > Of course my patch to improve CI by warning about compiler warnings is > > the only one to notice. > > > >

Re: pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants.

2023-02-23 Thread Thomas Munro
On Fri, Feb 24, 2023 at 1:20 PM Justin Pryzby wrote: > These patches cause warnings under MSVC. > > Of course my patch to improve CI by warning about compiler warnings is > the only one to notice. > > https://cirrus-ci.com/task/6199582053367808 It's a shame that it fails the whole Windows task,

Re: pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants.

2023-02-23 Thread Justin Pryzby
These patches cause warnings under MSVC. Of course my patch to improve CI by warning about compiler warnings is the only one to notice. https://cirrus-ci.com/task/6199582053367808 -- Justin