> On 1 Sep 2021, at 13:15, Daniel Gustafsson wrote:
>
>> On 31 May 2021, at 18:51, Emre Hasegeli wrote:
>>
>>> Please add this patch to the commitfest so that it's not forgotten. It
>>> will be considered as a new feature so will be considered for commit
>>> after the next commitfest.
>>
>> I
> On 31 May 2021, at 18:51, Emre Hasegeli wrote:
>
>> Please add this patch to the commitfest so that it's not forgotten. It
>> will be considered as a new feature so will be considered for commit
>> after the next commitfest.
>
> I did [1].
The patch no longer applies to HEAD, can you please
Cary Huang writes:
> I also agree with Ashutosh that the "IS NOT TRUE" case can be simplified to
> just "IS FALSE". it's simpler to understand.
Uh ... surely that's just wrong?
regression=# select null is not true;
?column?
--
t
(1 row)
regression=# select null is false;
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
Hello
I tried to apply the patch to master branch and got a
Le lundi 31 mai 2021, 18:51:57 CEST Emre Hasegeli a écrit :
> > Please add this patch to the commitfest so that it's not forgotten. It
> > will be considered as a new feature so will be considered for commit
> > after the next commitfest.
>
> I did [1]. You can add yourself as a reviewer.
>
> >
> Please add this patch to the commitfest so that it's not forgotten. It
> will be considered as a new feature so will be considered for commit
> after the next commitfest.
I did [1]. You can add yourself as a reviewer.
> I don't understand why we need to complicate the expressions when
>
Hi Emre,
This looks like a good improvement.
Please add this patch to the commitfest so that it's not forgotten. It
will be considered as a new feature so will be considered for commit
after the next commitfest.
Mean time here are some comments.
+/*
+ * Deparse IS [NOT] TRUE/FALSE/UNKNOWN
The comparison predicates IS [NOT] TRUE/FALSE/UNKNOWN were not
recognised by postgres_fdw, so they were not pushed down to the remote
server. The attached patch adds support for them.
I am adding this to the commitfest 2021-07.
0001-postgres_fdw-Handle-boolean-comparison-predicates.patch
