Re: [EXTERNAL] Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-18 Thread Maciek Sakrejda
On Fri, Dec 10, 2021 at 10:10 AM Godfrin, Philippe E wrote: > I may have missed something in this stream, but is this a system controlled > by Patroni? In my case, no: it's a pretty vanilla PGDG install on Ubuntu 20.04. Thanks for the context, though. Thanks, Maciek

Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-18 Thread Maciek Sakrejda
On Thu, Dec 9, 2021 at 7:42 AM Bharath Rupireddy wrote: > How about ALTER SYSTEM SET shared_preload_libraries command itself > checking for availability of the specified libraries (after fetching > library names from the parsed string value) with stat() and then > report an error if any of the

Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-13 Thread Robert Haas
On Thu, Dec 9, 2021 at 2:32 AM Maciek Sakrejda wrote: > > Considering the vanishingly small number of actual complaints we've > > seen about this, that sounds ridiculously over-engineered. > > A documentation example should be sufficient. > > I don't know if this will tip the scales, but I'd like

RE: [EXTERNAL] Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-10 Thread Godfrin, Philippe E
On Wed, Dec 1, 2021 at 5:15 AM Tom Lane wrote: > > Justin Pryzby writes: > > +1 to document it, but it seems like the worse problem is allowing > > +the admin to > > write a configuration which causes the server to fail to start, > > without having issued a warning. > > > I think you could

Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-09 Thread Bharath Rupireddy
On Thu, Dec 9, 2021 at 1:02 PM Maciek Sakrejda wrote: > > On Wed, Dec 1, 2021 at 5:15 AM Tom Lane wrote: > > > > Justin Pryzby writes: > > > +1 to document it, but it seems like the worse problem is allowing the > > > admin to > > > write a configuration which causes the server to fail to

Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-08 Thread Maciek Sakrejda
On Wed, Dec 1, 2021 at 5:15 AM Tom Lane wrote: > > Justin Pryzby writes: > > +1 to document it, but it seems like the worse problem is allowing the > > admin to > > write a configuration which causes the server to fail to start, without > > having > > issued a warning. > > > I think you could

Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-07 Thread Bharath Rupireddy
On Mon, Dec 6, 2021 at 9:20 PM Bharath Rupireddy wrote: > > On Fri, Dec 3, 2021 at 11:25 PM Bossart, Nathan wrote: > > > > On 12/3/21, 6:21 AM, "Bharath Rupireddy" > > wrote: > > > +1 to add here in the "Parameter Names and Values section", but do we > > > want to backlink every string

Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-06 Thread Tom Lane
Bharath Rupireddy writes: > Am I missing something here? Or is there a distinction between parsing > of postgresql.conf and ALTER SYSTEM SET command for GUC_LIST_QUOTE > values? If so, what is it? One context is SQL, the other is not. The quoting rules are really quite different.

Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-06 Thread Bharath Rupireddy
On Fri, Dec 3, 2021 at 11:25 PM Bossart, Nathan wrote: > > On 12/3/21, 6:21 AM, "Bharath Rupireddy" > wrote: > > +1 to add here in the "Parameter Names and Values section", but do we > > want to backlink every string parameter to this section? I think it > > needs more effort. IMO, we can just

Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-03 Thread Bossart, Nathan
On 12/3/21, 6:21 AM, "Bharath Rupireddy" wrote: > +1 to add here in the "Parameter Names and Values section", but do we > want to backlink every string parameter to this section? I think it > needs more effort. IMO, we can just backlink for > shared_preload_libraries alone. Thoughts? IMO this

Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-03 Thread Bharath Rupireddy
On Fri, Dec 3, 2021 at 6:33 AM Michael Paquier wrote: > > On Fri, Dec 03, 2021 at 12:45:56AM +, Bossart, Nathan wrote: > > I think the problems you noted upthread are shared for all GUCs with > > type GUC_LIST_QUOTE (e.g., search_path, temp_tablespaces). Perhaps > > the documentation for

Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-02 Thread Michael Paquier
On Fri, Dec 03, 2021 at 12:45:56AM +, Bossart, Nathan wrote: > I think the problems you noted upthread are shared for all GUCs with > type GUC_LIST_QUOTE (e.g., search_path, temp_tablespaces). Perhaps > the documentation for each of these GUCs should contain a short blurb > about how to

Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-02 Thread Bossart, Nathan
On 12/1/21, 5:59 AM, "Bharath Rupireddy" wrote: > On Wed, Dec 1, 2021 at 6:45 PM Tom Lane wrote: >> Considering the vanishingly small number of actual complaints we've >> seen about this, that sounds ridiculously over-engineered. >> A documentation example should be sufficient. > > Thanks.

Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-01 Thread Bharath Rupireddy
On Wed, Dec 1, 2021 at 6:45 PM Tom Lane wrote: > > Justin Pryzby writes: > > +1 to document it, but it seems like the worse problem is allowing the > > admin to > > write a configuration which causes the server to fail to start, without > > having > > issued a warning. > > > I think you could

Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-01 Thread Tom Lane
Justin Pryzby writes: > +1 to document it, but it seems like the worse problem is allowing the admin > to > write a configuration which causes the server to fail to start, without having > issued a warning. > I think you could fix that with a GUC check hook to emit a warning. > I'm not sure

Re: should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-01 Thread Justin Pryzby
On Wed, Dec 01, 2021 at 04:20:52PM +0530, Bharath Rupireddy wrote: > It seems like users can try different ways to set multiple values for > shared_preload_libraries GUC even after reading the documentation > [1]), something like: ... > ALTER SYSTEM SET shared_preload_libraries = >

should we document an example to set multiple libraries in shared_preload_libraries?

2021-12-01 Thread Bharath Rupireddy
Hi, It seems like users can try different ways to set multiple values for shared_preload_libraries GUC even after reading the documentation [1]), something like: ALTER SYSTEM SET shared_preload_libraries TO auth_delay,pg_stat_statements,sepgsql; --> correct ALTER SYSTEM SET