Re: straightening out backend process startup

2021-09-13 Thread Andres Freund
Hi, On September 13, 2021 9:56:52 PM PDT, Kyotaro Horiguchi wrote: >At Mon, 13 Sep 2021 20:11:29 -0700, Andres Freund wrote >in >> Hi, >> >> On 2021-08-05 12:50:15 -0700, Andres Freund wrote: >> > On 2021-08-03 16:50:24 +0900, Kyotaro Horiguchi wrote: >> > > > - My first attempt at

Re: straightening out backend process startup

2021-09-13 Thread Kyotaro Horiguchi
At Mon, 13 Sep 2021 20:11:29 -0700, Andres Freund wrote in > Hi, > > On 2021-08-05 12:50:15 -0700, Andres Freund wrote: > > On 2021-08-03 16:50:24 +0900, Kyotaro Horiguchi wrote: > > > > - My first attempt at PostgresMainSingle() separated the single/multi > > > > user > > > > cases a bit

Re: straightening out backend process startup

2021-09-13 Thread Andres Freund
Hi, On 2021-08-05 12:50:15 -0700, Andres Freund wrote: > On 2021-08-03 16:50:24 +0900, Kyotaro Horiguchi wrote: > > > - My first attempt at PostgresMainSingle() separated the single/multi user > > > cases a bit more than the code right now, by having a > > > PostgresMainCommon() > > > which

Re: straightening out backend process startup

2021-08-05 Thread Andres Freund
Hi, On 2021-08-03 16:50:24 +0900, Kyotaro Horiguchi wrote: > At Mon, 2 Aug 2021 09:41:24 -0700, Andres Freund wrote in > > - PostgresMainSingle() should probably not be in postgres.c. We could put it > > into postinit.c or ..? > > PostgresMainSingle() looks like the single-process version of >

Re: straightening out backend process startup

2021-08-05 Thread Andres Freund
Hi, Thanks Robert, Horiguchi-san for looking. On 2021-08-04 16:34:52 -0400, Robert Haas wrote: > On Mon, Aug 2, 2021 at 12:41 PM Andres Freund wrote: > > - AuxiliaryProcessMain() is used for two independent tasks: Start bootstrap > > / > > checker mode and starting auxiliary processes. In

Re: straightening out backend process startup

2021-08-04 Thread Robert Haas
On Mon, Aug 2, 2021 at 12:41 PM Andres Freund wrote: > - AuxiliaryProcessMain() is used for two independent tasks: Start bootstrap / > checker mode and starting auxiliary processes. In HEAD there's maybe 5 lines > out 250 that are actually common to both uses. > > A related oddity is that

Re: straightening out backend process startup

2021-08-03 Thread Kyotaro Horiguchi
At Mon, 2 Aug 2021 09:41:24 -0700, Andres Freund wrote in > Hi, > > I've previously complained ([1]) that process initialization has gotten > very complicated. I hit this once more last week when trying to commit > one of the shared memory stats pieces... > > I think there's quite a few

Re: straightening out backend process startup

2021-08-02 Thread Andres Freund
Hi, On 2021-08-02 12:57:36 -0400, Tom Lane wrote: > Andres Freund writes: > > I think there's quite a few different issues around this - here I'm just > > trying to tackle a few of the most glaring (to me): > > No opinion yet about most of this, but I did want to react to > > > In fact, I

Re: straightening out backend process startup

2021-08-02 Thread Tom Lane
Andres Freund writes: > I think there's quite a few different issues around this - here I'm just > trying to tackle a few of the most glaring (to me): No opinion yet about most of this, but I did want to react to > In fact, I think there's a good argument to be made that we should > entirely

straightening out backend process startup

2021-08-02 Thread Andres Freund
Hi, I've previously complained ([1]) that process initialization has gotten very complicated. I hit this once more last week when trying to commit one of the shared memory stats pieces... I think there's quite a few different issues around this - here I'm just trying to tackle a few of the most