Re: subscription disable_on_error not working after ALTER SUBSCRIPTION set bad conninfo

2024-01-29 Thread Peter Smith
On Fri, Jan 19, 2024 at 7:21 PM Masahiko Sawada wrote: > > On Thu, Jan 18, 2024 at 6:54 PM Amit Kapila wrote: > > > > On Thu, Jan 18, 2024 at 11:15 AM Peter Smith wrote: > > > > > > On Thu, Jan 18, 2024 at 12:55 PM Masahiko Sawada > > > wrote: > > > > > > > ... > > > > > > > > Although we can

Re: subscription disable_on_error not working after ALTER SUBSCRIPTION set bad conninfo

2024-01-19 Thread Masahiko Sawada
On Thu, Jan 18, 2024 at 6:54 PM Amit Kapila wrote: > > On Thu, Jan 18, 2024 at 11:15 AM Peter Smith wrote: > > > > On Thu, Jan 18, 2024 at 12:55 PM Masahiko Sawada > > wrote: > > > > > ... > > > > > > Although we can improve it to handle this case too, I'm not sure it's > > > a bug. The doc

Re: subscription disable_on_error not working after ALTER SUBSCRIPTION set bad conninfo

2024-01-18 Thread Peter Smith
On Thu, Jan 18, 2024 at 8:54 PM Amit Kapila wrote: > > On Thu, Jan 18, 2024 at 11:15 AM Peter Smith wrote: > > > > On Thu, Jan 18, 2024 at 12:55 PM Masahiko Sawada > > wrote: > > > > > ... > > > > > > Although we can improve it to handle this case too, I'm not sure it's > > > a bug. The doc

Re: subscription disable_on_error not working after ALTER SUBSCRIPTION set bad conninfo

2024-01-18 Thread Amit Kapila
On Thu, Jan 18, 2024 at 11:15 AM Peter Smith wrote: > > On Thu, Jan 18, 2024 at 12:55 PM Masahiko Sawada > wrote: > > > ... > > > > Although we can improve it to handle this case too, I'm not sure it's > > a bug. The doc says[1]: > > > > Specifies whether the subscription should be

Re: subscription disable_on_error not working after ALTER SUBSCRIPTION set bad conninfo

2024-01-17 Thread Peter Smith
On Thu, Jan 18, 2024 at 12:55 PM Masahiko Sawada wrote: > ... > > Although we can improve it to handle this case too, I'm not sure it's > a bug. The doc says[1]: > > Specifies whether the subscription should be automatically disabled if > any errors are detected by subscription workers during

Re: subscription disable_on_error not working after ALTER SUBSCRIPTION set bad conninfo

2024-01-17 Thread Masahiko Sawada
On Thu, Jan 18, 2024 at 8:16 AM Peter Smith wrote: > > Hi, > > I had reported a possible subscription 'disable_on_error' bug found > while reviewing another patch. > > I am including my initial report and Nisha's analysis again here so > that this topic has its own thread. > > ==

subscription disable_on_error not working after ALTER SUBSCRIPTION set bad conninfo

2024-01-17 Thread Peter Smith
Hi, I had reported a possible subscription 'disable_on_error' bug found while reviewing another patch. I am including my initial report and Nisha's analysis again here so that this topic has its own thread. == INITIAL REPORT [1] == ... I see now that any ALTER