On Thu, 2023-07-06 at 11:41 +0900, Michael Paquier wrote:
> Why is the addition of --encoding necessary for test_extensions? Its
> Makefile has a NO_LOCALE, but it has no ENCODING set.
I think that was an oversight -- as you point out, the Makefile doesn't
set ENCODING, so the meson.build does
On Sat, Jun 17, 2023 at 07:40:18AM -0700, Gurjeet Singh wrote:
> So attached is updated patch that makes the order consistent across
> all 3 occurrences.
There is no need to update unaccent since 44e73a4.
--- a/src/test/modules/test_extensions/meson.build
+++
On Fri, Jun 16, 2023 at 1:56 PM Tristan Partin wrote:
>
> On Fri Jun 16, 2023 at 3:29 PM CDT, Jeff Davis wrote:
> > Patch attached. Currently, the Makefile specifies NO_LOCALE=1, and the
> > meson.build does not.
>
> Looks alright to me, but it might be nicer to change the order of
> arguments to
On Fri Jun 16, 2023 at 3:29 PM CDT, Jeff Davis wrote:
> Patch attached. Currently, the Makefile specifies NO_LOCALE=1, and the
> meson.build does not.
Looks alright to me, but it might be nicer to change the order of
arguments to match contrib/unaccent/meson.build:40. Might help with
grepping in
Patch attached. Currently, the Makefile specifies NO_LOCALE=1, and the
meson.build does not.
--
Jeff Davis
PostgreSQL Contributor Team - AWS
From 1775c98badb94a2ee185d7a6bd11482a4e5db58a Mon Sep 17 00:00:00 2001
From: Jeff Davis
Date: Fri, 16 Jun 2023 11:51:00 -0700
Subject: [PATCH v1]
