On Fri, 3 May 2024 at 00:00, Alexander Lakhin wrote:
> (some of them are located in doc/, so it's not a code-only change)
> I've attached the patch for your convenience, though maybe some
> of the suggestions are to be discarded.
Thanks. I was hoping you'd do that.
I pushed the patch after only
Hello,
28.04.2024 11:05, David Rowley wrote:
On Sat, 20 Apr 2024 at 16:09, David Rowley wrote:
Here are a few more to see if it motivates anyone else to do a more
thorough search for another batch.
I've pushed these now.
Please look also at the list of other typos and inconsistencies I've
On Sat, 20 Apr 2024 at 16:09, David Rowley wrote:
> Here are a few more to see if it motivates anyone else to do a more
> thorough search for another batch.
I've pushed these now.
David
On Fri, 19 Apr 2024 at 20:13, Daniel Gustafsson wrote:
> Thanks, I incorporated these into 0001 before pushing. All the commits in
> this
> patchset are now applied.
Here are a few more to see if it motivates anyone else to do a more
thorough search for another batch.
Fixes duplicate words
> On 16 Apr 2024, at 15:37, Nazir Bilal Yavuz wrote:
> I realized two small typos: 'sgmr' -> 'smgr'. You may want to include
> them in 0001.
Thanks, I incorporated these into 0001 before pushing. All the commits in this
patchset are now applied.
--
Daniel Gustafsson
ese together.
> >
> > Here are a few additional ones to add to that.
>
> Thanks. Collecting all the ones submitted here, as well as a few submitted
> off-list by Alexander, the patch is now a 3-part patchset of cleanups:
>
> 0001 contains the typos and duplicate
On Mon, Apr 15, 2024 at 8:26 PM Daniel Gustafsson wrote:
> Thanks. Collecting all the ones submitted here, as well as a few submitted
> off-list by Alexander, the patch is now a 3-part patchset of cleanups:
>
> 0001 contains the typos and duplicate words fixups, 0002 fixes
w submitted
off-list by Alexander, the patch is now a 3-part patchset of cleanups:
0001 contains the typos and duplicate words fixups, 0002 fixes a parameter with
the wrong name in the prototype and 0003 removes a leftover prototype which was
accidentally left in a refactoring.
--
Daniel Gustafsson
On Sat, 13 Apr 2024 at 09:17, Daniel Gustafsson wrote:
>
> > On 12 Apr 2024, at 23:15, Heikki Linnakangas wrote:
> > Here's a few more. I've accumulate these over the past couple of months,
> > keeping them stashed in a branch, adding to it whenever I've spotted a
> > minor typo while reading
> On 12 Apr 2024, at 23:15, Heikki Linnakangas wrote:
>
> On 11/04/2024 16:05, Daniel Gustafsson wrote:
>> Now that the tree has settled down a bit post-freeze I ran some tooling to
>> check spelling. I was primarily interested in docs and README* which were
>> mo
On 11/04/2024 16:05, Daniel Gustafsson wrote:
Now that the tree has settled down a bit post-freeze I ran some tooling to
check spelling. I was primarily interested in docs and README* which were
mostly free from simply typos, while the code had some in various comments and
one in code
gt; Now that the tree has settled down a bit post-freeze I ran some
> > tooling
> > to
> > check spelling. I was primarily interested in docs and README*
> > which
> > were
> > mostly free from simply typos, while the code
some
> tooling
> to
> check spelling. I was primarily interested in docs and README* which
> were
> mostly free from simply typos, while the code had some in various
> comments and
> one in code. The attached fixes all that I came across (not
>
in docs and README* which were
>> mostly free from simply typos, while the code had some in various comments
>> and
>> one in code. The attached fixes all that I came across (not cross-referenced
>> against ongoing reverts or any other fixup threads but will be before push
On Fri, 12 Apr 2024, 1:05 am Daniel Gustafsson, wrote:
> Now that the tree has settled down a bit post-freeze I ran some tooling to
> check spelling. I was primarily interested in docs and README* which were
> mostly free from simply typos, while the code had some in various
On 2024-04-11 Th 09:05, Daniel Gustafsson wrote:
Now that the tree has settled down a bit post-freeze I ran some tooling to
check spelling. I was primarily interested in docs and README* which were
mostly free from simply typos, while the code had some in various comments and
one in code
Now that the tree has settled down a bit post-freeze I ran some tooling to
check spelling. I was primarily interested in docs and README* which were
mostly free from simply typos, while the code had some in various comments and
one in code. The attached fixes all that I came across (not cross
At Thu, 14 Mar 2024 11:23:38 +0530, Amit Kapila wrote
in
> On Thu, Mar 14, 2024 at 9:58 AM Kyotaro Horiguchi
> wrote:
> >
> > While examining reorderbuffer.c, I found several typos. I'm not sure
> > if fixing them is worthwhile, but I've attached a fix just in case.
On Thu, Mar 14, 2024 at 9:58 AM Kyotaro Horiguchi
wrote:
>
> While examining reorderbuffer.c, I found several typos. I'm not sure
> if fixing them is worthwhile, but I've attached a fix just in case.
>
LGTM. I'll push this in some time.
--
With Regards,
Amit Kapila.
Hello.
While examining reorderbuffer.c, I found several typos. I'm not sure
if fixing them is worthwhile, but I've attached a fix just in case.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication
On Sun, Jan 21, 2024 at 08:22:01PM +0800, Yongtao Huang wrote:
> As the title said, just fix some typos.
Thanks, applied.
--
Michael
signature.asc
Description: PGP signature
Hi all,
As the title said, just fix some typos.
Regards
Yongtao Huang
0001-Fix-some-typos.patch
Description: Binary data
On Tue, May 02, 2023 at 12:26:31PM +0900, Michael Paquier wrote:
> On Fri, Apr 21, 2023 at 12:00:00PM +0300, Alexander Lakhin wrote:
>> 4. CommitTSBuffer -> CommitTsBuffer // the inconsistency exists since
>> 5da14938f; maybe this change should be backpatched
>
> Yes, we'd better backpatch that.
On Fri, Apr 21, 2023 at 12:00:00PM +0300, Alexander Lakhin wrote:
> Please look at the following two bunches for v14+ and v13+ (split to ease
> back-patching if needed). Having processed them, I've reached the state that
> could be considered "clean" ([2], [3]); at least I don't see how to detect
Hi David,
21.04.2023 01:49, David Rowley wrote:
On Wed, 19 Apr 2023 at 07:00, Alexander Lakhin wrote:
please look at the similar list for v15+ (596b5af1d..HEAD).
I've now pushed most of these but didn't include the following ones:
Thank you!
3. BufFileOpenShared -> BufFileOpenFileSet //
On Wed, 19 Apr 2023 at 07:00, Alexander Lakhin wrote:
> please look at the similar list for v15+ (596b5af1d..HEAD).
I've now pushed most of these but didn't include the following ones:
> 3. BufFileOpenShared -> BufFileOpenFileSet // see dcac5e7ac
Maybe I need to spend longer, but I just didn't
Justin Pryzby writes:
> On Tue, Apr 18, 2023 at 02:06:43PM +1200, David Rowley wrote:
>> On Tue, 18 Apr 2023 at 10:10, Justin Pryzby wrote:
>>> and s/evade/avoid/
>> I didn't touch this. You'll need to provide more justification for why
>> you think it's more correct than what's there.
> I'd
continue presenting my findings the same way.
...
You missed "boostrap" :)
Yes, that's because "boostrap" was not unique, but my semi-automatic approach
is based on `uniq -u`, so I'm sure that there are typos that can't be found
this way.
But hadn't yet convinced myself
On Tue, Apr 18, 2023 at 02:06:43PM +1200, David Rowley wrote:
> On Tue, 18 Apr 2023 at 10:10, Justin Pryzby wrote:
> > > - * USER SET values are appliciable only for PGC_USERSET
> > > parameters. We
> > > + * USER SET values are applicable only for PGC_USERSET
> > >
David Rowley writes:
> On Tue, 18 Apr 2023 at 06:00, Alexander Lakhin wrote:
>> Also, maybe OID_MAX should be removed from src/include/postgres_ext.h as
>> it's unused since eb8312a22.
> I didn't touch this. It seems like it could be useful for extensions
> and client apps even if it's not
On Tue, 18 Apr 2023 at 10:10, Justin Pryzby wrote:
> > - * USER SET values are appliciable only for PGC_USERSET
> > parameters. We
> > + * USER SET values are applicable only for PGC_USERSET
> > parameters. We
> >* use InvalidOid as role in order to
On Tue, 18 Apr 2023 at 06:00, Alexander Lakhin wrote:
> Please consider fixing the following unique words/identifiers introduced in
> v16:
Thanks, I've pushed all of these apart from the following 2.
> 45. tar_set_error -- remove (obsolete since ebfb814f7)
> 46. test_tranche_name -- remove
/evade/avoid/
> +++ b/src/bin/pg_dump/pg_dumpall.c
You missed "boostrap" :)
I independently found 11 of the same typos you did:
> 1. addresess -> addresses
> 3. appeneded -> appended
> 4. appliciable -> applicable
> 8. containsthe -> contains the
> 15. e
Hello hackers,
Please consider fixing the following unique words/identifiers introduced in v16:
1. addresess -> addresses
2. adminstrator -> administrator // the same typo found in src/backend/po/id.po, but perhaps it should be fixed via
pgsql-translators
3. appeneded -> appended
4.
Michael Paquier writes:
> On Wed, Feb 08, 2023 at 09:56:44AM -0600, Justin Pryzby wrote:
>> Some more accumulated/new typos.
> 0005 can indeed fix a lot of confusion around the spaces after an
> "else if" block. Is that something that could be automated with the
>
On Wed, Feb 08, 2023 at 09:56:44AM -0600, Justin Pryzby wrote:
> Some more accumulated/new typos.
0001 has been a debate for a long time, and it depends on the way SQL
is spelled. For reference:
$ git grep -i " an sql" -- *.c | wc -l
63
$ git grep -i " a sql" -- *.c | wc
Some more accumulated/new typos.
>From 6c79a0d4e0251dbbac38babb60bb2d0fbae3da8d Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Wed, 11 Jan 2023 12:52:25 -0600
Subject: [PATCH 01/10] use "an SQL" rather than a SQL
Per 04539e
---
doc/src/sgml/ecpg.sgml | 6 +++---
1 file changed,
On Tue, Jan 10, 2023 at 01:55:56PM +0530, Amit Kapila wrote:
> I have not yet started, so please go ahead.
Okay, I have looked at that and fixed the whole new things, including
the typo you have introduced. 0001~0004 have been left out, as of the
same reasons as upthread.
--
Michael
On Tue, Jan 10, 2023 at 1:18 PM Michael Paquier wrote:
>
> On Tue, Jan 10, 2023 at 12:24:40PM +0530, Amit Kapila wrote:
> > Thanks for noticing this. I'll take care of this and some other typo
> > patches together.
>
> Does this include 0010? I was just looking at the whole set and this
> one
On Tue, Jan 10, 2023 at 12:24:40PM +0530, Amit Kapila wrote:
> Thanks for noticing this. I'll take care of this and some other typo
> patches together.
Does this include 0010? I was just looking at the whole set and this
one looked like a cleanup worth on its own so I was going to handle
it,
On Tue, Jan 10, 2023 at 10:27 AM Justin Pryzby wrote:
>
> On Tue, Jan 03, 2023 at 03:39:22PM -0600, Justin Pryzby wrote:
> > On Tue, Jan 03, 2023 at 04:28:29PM +0900, Michael Paquier wrote:
> > > On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote:
> > >
> > > # Use larger ccache
rkup.
>
> I changed it for consistency, as it's the only thing that says <>UTF-8<>
> anywhere, and charset.sgml already says <>UTF<>-8 elsewhere.
>
> Alternately, I suggest to change charset to say <>UTF8<> in both places.
As attached.
This also fixes &qu
On Tue, Jan 03, 2023 at 04:28:29PM +0900, Michael Paquier wrote:
> On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote:
>
> # Use larger ccache cache, as this task compiles with multiple compilers
> /
> # flag combinations
> -CCACHE_MAXSIZE: "1GB"
> +CCACHE_MAXSIZE:
On 03.01.23 09:41, Michael Paquier wrote:
On Tue, Jan 03, 2023 at 01:03:01PM +0530, Amit Kapila wrote:
One minor comment:
-spoken in Belgium (BE), with a UTF-8 character set
+spoken in Belgium (BE), with a UTF-8 character set
Shouldn't this be UTF8 as we are using in func.sgml?
Yeah,
On Tue, Jan 03, 2023 at 01:03:01PM +0530, Amit Kapila wrote:
> One minor comment:
> -spoken in Belgium (BE), with a UTF-8 character set
> +spoken in Belgium (BE), with a UTF-8 character set
>
> Shouldn't this be UTF8 as we are using in func.sgml?
Yeah, I was wondering as well why this
On Tue, Jan 3, 2023 at 12:58 PM Michael Paquier wrote:
>
> On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote:
>
> # Use larger ccache cache, as this task compiles with multiple compilers
> /
> # flag combinations
> -CCACHE_MAXSIZE: "1GB"
> +CCACHE_MAXSIZE: "1G"
>
>
On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote:
# Use larger ccache cache, as this task compiles with multiple compilers /
# flag combinations
-CCACHE_MAXSIZE: "1GB"
+CCACHE_MAXSIZE: "1G"
In 0006, I am not sure how much this matters. Perhaps somebody more
fluent
on hazards when written as a macro, as e.g., the
case with
--
2.25.1
>From 759288c53d30d32c608d0316df06f645ffa4dccf Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Sun, 25 Sep 2022 18:40:36 -0500
Subject: [PATCH 06/16] typos
---
.cirrus.yml | 12 +++
On 11/19/22 17:24, Tom Lane wrote:
Andres Freund writes:
On 2022-11-19 17:10:57 -0500, Joe Conway wrote:
Rishu Bagga pointed out to me offlist that this catversion bump seems
flawed:
/* mmddN */
-#define CATALOG_VERSION_NO 202211121
+#define CATALOG_VERSION_NO
Andres Freund writes:
> On 2022-11-19 17:10:57 -0500, Joe Conway wrote:
>> Rishu Bagga pointed out to me offlist that this catversion bump seems
>> flawed:
>> /* mmddN */
>> -#define CATALOG_VERSION_NO 202211121
>> +#define CATALOG_VERSION_NO 202211821
>> I think
Hi,
On 2022-11-19 17:10:57 -0500, Joe Conway wrote:
> Rishu Bagga pointed out to me offlist that this catversion bump seems
> flawed:
>
> diff --git a/src/include/catalog/catversion.h
> b/src/include/catalog/catversion.h
> index
>
On 11/18/22 16:18, Robert Haas wrote:
Fix typos and bump catversion.
Typos reported by Álvaro Herrera and Erik Rijkers.
Catversion bump for 3d14e171e9e2236139e8976f3309a588bcc8683b was
inadvertently omitted.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff
On Sat, Sep 24, 2022 at 4:00 AM Justin Pryzby wrote:
>
> On Mon, Sep 19, 2022 at 06:10:00AM -0500, Justin Pryzby wrote:
> > On Mon, Sep 19, 2022 at 11:05:24AM +0800, Zhang Mingli wrote:
> > > Good catch. There is a similar typo in doc, runtime.sgml.
> > > ```using TLS protocols enabled by by
On Mon, Sep 19, 2022 at 06:10:00AM -0500, Justin Pryzby wrote:
> On Mon, Sep 19, 2022 at 11:05:24AM +0800, Zhang Mingli wrote:
> > Good catch. There is a similar typo in doc, runtime.sgml.
> > ```using TLS protocols enabled by by setting the parameter```
>
> That one should be backpatched to v15.
On Mon, 19 Sept 2022 at 23:10, Justin Pryzby wrote:
> Find below some others.
Thanks. Pushed.
David
On Mon, Sep 19, 2022 at 02:44:12AM +, houzj.f...@fujitsu.com wrote:
> While working on some other patches, I found serval typos(duplicate words and
> incorrect function name reference) in the code comments. Here is a small patch
> to fix them.
Thanks.
On Mon, Sep 19, 2022 at 11:05:2
Hi
On Sep 19, 2022, 10:57 +0800, Amit Kapila , wrote:
> On Mon, Sep 19, 2022 at 8:14 AM houzj.f...@fujitsu.com
> wrote:
> >
> > While working on some other patches, I found serval typos(duplicate words
> > and
> > incorrect function name reference) in the
On Mon, Sep 19, 2022 at 8:14 AM houzj.f...@fujitsu.com
wrote:
>
> While working on some other patches, I found serval typos(duplicate words and
> incorrect function name reference) in the code comments. Here is a small patch
> to fix them.
>
Thanks, the patch looks good t
Hi,
While working on some other patches, I found serval typos(duplicate words and
incorrect function name reference) in the code comments. Here is a small patch
to fix them.
Best regards,
Hou zhijie
0001-fix-typos.patch
Description: 0001-fix-typos.patch
On Tue, Aug 16, 2022 at 8:48 AM John Naylor
wrote:
>
> On Fri, Aug 12, 2022 at 8:55 PM Tom Lane wrote:
> >
> > John Naylor writes:
> > > This is really a straw-man proposal, since I'm not volunteering to do
> > > the work, or suggest anybody else should do the same. That being the
> > > case,
On Fri, Aug 12, 2022 at 8:55 PM Tom Lane wrote:
>
> John Naylor writes:
> > This is really a straw-man proposal, since I'm not volunteering to do
> > the work, or suggest anybody else should do the same. That being the
> > case, it seems we should just go ahead with Justin's patch for
> >
John Naylor writes:
> This is really a straw-man proposal, since I'm not volunteering to do
> the work, or suggest anybody else should do the same. That being the
> case, it seems we should just go ahead with Justin's patch for
> consistency. Possibly we could also change the messages to say
On Fri, Aug 12, 2022, at 3:59 AM, John Naylor wrote:
> This is really a straw-man proposal, since I'm not volunteering to do
> the work, or suggest anybody else should do the same. That being the
> case, it seems we should just go ahead with Justin's patch for
> consistency. Possibly we could also
I wrote:
> On Thu, Aug 4, 2022 at 8:41 PM Tom Lane wrote:
> >
> > John Naylor writes:
>
> > > RepOriginId is a typedef for uint16, so this can't print the wrong answer,
> > > but it is inconsistent with other uses. So it seems we don't need to
> > > backpatch this one?
> >
> > Um ... if it's
On Thu, Aug 4, 2022 at 8:41 PM Tom Lane wrote:
>
> John Naylor writes:
> > RepOriginId is a typedef for uint16, so this can't print the wrong
answer,
> > but it is inconsistent with other uses. So it seems we don't need to
> > backpatch this one?
>
> Um ... if it's int16, then it can't be an
John Naylor writes:
> On Tue, Aug 2, 2022 at 1:11 AM Justin Pryzby wrote:
> ereport(ERROR,
> (errcode(ERRCODE_OBJECT_IN_USE),
> - errmsg("could not drop replication origin with OID %d, in use by PID %d",
> + errmsg("could not drop replication origin with OID %u, in use by PID %d",
>
On Tue, Aug 2, 2022 at 1:11 AM Justin Pryzby wrote:
>
> On Mon, Aug 01, 2022 at 08:04:54PM +0200, Erik Rijkers wrote:
> > Recent typos...
>
> LGTM, thanks.
>
> Here are some others I've been sitting on, mostly in .c files.
I pushed Robert's suggestion, then pushed th
On Wed, Aug 3, 2022 at 11:41 PM Robert Haas wrote:
>
> I think that it's talking about this (documented) syntax:
>
> ALTER ROUTINE name [ ( [ [ argmode ] [ argname ] argtype [, ...] ] ) ]
> [ NO ] DEPENDS ON EXTENSION extension_name
>
> So the change from "depends" to "depend" here is
On Tue, Aug 2, 2022 at 4:32 AM Erik Rijkers wrote:
> > The part of the sentence inside parentheses is not clear to me, before
> > or after the patch:
> >
> > Dropping an extension causes its component objects, and other
> > explicitly
> > dependent routines (see ,
> > - the depends on
Op 02-08-2022 om 07:28 schreef John Naylor:
On Tue, Aug 2, 2022 at 1:05 AM Erik Rijkers <mailto:e...@xs4all.nl>> wrote:
>
> Recent typos...
The part of the sentence inside parentheses is not clear to me, before
or after the patch:
Dropping an extension causes its co
On Tue, Aug 2, 2022 at 1:11 AM Justin Pryzby wrote:
>
> Here are some others I've been sitting on, mostly in .c files.
0002:
weird since c91560defc57f89f7e88632ea14ae77b5cec78ee
It was weird long before that, maybe we should instead change most of those
tabs in the top comment to single space,
On Tue, Aug 2, 2022 at 1:05 AM Erik Rijkers wrote:
>
> Recent typos...
The part of the sentence inside parentheses is not clear to me, before or
after the patch:
Dropping an extension causes its component objects, and other explicitly
dependent routines (see ,
- the d
On Mon, Aug 01, 2022 at 08:04:54PM +0200, Erik Rijkers wrote:
> Recent typos...
LGTM, thanks.
Here are some others I've been sitting on, mostly in .c files.
--
Justin
>From 19f320438476aff2773440447f167d06051a0a47 Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Tue, 5 Jul 2022 14
Recent typos...
--- ./doc/src/sgml/ref/drop_extension.sgml.orig 2022-08-01 19:38:18.249729884
+0200
+++ ./doc/src/sgml/ref/drop_extension.sgml 2022-08-01 19:40:33.312359069
+0200
@@ -32,7 +32,7 @@
DROP EXTENSION removes extensions from the database.
Dropping an extension causes its
On Thu, Apr 14, 2022 at 08:56:22AM +1200, David Rowley wrote:
> 0007: Not pushed. No space after comment and closing */ pgindent
> fixed one of these but not the other 2. I've not looked into why
> pgindent does 1 and not the other 2.
> -/* get operation priority by its code*/
> +/* get
On Mon, May 23, 2022 at 10:22:36AM -0700, Nathan Bossart wrote:
> On Mon, May 23, 2022 at 10:46:22PM +0900, torikoshia wrote:
>> It seems like there are some duplications of 'the' in pgstat.c and
>> pgstat_internal.h.
>> Attaching a tiny patch to fix them.
>
> LGTM
Thanks Torikoshi-san, fixed.
On Mon, May 23, 2022 at 10:46:22PM +0900, torikoshia wrote:
> It seems like there are some duplications of 'the' in pgstat.c and
> pgstat_internal.h.
> Attaching a tiny patch to fix them.
LGTM
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Hi,
It seems like there are some duplications of 'the' in pgstat.c and
pgstat_internal.h.
Attaching a tiny patch to fix them.
--
Regards,
--
Atsushi Torikoshi
NTT DATA CORPORATIONFrom fabf3bc5da8e5ebd4f600b6ba762d4413cbdcd6b Mon Sep 17 00:00:00 2001
From: Atsushi Torikoshi
Date: Mon, 23 May
On Tue, May 10, 2022 at 09:03:34PM -0500, Justin Pryzby wrote:
> I found a bunch more typos; a couple from codespell, and several which are the
> result of looking for previously-reported typos, like:
Thanks, applied 0002.
Regarding 0001, I don't really know which one of {AND
I found a bunch more typos; a couple from codespell, and several which are the
result of looking for previously-reported typos, like:
time git log origin --grep '[tT]ypo' --word-diff -U1 |grep -Eo
'\[-[[:lower:]]+-\]' |sed 's/^\[-//; s/-\]$//' |sort -u |grep -Fxvwf
/usr/share/dict/words
On 2022-Apr-21, Peter Eisentraut wrote:
> It is referred to as "Zstandard" at both of those places. Maybe we should
> use that. That is also easier to pronounce.
Yeah, I looked at other places (such as Yann Collet's blog) and I agree
that Zstandard seems to be the accepted spelling of the
On 21.04.22 06:36, Michael Paquier wrote:
On Wed, Apr 20, 2022 at 11:32:08PM +0200, Alvaro Herrera wrote:
So the attached.
--- a/doc/src/sgml/install-windows.sgml
+++ b/doc/src/sgml/install-windows.sgml
@@ -307,9 +307,9 @@ $ENV{MSBFLAGS}="/m";
- ZSTD
+ Zstd
-
On Wed, Apr 20, 2022 at 11:32:08PM +0200, Alvaro Herrera wrote:
> So the attached.
>
> --- a/doc/src/sgml/install-windows.sgml
> +++ b/doc/src/sgml/install-windows.sgml
> @@ -307,9 +307,9 @@ $ENV{MSBFLAGS}="/m";
>
>
>
> - ZSTD
> + Zstd
>
> - Required for
On Wed, Apr 20, 2022 at 5:31 PM Alvaro Herrera wrote:
>
> On 2022-Apr-20, Amit Kapila wrote:
>
> > Your proposed changes look good to me but I think all these places
> > need to mention 'column list' as well because the behavior is the same
> > for it.
>
> Hmm, you're right. Added that, and
On Wed, Apr 20, 2022 at 11:32:08PM +0200, Alvaro Herrera wrote:
> On 2022-Apr-19, Alvaro Herrera wrote:
>
> > I propose we standardize on Zstd everywhere.
> > Users can look it up if they're really interested.
>
> So the attached.
>
> There are other uses of zstd, but those are referring to
>
On 2022-Apr-19, Alvaro Herrera wrote:
> I propose we standardize on Zstd everywhere.
> Users can look it up if they're really interested.
So the attached.
There are other uses of zstd, but those are referring to the
executable program.
--
Álvaro Herrera PostgreSQL Developer —
On 2022-Apr-20, Amit Kapila wrote:
> Your proposed changes look good to me but I think all these places
> need to mention 'column list' as well because the behavior is the same
> for it.
Hmm, you're right. Added that, and changed the wording somewhat because
some things read awkwardly. Here's
On Tue, Apr 19, 2022 at 4:35 PM Alvaro Herrera wrote:
>
> Yeah, more invasive rewording seems called for. I propose this:
>
>For publications containing partitioned tables, the row filter for each
>partition is taken from the published partitioned table if the
>publication parameter
CCing Amit K, because I propose a few relatively minor changes to
logical rep docs.
On 2022-Apr-13, Justin Pryzby wrote:
> $ git grep -F ", the default)"
> doc/src/sgml/ref/create_publication.sgml: partition's row filter (if the
> parameter is false, the default) or the root
>
> Maybe what's
On Thu, Apr 14, 2022 at 09:39:42AM +1200, David Rowley wrote:
> On Thu, 14 Apr 2022 at 05:40, Justin Pryzby wrote:
> > There's (only) a few remaining.
>
> I've pushed 0001 and 0002 of the 3rd batch of patches. I left 0003 as
Thanks
> I just didn't feel it was a meaningful enough improvement.
>
(For the future, just to make discussions easier, it would be good if
you could have git format-patch -v N to give a unique version number
to these patches)
On Thu, 14 Apr 2022 at 05:40, Justin Pryzby wrote:
> There's (only) a few remaining.
I've pushed 0001 and 0002 of the 3rd batch of
On Mon, 11 Apr 2022 at 22:10, Justin Pryzby wrote:
> Thanks for amending and pushing those. There's some more less obvious ones
> attached.
Here are my notes from yesterday that I made when reviewing and
pushing many of the 2nd batch of patches.
0001: Pushed and back patched to v12
0002:
On Wed, Apr 13, 2022 at 07:29:34PM +0200, Alvaro Herrera wrote:
> On 2022-Apr-11, David Rowley wrote:
>
> > and also skipped:
> > 0016 (unsure if we should change these of pgindent is not touching it)
> > 0017 (unsure if we should change these of pgindent is not touching it)
>
> I verified that
On 2022-Apr-11, David Rowley wrote:
> and also skipped:
> 0016 (unsure if we should change these of pgindent is not touching it)
> 0017 (unsure if we should change these of pgindent is not touching it)
I verified that pgindent will indeed not touch these changes by running
before and after. (I
On Mon, Apr 11, 2022 at 4:15 PM Amit Kapila wrote:
>
> On Mon, Apr 11, 2022 at 3:55 PM Masahiko Sawada wrote:
> >
> > On Mon, Apr 11, 2022 at 7:10 PM Justin Pryzby wrote:
> > >
> > > Amit or Masahiko may want to comment on 0012 (doc review: Add ALTER
> > > SUBSCRIPTION ... SKIP).
> >
>
> +1.
On Mon, Apr 11, 2022 at 4:56 AM David Rowley wrote:
> 0011 (Could do with input from Robert and Joe)
Seems like a reasonable change to me.
--
Robert Haas
EDB: http://www.enterprisedb.com
On Mon, Apr 11, 2022 at 3:55 PM Masahiko Sawada wrote:
>
> On Mon, Apr 11, 2022 at 7:10 PM Justin Pryzby wrote:
> >
> > Amit or Masahiko may want to comment on 0012 (doc review: Add ALTER
> > SUBSCRIPTION ... SKIP).
>
> Thank you for the patch! I've looked at 0012 patch. Regarding the
>
On Mon, Apr 11, 2022 at 7:10 PM Justin Pryzby wrote:
>
> On Mon, Apr 11, 2022 at 04:39:30PM +1200, David Rowley wrote:
> > I'm not entirely certain this is an improvement. Your commit message
> > I'd say is not true going by git grep "compression algorithm". There
> > are 3 matches in the docs
On Mon, Apr 11, 2022 at 04:39:30PM +1200, David Rowley wrote:
> I'm not entirely certain this is an improvement. Your commit message
> I'd say is not true going by git grep "compression algorithm". There
> are 3 matches in the docs and take [1], for example. I'd say in that
> one it's better to
On Mon, 11 Apr 2022 at 16:39, David Rowley wrote:
> I will start pushing the less controversial of these, after a bit of
> squashing.
I just committed 3 separate commits for the following:
Committed: 0001 + 0003 + 0004 + 0006 + 0007 (modified) + 0008 + 0009 +
0012 (doc parts)
Committed: 0012
1 - 100 of 318 matches
Mail list logo
