Re: using SysCacheGetAttrNotNull in place of heap_getattr

2023-08-23 Thread Tom Lane
Alvaro Herrera writes: > I was about to push a quick patch to replace the use of heap_getattr() > in get_primary_key_attnos() with SysCacheGetAttrNotNull(), because that > makes the code a few lines shorter and AFAICS there's no downside. > However, I realized that the commit that added the

using SysCacheGetAttrNotNull in place of heap_getattr

2023-08-23 Thread Alvaro Herrera
I was about to push a quick patch to replace the use of heap_getattr() in get_primary_key_attnos() with SysCacheGetAttrNotNull(), because that makes the code a few lines shorter and AFAICS there's no downside. However, I realized that the commit that added the function (d435f15fff3c) did not make