Re: vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases

2024-03-11 Thread Nathan Bossart
On Fri, Mar 08, 2024 at 04:03:22PM -0600, Nathan Bossart wrote: > On Fri, Mar 08, 2024 at 09:33:19AM +, Dean Rasheed wrote: >> I think this is good to go. > > Thanks. In v4, I've added a first draft of the commit messages, and I am > planning to commit this early next week. Committed. --

Re: vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases

2024-03-08 Thread Nathan Bossart
On Fri, Mar 08, 2024 at 09:33:19AM +, Dean Rasheed wrote: > If I'm nitpicking, "[--verbose | -v]" in the clusterdb synopsis should > be replaced with "[option...]", like the other commands, because there > are other general-purpose options like --quiet and --echo. Good catch. I fixed that in

Re: vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases

2024-03-08 Thread Dean Rasheed
On Wed, 6 Mar 2024 at 22:22, Nathan Bossart wrote: > > Thanks for taking a look. I updated the synopsis sections in v3. OK, that looks good. The vacuumdb synopsis in particular looks a lot better now that "-N | --exclude-schema" is on its own line, because it was hard to read previously, and

Re: vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases

2024-03-06 Thread Nathan Bossart
On Tue, Mar 05, 2024 at 11:20:13PM +, Dean Rasheed wrote: > I'm not sure how useful these changes are, but I don't really object. > You need to update the synopsis section of the docs though. Thanks for taking a look. I updated the synopsis sections in v3. I also spent some more time on the

Re: vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases

2024-03-05 Thread Dean Rasheed
On Tue, 5 Mar 2024 at 02:22, Nathan Bossart wrote: > > I saw that this thread was referenced elsewhere [0], so I figured I'd take > a fresh look. From a quick glance, I'd say 0001 and 0002 are pretty > reasonable and could probably be committed for v17. > I'm not sure how useful these changes

Re: vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases

2024-03-04 Thread Nathan Bossart
On Mon, Oct 23, 2023 at 03:25:42PM -0500, Nathan Bossart wrote: > rebased I saw that this thread was referenced elsewhere [0], so I figured I'd take a fresh look. From a quick glance, I'd say 0001 and 0002 are pretty reasonable and could probably be committed for v17. 0003 probably requires

Re: vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases

2023-10-23 Thread Nathan Bossart
rebased -- Nathan Bossart Amazon Web Services: https://aws.amazon.com >From 9618c243cbd3056006acda0136036b432af37830 Mon Sep 17 00:00:00 2001 From: Nathan Bossart Date: Wed, 28 Jun 2023 15:12:18 -0700 Subject: [PATCH v2 1/3] vacuumdb: allow specifying tables or schemas to process in all

Re: vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases

2023-06-29 Thread Nathan Bossart
On Fri, Jun 30, 2023 at 12:05:17PM +0900, Kyotaro Horiguchi wrote: > At Thu, 29 Jun 2023 13:56:38 -0700, Nathan Bossart > wrote in >> Sorry, I'm not following. I intentionally avoided allowing combinations of >> --schema and --table in the patches I sent. This is the current behavior >> of

Re: vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases

2023-06-29 Thread Kyotaro Horiguchi
At Thu, 29 Jun 2023 13:56:38 -0700, Nathan Bossart wrote in > Thanks for taking a look. > > On Thu, Jun 29, 2023 at 02:16:26PM +0900, Kyotaro Horiguchi wrote: > > At Wed, 28 Jun 2023 16:24:02 -0700, Nathan Bossart > > wrote in > >> I debated also allowing users to specify different types of

Re: vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases

2023-06-29 Thread Nathan Bossart
Thanks for taking a look. On Thu, Jun 29, 2023 at 02:16:26PM +0900, Kyotaro Horiguchi wrote: > At Wed, 28 Jun 2023 16:24:02 -0700, Nathan Bossart > wrote in >> I debated also allowing users to specify different types of objects in the >> same command (e.g., "vacuumdb --schema myschema --table

Re: vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases

2023-06-28 Thread Kyotaro Horiguchi
At Wed, 28 Jun 2023 16:24:02 -0700, Nathan Bossart wrote in > While working on some other patches, I found myself wanting to use the > following command to vacuum the catalogs in all databases in a cluster: > > vacuumdb --all --schema pg_catalog > > However, this presently fails with

vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases

2023-06-28 Thread Nathan Bossart
While working on some other patches, I found myself wanting to use the following command to vacuum the catalogs in all databases in a cluster: vacuumdb --all --schema pg_catalog However, this presently fails with the following error: cannot vacuum specific schema(s) in all