The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
I have a very serious concern about the current patch set. as someone who
Amit, thanks for looking into this!
On Sun, Nov 20, 2022 at 11:38 PM Amit Kapila
wrote:
> On Mon, Nov 21, 2022 at 12:45 PM sirisha chamarthi
> wrote:
> >
> > Hi Hackers,
> >
> > The comments atop seem to indicate that it is only showing active
> replication slots. The comment is ambiguous as
On Sun, 20 Nov 2022 at 22:55, Nathan Bossart wrote:
>
> On Mon, Nov 21, 2022 at 10:31:15AM +1300, Thomas Munro wrote:
> > On Mon, Nov 21, 2022 at 9:00 AM Simon Riggs
> > wrote:
> >> As a 3rd patch, I will work on making logical workers hibernate.
> >
> > Duelling patch warning: Nathan
On Mon, Nov 21, 2022 at 12:45 PM sirisha chamarthi
wrote:
>
> Hi Hackers,
>
> The comments atop seem to indicate that it is only showing active replication
> slots. The comment is ambiguous as it also shows all the slots including lost
> and inactive slots. Attached a small patch to fix it.
>
On Mon, 21 Nov 2022 at 05:07, Laurenz Albe wrote:
>
> On Mon, 2022-11-21 at 10:13 +1300, Thomas Munro wrote:
> > I'll wait 24 hours before committing, to
> > provide a last chance for anyone who wants to complain about dropping
> > promote_trigger_file.
>
> Remove "promote_trigger_file"? Now I
On Sat, Nov 19, 2022 at 6:35 AM Andres Freund wrote:
>
> On 2022-11-18 11:20:36 +0530, Amit Kapila wrote:
> > Okay, updated the patch accordingly.
>
> Assuming it passes tests etc, this'd work for me.
>
Thanks, Pushed.
--
With Regards,
Amit Kapila.
On Fri, Nov 18, 2022 at 2:48 PM I wrote:
> One issue with this patch: The "fanout" member is a uint8, so it can't
hold 256 for the largest node kind. That's not an issue in practice, since
we never need to grow it, and we only compare that value with the count in
an Assert(), so I just set it to
Hi Hackers,
The comments atop seem to indicate that it is only showing active
replication slots. The comment is ambiguous as it also shows all the slots
including lost and inactive slots. Attached a small patch to fix it.
Thanks,
Sirisha
Hi Hackers,
forking this thread from the discussion [1] as suggested by Amit.
Catalog_xmin is not advanced when a logical slot is invalidated (lost)
until the invalidated slot is dropped. This patch ignores invalidated slots
while computing the oldest xmin. Attached a small patch to address this
On Mon, Nov 21, 2022 at 2:43 AM Thomas Munro wrote:
>
> On Mon, Nov 21, 2022 at 3:35 AM Simon Riggs
> wrote:
> > On Sat, 19 Nov 2022 at 10:59, Simon Riggs
> > wrote:
> > > New version attached.
> >
> > Fix for doc xref
>
> I removed a stray variable declaration from xlogrecovery.h, and wrote
>
On Fri, Nov 18, 2022 at 8:20 PM Masahiko Sawada
wrote:
>
> On Thu, Nov 17, 2022 at 12:24 AM Masahiko Sawada
wrote:
> >
> > On Wed, Nov 16, 2022 at 4:39 PM John Naylor
> > wrote:
> > > That means my idea for the pointer struct might have some problems,
at least as currently implemented. Maybe
On Fri, Nov 18, 2022 at 6:03 PM Peter Smith wrote:
>
> Here are some review comments for v47-0001
>
> (This review is a WIP - I will post more comments for this patch next week)
>
Here are the rest of my comments for v47-0001
==
doc/src/sgml/monitoring.
1.
@@ -1851,6 +1851,11 @@ postgres
On Mon, Nov 21, 2022 at 10:37 AM Laurenz Albe wrote:
>
> On Mon, 2022-11-21 at 10:13 +1300, Thomas Munro wrote:
> > I'll wait 24 hours before committing, to
> > provide a last chance for anyone who wants to complain about dropping
> > promote_trigger_file.
>
> Remove "promote_trigger_file"? Now
Corey Huinker writes:
> On Tue, Nov 15, 2022 at 11:36 AM Andrew Dunstan wrote:
>> Nikita,
>> just checking in, are you making progress on this? I think we really
>> need to get this reviewed and committed ASAP if we are to have a chance
>> to get the SQL/JSON stuff reworked to use it in time for
On Tue, Nov 15, 2022 at 11:36 AM Andrew Dunstan wrote:
>
> On 2022-10-07 Fr 13:37, Tom Lane wrote:
>
>
> [ lots of detailed review ]
>
> > Basically, this patch set should be a lot smaller and not have ambitions
> > beyond "get the API right" and "make one or two datatypes support COPY
> >
>
> WITH data_src AS (SELECT * FROM source_tbl),
> insert_a AS (INSERT INTO a SELECT * FROM data_src WHERE d < 5),
> insert_b AS (INSERT INTO b SELECT * FROM data_src WHERE d >= 5)
> INSERT INTO c SELECT * FROM data_src WHERE d < 5
>
I suppose you could just do a dummy SELECT at the bottom to
On Mon, 2022-11-21 at 10:13 +1300, Thomas Munro wrote:
> I'll wait 24 hours before committing, to
> provide a last chance for anyone who wants to complain about dropping
> promote_trigger_file.
Remove "promote_trigger_file"? Now I have never seen anybody use that
parameter, but I don't think
On Mon, Nov 14, 2022 at 7:06 PM Alexandre hadjinlian guerra <
alexhgue...@gmail.com> wrote:
> Hello
> Are there any plans to incorporate a formal syntax multitable/conditional
> insert , similar to the syntax below? snowflake does have the same feature
>
>
Peter Geoghegan writes:
> On Sun, Nov 20, 2022 at 12:37 PM Tom Lane wrote:
>> The core reloptions.sql and vacuum.sql tests are two places that are
>> also using this option, but they are applying it to temp tables,
>> which I think makes it safe (and the lack of failures, seeing that
>> they run
Mark Dilger writes:
> On Nov 20, 2022, at 12:37 PM, Tom Lane wrote:
>> contrib/amcheck and contrib/pg_visibility are also using
>> DISABLE_PAGE_SKIPPING, so I wonder if they have similar hazards.
>> I haven't seen them fall over, though.
> In the amcheck regression test case, it's because the
> On Nov 20, 2022, at 12:37 PM, Tom Lane wrote:
>
> contrib/amcheck and contrib/pg_visibility are also using
> DISABLE_PAGE_SKIPPING, so I wonder if they have similar hazards.
> I haven't seen them fall over, though.
In the amcheck regression test case, it's because the test isn't sensitive
I finally found time to digest and integrate your changes into my local
branch. This fixes the three issues you reported: FORCE_RELEASE, issue
with INVALID partitions issue (for which I adapted your patch into an
earlier patch in my series), and progress reporting. And rebased.
--
Justin
>From
This doesn't seem like fitting here, but..
At Fri, 18 Nov 2022 18:38:56 +0530, Satya Thirumani
wrote in
> I'm unable to reset stats. Please help me to fix this?
>
> testdb => select * from pg_stat_reset_replication_slot(NULL);
> ERROR: permission denied for function
At Fri, 18 Nov 2022 15:55:00 +0530, Bharath Rupireddy
wrote in
> On Fri, Nov 18, 2022 at 12:42 AM Robert Haas wrote:
> >
> > On Thu, Nov 17, 2022 at 2:22 AM Bharath Rupireddy
> > wrote:
> > > Duplication is a problem that I agree with and I have an idea here -
> > > how about introducing a
On Sun, Nov 20, 2022 at 6:24 PM Isaac Morland
wrote:
> What I'm finding is that the UPDATE is taking over an hour for 5000
> records, and tons of WAL is being generated, several files per minute.
> Selecting the non-PDF columns from the entire table takes a few
> milliseconds, and the only thing
I'm encountering some surprising (to me) behaviour related to WAL, and I'm
wondering if anybody can point me at an article that might help me
understand what is happening, or give a brief explanation.
I'm trying to make a slimmed down version of my database for testing
purposes. As part of this,
Hi,
One good follow up patch will be to rip out the accounting for
pg_stat_bgwriter's buffers_backend, buffers_backend_fsync and perhaps
buffers_alloc and replace it with a subselect getting the equivalent data from
pg_stat_io. It might not be quite worth doing for buffers_alloc because of
the
On 19/11/2022 13:00, Peter Eisentraut wrote:
On 18.10.21 14:15, Heikki Linnakangas wrote:
On 05/10/2021 20:24, John Naylor wrote:
I've had a chance to review and test out the v5 patches.
Thanks! I fixed the stray reference to PostgreSQL 14 that Zhihong
mentioned, and pushed.
AFAICT, this
Hi,
On 2022-11-18 12:18:38 +0100, Drouvot, Bertrand wrote:
> On 11/16/22 9:12 PM, Andres Freund wrote:
> > This still leaves a fair bit of boilerplate. ISTM that the function body
> > really should just be a single line.
> >
> > Might even be worth defining the whole function via a macro.
On Sun, Nov 20, 2022 at 3:12 PM Michael Paquier wrote:
> On Sun, Nov 20, 2022 at 08:21:10AM -0800, Ted Yu wrote:
> > For get_func_sql_syntax(), the code for cases
> > of F_CURRENT_TIME, F_CURRENT_TIMESTAMP, F_LOCALTIME and F_LOCALTIMESTAMP
> is
> > mostly the same.
> > Maybe we can introduce a
On Sun, Nov 20, 2022 at 11:26:11AM -0600, Justin Pryzby wrote:
> I think this patch record should be closed for now. You can re-open the
> existing patch record once a patch is ready to be reviewed.
Indeed. As of things are, this is just a dead entry in the CF which
would be confusing. I have
On Sun, Nov 20, 2022 at 08:21:10AM -0800, Ted Yu wrote:
> For get_func_sql_syntax(), the code for cases
> of F_CURRENT_TIME, F_CURRENT_TIMESTAMP, F_LOCALTIME and F_LOCALTIMESTAMP is
> mostly the same.
> Maybe we can introduce a helper so that code duplication is reduced.
It would. Thanks for the
Hi,
On 2022-11-20 17:26:11 -0500, Robert Haas wrote:
> On Sun, Nov 20, 2022 at 3:43 PM Andres Freund wrote:
> > I couldn't quite decide what wait_event_type to best group this under? In
> > the
> > attached patch I put it under timeouts, which doesn't seem awful.
>
> I think it would be best
On Mon, Nov 21, 2022 at 10:31:15AM +1300, Thomas Munro wrote:
> On Mon, Nov 21, 2022 at 9:00 AM Simon Riggs
> wrote:
>> As a 3rd patch, I will work on making logical workers hibernate.
>
> Duelling patch warning: Nathan mentioned[1] that he's hacking on a
> patch for that, along the lines of the
On Sun, Nov 20, 2022 at 2:44 AM Andrew Dunstan wrote:
> It might not suit your use case, but one of the things I do to reduce
> fetch load is to run a local mirror which runs
>
>git fetch -q --prune
>
> every 5 minutes. It also runs a git daemon, and several of my animals
> point at that.
On Sun, Nov 20, 2022 at 3:43 PM Andres Freund wrote:
> The lwlock wait queue scalability issue [1] was quite hard to find because of
> the exponential backoff and because we adjust spins_per_delay over time within
> a backend.
>
> I think the least we could do to make this easier would be to
Hi Tom,
On Sun, Nov 20, 2022 at 11:43:41AM -0500, Tom Lane wrote:
> Roberto =?iso-8859-1?Q?C=2E_S=E1nchez?= writes:
> > -- this makes a shell "point <<@@ polygon" operator too
> > CREATE OPERATOR @@>> ( PROCEDURE = poly_contain_pt,
> >LEFTARG = polygon, RIGHTARG = point,
> >COMMUTATOR
On Mon, Nov 21, 2022 at 10:31 AM Magnus Hagander wrote:
> Um, branches of interest will only pick up when it gets a new *branch*, not a
> new *commit*, so I think that would be a very different problem to solve. And
> I don't think we have new branche *that* often...
Sure, could be done with
Bauyrzhan Sakhariyev writes:
> Hi! Do I get it right, that bitwise operations have the same precedence?
Yes, that is what the documentation says:
https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-PRECEDENCE
Operator precedence is hard-wired into our parser, so we don't get
to
On Mon, Nov 21, 2022 at 9:00 AM Simon Riggs
wrote:
> As a 3rd patch, I will work on making logical workers hibernate.
Duelling patch warning: Nathan mentioned[1] that he's hacking on a
patch for that, along the lines of the recent walreceiver change IIUC.
[1]
On Sun, Nov 20, 2022 at 4:56 AM Thomas Munro wrote:
> On Sun, Nov 20, 2022 at 1:35 AM Magnus Hagander
> wrote:
> > tl,tr; it's not there now, but yes if we can find a smart way for th ebf
> clients to consume it, it is something we could build and deploy fairly
> easily.
>
> Cool -- it sounds a
Hi! Do I get it right, that bitwise operations have the same precedence?
Query *SELECT 1 & 2 | 3, 3 | 1 & 2*
returns 3 and 2 respectively. See also
https://www.db-fiddle.com/f/iZHd8zG7A1HjbB6J2y8R7k/1. It looks like the
result is calculated from left to right and operators have
the same
On Mon, Nov 21, 2022 at 3:35 AM Simon Riggs
wrote:
> On Sat, 19 Nov 2022 at 10:59, Simon Riggs
> wrote:
> > New version attached.
>
> Fix for doc xref
I removed a stray variable declaration from xlogrecovery.h, and wrote
a draft commit message. I'll wait 24 hours before committing, to
provide
On Sun, Nov 20, 2022 at 12:37 PM Tom Lane wrote:
> The core reloptions.sql and vacuum.sql tests are two places that are
> also using this option, but they are applying it to temp tables,
> which I think makes it safe (and the lack of failures, seeing that
> they run within parallel test groups,
Hi,
The lwlock wait queue scalability issue [1] was quite hard to find because of
the exponential backoff and because we adjust spins_per_delay over time within
a backend.
I think the least we could do to make this easier would be to signal spin
delays as wait events. We surely don't want to do
My very slow buildfarm animal mamba has failed pageinspect
several times [1][2][3][4] with this symptom:
diff -U3
/home/buildfarm/bf-data/HEAD/pgsql.build/contrib/pageinspect/expected/page.out
/home/buildfarm/bf-data/HEAD/pgsql.build/contrib/pageinspect/results/page.out
---
On Thu, 24 Mar 2022 at 16:21, Robert Haas wrote:
>
> On Thu, Mar 24, 2022 at 12:02 PM Simon Riggs
> > What changes will be acceptable for bgwriter, walwriter and logical worker?
>
> Hmm, I think it would be fine to introduce some kind of hibernation
> mechanism for logical workers. bgwriter and
On Tue, Nov 15, 2022 at 10:55 PM Andres Freund wrote:
> I'm quite certain that it's possible to end up freezing an earlier row
> versions in a hot chain in < 14, I got there with careful gdb
> orchestration. Of course possible I screwed something up, given I did it once,
> interactively. Not sure
Hi,
On 2022-11-09 17:03:13 -0800, Andres Freund wrote:
> On 2022-11-09 09:38:08 -0800, Andres Freund wrote:
> > I'm on a hike, without any connectivity, Thu afternoon - Sun. I think it's
> > OK
> > to push it to HEAD if I get it done in the next few hours. Bigger issues,
> > which I do not
On 2022-11-20 10:10:38 -0500, Andrew Dunstan wrote:
> OK, pushed with a little more tweaking.
Thanks!
> I didn't upcase top_builddir
> because the existing prove_installcheck recipes already export it and I
> wanted to stay consistent with those.
Makes sense.
> If it works ok I will
Hi,
On 2022-11-19 09:38:26 +0100, Drouvot, Bertrand wrote:
> I'd vote for V3 for readability, size and "backward compatibility" with
> current code.
Pushed that. Thanks for the patch and evaluation.
Greetings,
Andres Freund
.On Sun, Nov 20, 2022 at 8:48 PM Alexander Korotkov
wrote:
> I've drafted a patch implementing ALTER ROLE ... SET ... TO ... USER SET
> syntax.
>
> These options are working only for USERSET GUC variables, but require
> less privileges to set. I think there is no problem to implement
>
> Also
On Sat, Nov 19, 2022 at 4:02 AM Alexander Korotkov wrote:
> On Sat, Nov 19, 2022 at 12:41 AM Tom Lane wrote:
> > ... BTW, re-reading the commit message for a0ffa885e:
> >
> > One caveat is that PGC_USERSET GUCs are unaffected by the SET privilege
> > --- one could wish that those were
On Fri, Aug 05, 2022 at 02:23:45PM +, Georgios Kokolatos wrote:
> Thank you for your work during commitfest.
>
> The patch is still in development. Given vacation status, expect the next
> patches to be ready for the November commitfest.
> For now it has moved to the September one. Further
On Sat, Nov 19, 2022 at 10:50:04AM -0800, Nathan Bossart wrote:
> another rebase
Another rebase for cfbot.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
>From 5f716f33e93187491686381b2180894ab2b1b92c Mon Sep 17 00:00:00 2001
From: Nathan Bossart
Date: Wed, 7 Sep 2022 22:25:29
Roberto =?iso-8859-1?Q?C=2E_S=E1nchez?= writes:
> -- this makes a shell "point <<@@ polygon" operator too
> CREATE OPERATOR @@>> ( PROCEDURE = poly_contain_pt,
>LEFTARG = polygon, RIGHTARG = point,
>COMMUTATOR = <<@@ );
> CREATE EXTENSION test_ext_cor; -- fail
> ERROR: operator
On Sun, 20 Nov 2022 at 13:45, Michail Nikolaev
wrote:
> If such approach looks committable - I could do more careful
> performance testing to find the best value for
> WASTED_SNAPSHOT_WORK_LIMIT_TO_COMPRESS.
Nice patch.
We seem to have replaced one magic constant with another, so not sure
if
On Sat, Nov 19, 2022 at 7:01 PM Michael Paquier wrote:
> On Fri, Nov 18, 2022 at 10:23:58AM +0900, Michael Paquier wrote:
> > Please note that in order to avoid tweaks when choosing the attribute
> > name of function call, this needs a total of 8 new catalog functions
> > mapping to the SQL
On 2022-11-19 Sa 15:16, Andres Freund wrote:
> Hi,
>
> On 2022-11-19 10:56:33 -0500, Andrew Dunstan wrote:
>>> Perhaps we should just export a directory in configure instead of this
>>> guessing game?
>> I think the obvious candidate would be to export top_builddir from
>> src/Makefile.global.
On Sat, 19 Nov 2022 at 10:59, Simon Riggs wrote:
> New version attached.
Fix for doc xref
--
Simon Riggshttp://www.EnterpriseDB.com/
hibernate_startup.v10.patch
Description: Binary data
Greetings PGSQL hackers,
I am working on a backport of CVE-2022-2625 to PostgreSQL 9.6 and 9.4.
I am starting from commit 5919bb5a5989cda232ac3d1f8b9d90f337be2077.
The backport to 9.6 was relatively straightforward, the principal change
being to omit some of the hunks related to commands in 9.6
Oh, seems like it is not my day :) The image fixed again.
Oops, wrong image, this is correct one. But is 1-run tests, so it
shows only basic correlation,
Hello.
On Wed, Nov 16, 2022 at 3:44 AM Andres Freund wrote:
> Approach 1:
> We could have an atomic variable in ProcArrayStruct that counts the amount of
> wasted effort and have processes update it whenever they've wasted a
> meaningful amount of effort. Something like counting the skipped
Hello David,
Question: is there any way to really abort a psql script from an
included file?
Under what circumstances would it be appropriate for a script to take
it on itself to decide that? It has no way of knowing what the next -f
option is or what the user intended.
Can we add an
65 matches
Mail list logo
