Hi,
To the developers working on pg_rman, are there any plans to support PG15
and when might pg_rman source be released?
The latest version of pg_rman, V1.3.14, appears to be incompatible with
PG15.
(In PG15, pg_start_backup()/pg_stop_backup() have been renamed.)
On 25.11.2022 10:34, Michael Paquier wrote:
On Fri, Nov 25, 2022 at 10:13:29AM +0300, Anton A. Melnikov wrote:
The test fails almost at the beginning in reset_pg_hba call after
modification pg_hba.conf and node reloading:
#t/003_peer.pl .. Dubious, test returned 2 (wstat 512, 0x200)
#No
On Fri, Nov 25, 2022 at 10:13:29AM +0300, Anton A. Melnikov wrote:
> The test fails almost at the beginning in reset_pg_hba call after
> modification pg_hba.conf and node reloading:
> #t/003_peer.pl .. Dubious, test returned 2 (wstat 512, 0x200)
> #No subtests run
>
> Logs regress_log_003_peer
On Fri, Nov 11, 2022 at 11:24 PM Tom Lane wrote:
> Richard Guo writes:
> > I'm wondering whether we need to insist on being strict for the lower
> > OJ's min_righthand. What if we instead check strictness for its whole
> > syn_righthand?
>
> Surely not. What if the only point of strictness is
Hello, thanks for rapid answer!
On 25.11.2022 08:18, Michael Paquier wrote:
You are not using MSVC but MinGW, are you? The buildfarm members with
TAP tests enabled are drongo, fairywren, bowerbord and jacana. Even
though none of them are running the tests from
src/test/authentication/, this
On Thu, Nov 24, 2022 at 4:43 PM Amit Kapila wrote:
>
> On Thu, Nov 24, 2022 at 1:48 PM Masahiko Sawada wrote:
> >
> > On Wed, Nov 23, 2022 at 12:00 PM Amit Kapila
> > wrote:
> >
> > Agreed not to have a test case for this.
> >
> > I've attached an updated patch. I've confirmed this patch works
Hello,
I found that qual_is_pushdown_safe() has an argument "subquery"
that is not used in the function. This argument has not been
referred to since the commit 964c0d0f80e485dd3a4073e073ddfd9bfdda90b2.
I think we can remove this if there is no special reason.
Regards,
Yugo Nagata
--
Yugo
On Sun, 20 Nov 2022 at 09:29, vignesh C wrote:
>
> On Fri, 11 Nov 2022 at 11:03, Peter Smith wrote:
> >
> > On Fri, Nov 11, 2022 at 4:17 PM Peter Smith wrote:
> > >
> > > On Fri, Nov 11, 2022 at 4:09 PM Peter Smith wrote:
> > > >
> > > > On Fri, Nov 11, 2022 at 3:47 PM Peter Smith
> > > >
On 25/11/22 02:14, David Rowley wrote:
On Fri, 25 Nov 2022 at 06:57, Ankit Kumar Pandey wrote:
Please let me know any opinions on this.
I think if you're planning on working on this then step 1 would have
to be checking the SQL standard to see which set of rows it asks
implementations to
On Fri, Nov 25, 2022 at 07:56:08AM +0300, Anton A. Melnikov wrote:
> On Windows this test fails with error:
> # connection error: 'psql: error: connection to server at "127.0.0.1", port
> x failed:
> # FATAL: no pg_hba.conf entry for host "127.0.0.1", user "buildfarm",
> database
Hello!
On Windows this test fails with error:
# connection error: 'psql: error: connection to server at "127.0.0.1", port
x failed:
# FATAL: no pg_hba.conf entry for host "127.0.0.1", user "buildfarm", database
"postgres", no encryption'
May be disable this test for windows like in
On Thu, Nov 24, 2022 at 2:26 AM Andres Freund wrote:
>
> Indeed. This is why I was thinking that just alerting for overflowed xact
> isn't particularly helpful. You really want to see how much they overflow and
> how often.
I think the way of monitoring the subtransaction count and overflow
On Fri, 25 Nov 2022 at 16:00, Richard Guo wrote:
> Verified the problem is fixed with this patch. I'm not familiar with
> the WindowAgg execution codes. As far as I understand, this patch works
> because we set ecxt_aggnulls to true, making it a NULL value. And the
> top-level WindowAgg node's
On Fri, Nov 25, 2022 at 8:49 AM Dilip Kumar wrote:
>
> On Thu, Nov 24, 2022 at 9:39 PM Justin Pryzby wrote:
> > On Thu, Nov 24, 2022 at 08:52:16PM +0530, Dilip Kumar wrote:
> > > but now you will have one gigantic index and which will be vacuumed
> > > every time we vacuum any of the partitions.
On Thu, Nov 24, 2022 at 9:39 PM Justin Pryzby wrote:
> On Thu, Nov 24, 2022 at 08:52:16PM +0530, Dilip Kumar wrote:
> > but now you will have one gigantic index and which will be vacuumed
> > every time we vacuum any of the partitions.
>
> This patch isn't implemented as "one gigantic index",
On Fri, Nov 25, 2022 at 7:34 AM David Rowley wrote:
> Since upper-level WindowAggs cannot reference values calculated in
> some lower-level WindowAgg, why can't we just NULLify the pointers
> instead? See attached.
Verified the problem is fixed with this patch. I'm not familiar with
the
Here are some review comments for v51-0001.
==
.../replication/logical/applyparallelworker.c
1. General - Error messages, get_worker_name()
I previously wrote a comment to ask if the get_worker_name() should be
used in more places but the reply [1, #2b] was:
> 2b.
> Consider if maybe all
On Fri, Nov 25, 2022 at 07:41:59AM +0900, Michael Paquier wrote:
> On Thu, Nov 24, 2022 at 05:07:24PM +0800, Julien Rouhaud wrote:
> > So I went with CONF_FILE_START_DEPTH and CONF_FILE_MAX_DEPTH. Attached v22
> > that fixes it in all the places I found.
>
> Sounds fine. Added one comment,
Hello.
I reviewed this patch and I would like to share some comments.
It compiled with those 2 warnings:
verify_gin.c: In function 'gin_check_parent_keys_consistency':
verify_gin.c:481:38: warning: declaration of 'maxoff' shadows a previous
local [-Wshadow=compatible-local]
481 |
On Fri, 25 Nov 2022 at 00:52, Sergey Shinderuk
wrote:
> Shouldn't we handle any pass-by-reference type the same? I suppose, a
> user-defined window function can return some other type, not int8.
Thanks for reporting this and to you and Richard for working on a fix.
I've just looked at it and it
On Thu, Nov 24, 2022 at 05:07:24PM +0800, Julien Rouhaud wrote:
> So I went with CONF_FILE_START_DEPTH and CONF_FILE_MAX_DEPTH. Attached v22
> that fixes it in all the places I found.
Sounds fine. Added one comment, fixed one comment, and applied.
Thanks!
--
Michael
signature.asc
Description:
On Mon, 21 Nov 2022 at 17:34, Naeem Akhter wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation:not tested
>
>
> On 24 Nov 2022, at 20:32, Andres Freund wrote:
>
> On November 24, 2022 11:07:43 AM PST, Daniel Gustafsson
> wrote:
>>> On 24 Nov 2022, at 18:07, Nikolay Shaplov wrote:
>> One option could be to redefine bail() to take the exit function as a
>> parameter
>> and have the caller pass the
On Fri, 25 Nov 2022 at 09:31, Tom Lane wrote:
> If you wanted to be hard-nosed about 80 character width, you could
> pull out the PageGetItemId call into a separate local variable.
> I wasn't going to be quite that picky, but I won't object if that
> seems better to you.
I wasn't too worried
On Fri, 25 Nov 2022 at 09:40, Ted Yu wrote:
> Patch v4 stores ItemId in a local variable.
ok, I pushed that one. Thank you for working on this.
David
On Fri, 25 Nov 2022 at 06:57, Ankit Kumar Pandey wrote:
> Please let me know any opinions on this.
I think if you're planning on working on this then step 1 would have
to be checking the SQL standard to see which set of rows it asks
implementations to consider for duplicate checks when deciding
On Fri, Nov 25, 2022 at 2:15 AM Takamichi Osumi (Fujitsu)
wrote:
>
> On Wednesday, October 5, 2022 6:42 PM Peter Smith
> wrote:
...
>
> > ==
> >
> > 5. src/backend/commands/subscriptioncmds.c - SubOpts
> >
> > @@ -89,6 +91,7 @@ typedef struct SubOpts
> > bool disableonerr;
> > char
On Thu, Nov 24, 2022 at 12:31 PM Tom Lane wrote:
> David Rowley writes:
> > After running pgindent on v2, I see it still pushes the lines out
> > quite far. If I add a new line after PageGetItemId(page, and put the
> > variable assignment away from the variable declaration then it looks a
> >
David Rowley writes:
> After running pgindent on v2, I see it still pushes the lines out
> quite far. If I add a new line after PageGetItemId(page, and put the
> variable assignment away from the variable declaration then it looks a
> bit better. It's still 1 char over the limit.
If you wanted
On Fri, 25 Nov 2022 at 04:29, Ted Yu wrote:
> Here is patch v2.
After running pgindent on v2, I see it still pushes the lines out
quite far. If I add a new line after PageGetItemId(page, and put the
variable assignment away from the variable declaration then it looks a
bit better. It's still 1
On November 24, 2022 11:07:43 AM PST, Daniel Gustafsson wrote:
>> On 24 Nov 2022, at 18:07, Nikolay Shaplov wrote:
>One option could be to redefine bail() to take the exit function as a parameter
>and have the caller pass the preferred exit handler.
>
>-bail_out(bool non_rec, const char
On Sun, Nov 20, 2022 at 11:58 PM Chris Travers wrote:
> I can start by saying I think it would be helpful (if the other issues are
> approached reasonably) to have 64-bit xids, but there is an important piece
> of context in reventing xid wraparounds that seems missing from this patch
> unless
> On 24 Nov 2022, at 18:07, Nikolay Shaplov wrote:
>
> You guys are really fast... I only think about problem, it is already
> mentioned here... Most issues I've noticed are already fixed before I was
> able
> to say something.
Thanks for looking and reviewing!
> /*
Hi,
On 2022-11-24 18:13:10 +0530, Bharath Rupireddy wrote:
> With that said, here's a small improvement I can think of, that is, to
> avoid calling LWLockWaitForVar() for the WAL insertion lock the caller
> of WaitXLogInsertionsToFinish() currently holds. Since
> LWLockWaitForVar() does a bunch
On 2022-Nov-24, Alvaro Herrera wrote:
> On 2022-Nov-24, Dimos Stamatakis wrote:
>
> > rmgr: MultiXact len (rec/tot): 54/54, tx: 248477, lsn:
> > 0/66DB82A8, prev 0/66DB8260, desc: CREATE_ID 133 offset 265 nmembers 2:
> > 248477 (nokeyupd) 248500 (keysh)
> > rmgr: Heaplen
On Thu, 24 Nov 2022 08:00:59 -0700 Thomas Kellerer wrote ---
> Pavel Stehule schrieb am 24.11.2022 um 07:03:
> > There are many Oracle users that find global indexes useful despite
> > their disadvantages.
> >
> > I have seen this mostly when the goal was to get the
On 23/11/22 23:48, Ankit Kumar Pandey wrote:
Hello,
I have questions regarding distinct operation and would be glad if
someone could help me out.
Consider the following table (mytable):
id, name
1, A
1, A
2, B
3, A
1, A
If we do /select avg(id) over (partition by name) from
On Fri, 21 Oct 2022 at 17:09, Maxim Orlov wrote:
> Reviews and opinions are very welcome!
I'm wondering whether the safest way to handle this is by creating a
new TAM called "heap64", so that all storage changes happens there.
(Obviously there are still many other changes in core, but they are
On 2022-Nov-24, Dimos Stamatakis wrote:
> Thanks for your feedback!
> I applied the patch to print more information about the error. Here’s what I
> got:
>
> 2022-11-23 20:33:03 UTC [638 test_database]: [5458] ERROR: new multixact has
> more than one updating member: 0 2[248477 (nokeyupd),
On Thu, 24 Nov 2022 at 00:19, Nathan Bossart wrote:
>
> On Sun, Nov 06, 2022 at 02:38:42PM -0800, Nathan Bossart wrote:
> > rebased
>
> another rebase for cfbot
0001 seems good to me
* I like that it sleeps forever until requested
* not sure I believe that everything it does can always be
You guys are really fast... I only think about problem, it is already
mentioned here... Most issues I've noticed are already fixed before I was able
to say something.
Nevertheless...
/*
* Bailing out is for
On Tue, 22 Nov 2022 at 18:44, Tom Lane wrote:
>
> I wrote:
> > Still wondering if there's really no CHECK_FOR_INTERRUPT anywhere
> > else in this loop.
>
> I did some experimentation using the test case Jakub presented
> to start with, and verified that that loop does respond promptly
> to
On Thu, Nov 24, 2022 at 07:03:24AM +0100, Pavel Stehule wrote:
> I can imagine a unique index on partitions without a special mark, that
> will be partitioned,
That exists since v11, as long as the index keys include the partition
keys.
> and a second variant classic index created over a
Hi,
On Thursday, August 11, 2022 7:33 PM Amit Kapila
wrote:
> On Tue, Aug 9, 2022 at 3:52 AM Euler Taveira wrote:
> >
> > On Wed, Aug 3, 2022, at 10:27 AM, Amit Kapila wrote:
> >
> > Your explanation makes sense to me. The other point to consider is
> > that there can be cases where we may
Hi,
On Monday, November 14, 2022 7:15 PM Amit Kapila
wrote:
> On Wed, Nov 9, 2022 at 12:11 PM Kyotaro Horiguchi
> wrote:
> >
> > At Wed, 10 Aug 2022 17:33:00 -0300, "Euler Taveira"
> > wrote in
> > > On Wed, Aug 10, 2022, at 9:39 AM, osumi.takami...@fujitsu.com wrote:
> > > > Minor review
On Thu, Nov 24, 2022 at 7:11 AM Tom Lane wrote:
> Daniel Gustafsson writes:
> >> On 24 Nov 2022, at 13:42, Ted Yu wrote:
> >> In _hash_pgaddtup(), it seems the indentation is off for the assertion.
>
> > Indentation is handled by applying src/tools/pgindent to the code, and
> > re-running it
On Fri, Nov 18, 2022 at 3:31 AM Cary Huang wrote:
>
> Patch: Global Unique Index
> - Optimizer, query planning and vacuum -
> Since no major modification is done on global unique index's structure and
> storage, it works in the same way as a regular partitioned index. No major
> change is
Hi,
On Tuesday, November 22, 2022 6:15 PM vignesh C wrote:
> On Mon, 14 Nov 2022 at 12:14, Amit Kapila wrote:
> >
> > Hi,
> >
> > The thread title doesn't really convey the topic under discussion, so
> > changed it. IIRC, this has been mentioned by others as well in the
> > thread.
> >
> > On
On Wednesday, November 16, 2022 12:58 PM Ian Lawrence Barwick
wrote:
> 2022年11月14日(月) 10:09 Takamichi Osumi (Fujitsu)
> :
> > I've simply rebased the patch to make it applicable on top of HEAD and
> > make the tests pass. Note there are still open pending comments and
> > I'm going to start to
On Wednesday, October 5, 2022 6:42 PM Peter Smith wrote:
> Hi Euler, a long time ago you ask me a few questions about my previous review
> [1].
>
> Here are my replies, plus a few other review comments for patch v7-0001.
Hi, thank you for your comments.
> ==
>
> 1.
Daniel Gustafsson writes:
>> On 24 Nov 2022, at 13:42, Ted Yu wrote:
>> In _hash_pgaddtup(), it seems the indentation is off for the assertion.
> Indentation is handled by applying src/tools/pgindent to the code, and
> re-running it on this file yields no re-indentation so this is in fact
Pavel Stehule schrieb am 24.11.2022 um 07:03:
> There are many Oracle users that find global indexes useful despite
> their disadvantages.
>
> I have seen this mostly when the goal was to get the benefits of
> partition pruning at runtime which turned the full table scan (=Seq
> On 23 Nov 2022, at 00:56, Andres Freund wrote:
> On 2022-11-22 23:17:44 +0100, Daniel Gustafsson wrote:
>> The attached v10 attempts to address the points raised above. Notes and
>> diagnostics are printed to stdout/stderr respectively and the TAP emitter is
>> changed to move more of the
> On 24 Nov 2022, at 13:42, Ted Yu wrote:
> In _hash_pgaddtup(), it seems the indentation is off for the assertion.
>
> Please take a look at the patch.
Indentation is handled by applying src/tools/pgindent to the code, and
re-running it on this file yields no re-indentation so this is in fact
Hi,
While working on something else, I noticed that
WaitXLogInsertionsToFinish() goes the LWLockWaitForVar() route even
for a process that's holding a WAL insertion lock. Typically, a
process holding WAL insertion lock reaches
WaitXLogInsertionsToFinish() when it's in need of WAL buffer pages for
Hi,
I was looking at :
commit d09dbeb9bde6b9faabd30e887eff4493331d6424
Author: David Rowley
Date: Thu Nov 24 17:21:44 2022 +1300
Speedup hash index builds by skipping needless binary searches
In _hash_pgaddtup(), it seems the indentation is off for the assertion.
Please take a look at
Hi, hackers!
Andres Freund recently committed his nice LWLock optimization
a4adc31f6902f6f. So I've rebased the patch on top of the current
master (PFA v5).
Regards,
Pavel Borisov,
Supabase.
v5-0001-Lockless-queue-of-LWLock-waiters.patch
Description: Binary data
> 22 нояб. 2022 г., в 17:10, Ashutosh Bapat
> написал(а):
>
> Hi Illya,
>
> On Mon, Nov 21, 2022 at 8:50 PM Ilya Gladyshev
> wrote:
>>
>> Hi everyone,
>>
>> I have made a patch that introduces support for libpq binary protocol
>> in postgres_fdw. The idea is simple, when a user knows
On 24.11.2022 06:16, Richard Guo wrote:
Regarding how to fix this problem, firstly I believe we need to evaluate
window functions in the per-tuple memory context, as the HEAD does.
When we decide we need to go into pass-through mode, I'm thinking that
we can just copy out the results of the last
Looking at a recent pg_upgrade thread I happened to notice that the check for
roles with a pg_ prefix only reports the error, not the roles it found. Other
similar checks where the user is expected to alter the old cluster typically
reports the found objects in a textfile. The attached adds
On Fri, Nov 18, 2022 at 8:46 PM Etsuro Fujita wrote:
> Attached is a patch for fixing these issues.
Here is an updated patch. In the attached, I added an assertion to
ExecInsert(). Also, I tweaked comments and test cases a little bit,
for consistency. Also, I noticed a copy-and-pasteo in a
On Thu, Nov 24, 2022 at 1:48 PM Masahiko Sawada wrote:
>
> On Wed, Nov 23, 2022 at 12:00 PM Amit Kapila wrote:
>
> Agreed not to have a test case for this.
>
> I've attached an updated patch. I've confirmed this patch works for
> all supported branches.
>
I have slightly changed the checks used
>
> Agreed not to have a test case for this.
>
> I've attached an updated patch. I've confirmed this patch works for
> all supported branches.
>
> Regards,
>
> --
> Masahiko Sawada
> Amazon Web Services: https://aws.amazon.com
>
It works for me as well. Thanks!
I've created a commitfest entry for
On 2022-Nov-23, Peter Geoghegan wrote:
> On Wed, Nov 23, 2022 at 2:54 AM Alvaro Herrera
> wrote:
> > Something like the attached. It would result in output like this:
> > WARNING: new multixact has more than one updating member: 0 2[17378
> > (keysh), 17381 (nokeyupd)]
> >
> > Then it should
On Wed, 23 Nov 2022 at 10:58, David Rowley wrote:
> My current thoughts are that it might be best to go with 0005 to start
> with. I know Melanie is working on making some changes in this area,
> so perhaps it's best to leave 0002 until that work is complete.
I tried running TPC-H @ scale 5
On Wed, 23 Nov 2022 19:45:06 +0100
Peter Eisentraut wrote:
> On 28.10.22 12:16, Jehan-Guillaume de Rorthais wrote:
[...]
> >* I wonder if encryption related fields in ParameterDescription and
> > RowDescription could be optional somehow? The former might be quite
> > large when
On Thu, 24 Nov 2022 at 21:35, Peter Eisentraut
wrote:
> My code follows the style used for parsing the decimal integers.
> Keeping that consistent is valuable I think. I think the proposed
> change makes the code significantly harder to understand. Also, what
> you are suggesting here would
Hi,
On Thu, Nov 24, 2022 at 02:37:23PM +0800, Julien Rouhaud wrote:
> On Thu, Nov 24, 2022 at 02:07:21PM +0900, Michael Paquier wrote:
> > On Wed, Nov 23, 2022 at 03:56:50PM +0800, Julien Rouhaud wrote:
> > > The depth 0 is getting used quite a lot now, maybe we should have a
> > > define for
>
On 11/23/22 16:59, Tom Lane wrote:
=?UTF-8?Q?Fr=c3=a9d=c3=a9ric_Yhuel?= writes:
On 10/24/22 17:26, Frédéric Yhuel wrote:
When studying the weird planner issue reported here [1], I came up with
the attached patch. It reduces the probability of calling
get_actual_variable_range().
This
Hi Chris,
> XID wraparound doesn't happen to healthy databases
> If you disagree, I would like to hear why.
Consider the case when you run a slow OLAP query that takes 12h to
complete and 100K TPS of fast OLTP-type queries on the same system.
The fast queries will consume all 32-bit XIDs in less
On 23.11.22 09:54, David Rowley wrote:
On Wed, 23 Nov 2022 at 02:37, Peter Eisentraut
wrote:
Here is a new patch.
This looks like quite an inefficient way to convert a hex string into an int64:
while (*ptr && isxdigit((unsigned char) *ptr))
{
int8digit
Hi Jacob,
I had validated Github by skipping the discovery mechanism and letting
the provider extension pass on the endpoints. This is just for
validation purposes.
If it needs to be supported, then need a way to send the discovery
document from extension.
Thanks,
Mahendrakar.
On Thu, 24 Nov
On Wed, Nov 23, 2022 at 12:00 PM Amit Kapila wrote:
>
> On Tue, Nov 22, 2022 at 10:33 PM Maxim Orlov wrote:
> >>
> >>
> >> Regarding the tests, the patch includes a new scenario to
> >> reproduce this issue. However, since the issue can be reproduced also
> >> by the existing scenario (with low
On 01.11.22 22:31, David G. Johnston wrote:
This is the only sentence I claim is factually incorrect, with a
suggested re-wording.
committed
74 matches
Mail list logo
