On Thu, Mar 9, 2023 at 12:42 AM Jim Nasby wrote:
>
> Doesn't the dead tuple space grow as needed? Last I looked we don't
allocate up to 1GB right off the bat.
Incorrect.
> Of course, if the patch that eliminates the 1GB vacuum limit gets
committed the situation will be even worse.
If you're
On Wed, Mar 08, 2023 at 05:21:20PM +0900, Michael Paquier wrote:
> On Wed, Mar 08, 2023 at 09:07:36AM +0100, Daniel Gustafsson wrote:
>> AFAIK a TAP test with psql_interactive is the only way to do this so that's
>> what I've implemented.
I cannot think of a better idea than what you have here,
On Tue, Mar 07, 2023 at 09:21:00PM -0800, Peter Geoghegan wrote:
> Surely your tap test should be using single user mode? Perhaps you
> missed the obnoxious HINT, that's part of the WARNING that the test
> parses? ;-)
I may be missing something, but you cannot use directly a "postgres"
command
On Thu, Mar 09, 2023 at 09:52:57AM +0530, Bharath Rupireddy wrote:
> Hm, then, +1 for v3.
Okay, thanks. Let's use that, then.
--
Michael
signature.asc
Description: PGP signature
On Wed, Mar 8, 2023 at 12:26 PM Julien Rouhaud wrote:
>
> On Sat, 4 Mar 2023, 14:13 Amit Kapila, wrote:
>>
>>
>> > For the publisher nodes, that may be something nice to support (I'm
>> > assuming it
>> > could be useful for more complex replication setups) but I'm not
>> > interested in
>> >
On Mon, Mar 06, 2023 at 04:02:25PM -0800, Jacob Champion wrote:
> On Fri, Mar 3, 2023 at 6:35 PM Michael Paquier wrote:
>> I was refreshing my mind with 0001 yesterday, and except for the two
>> parts where we need to worry about AUTH_REQ_OK being sent too early
>> and the business with gssenc,
On Thu, Mar 9, 2023 at 10:37 AM Peter Smith wrote:
>
> On Thu, Mar 9, 2023 at 3:49 PM Amit Kapila wrote:
> >
> > On Wed, Mar 8, 2023 at 8:44 PM Önder Kalacı wrote:
> > >
> > >>
> > >> I felt that once you remove the create publication/subscription/wait
> > >> for sync steps, the test execution
Here is a feature idea that emerged from a pgsql-bugs thread[1] that I
am kicking into the next commitfest. Example:
s1: \c db1
s1: CREATE TABLE t (i int);
s1: BEGIN TRANSACTION ISOLATION LEVEL SERIALIZABLE;
s1: INSERT INTO t VALUES (42);
s2: \c db2
s2: BEGIN TRANSACTION ISOLATION LEVEL
On Wed, Mar 8, 2023 at 9:20 AM Masahiko Sawada wrote:
>
> On Wed, Mar 8, 2023 at 3:30 AM Nathan Bossart
> wrote:
> >
>
> > IMO the current set of
> > trade-offs (e.g., unavoidable bloat and WAL buildup) would make this
> > feature virtually unusable for a lot of workloads, so it's probably
Here are some review comments for v6-0001
==
General.
1.
There are lots of new comments saying:
/* don't call update progress, we didn't really make any */
but is the wording "call update progress" meaningful?
Should that be written something more like:
/* No progress has been made so
On Thu, Mar 9, 2023 at 3:49 PM Amit Kapila wrote:
>
> On Wed, Mar 8, 2023 at 8:44 PM Önder Kalacı wrote:
> >
> >>
> >> I felt that once you remove the create publication/subscription/wait
> >> for sync steps, the test execution might become faster and save some
> >> time in the local execution,
On Wed, Mar 8, 2023 at 8:44 PM Önder Kalacı wrote:
>
>>
>> I felt that once you remove the create publication/subscription/wait
>> for sync steps, the test execution might become faster and save some
>> time in the local execution, cfbot and the various machines in
>> buildfarm. If the execution
st 8. 3. 2023 v 23:43 odesílatel Tom Lane napsal:
> Jacob Champion writes:
> > What I'm trying to pin down is the project's position on the reverse
> > -- binary version X and SQL version X+1 -- because that seems
> > generally unmaintainable, and I don't understand why an author would
> > pay
On Wed, 8 Mar 2023 at 21:46, Önder Kalacı wrote:
>
> Hi Vignesh C,
>
>>
>>
>> Few comments
>> 1) Maybe this change is not required:
>> fallback if no other solution is possible. If a replica identity other
>> than full is set on the publisher side, a replica identity
>> - comprising
On Thu, Mar 9, 2023 at 7:34 AM Kyotaro Horiguchi
wrote:
>
> > In short, my choice would still be simplicity here with v3, I guess.
>
> FWIW, I slightly prefer v3 for the reason I mentioned above.
Hm, then, +1 for v3.
FWIW, I quickly tried to hit that case where a single WAL record has
On Wed, Mar 08, 2023 at 05:59:13PM -0800, Andres Freund wrote:
> I now pushed a fix for the two obvious cases pointed out by Justin.
Thanks!
--
Michael
signature.asc
Description: PGP signature
At Thu, 09 Mar 2023 11:53:26 +0900 (JST), I wrote
> It turned out to be not as simple as I thought, though...
The error message and the location where the error condition is
checked don't match, but making the messages more generic may not be
helpful for users..
regards.
--
Kyotaro Horiguchi
On Thu, Mar 9, 2023 at 6:34 AM Peter Smith wrote:
>
> 4. build_replindex_scan_key
>
> >
> > Based on the discussions below, I kept as-is. I really don't want to do
> > unrelated
> > changes in this patch, as I also got several feedback for not doing it,
> >
>
> Hmm, although this code
At Thu, 09 Mar 2023 10:58:41 +0900 (JST), I wrote
> behavior for that purpose. I believe it is reasonable to make
> basebackup error-out when it encounters an in-place tablespace
> directory when TABLESPACE_MAP is activated.
It turned out to be not as simple as I thought, though...
regards.
--
On Thu, Mar 9, 2023 at 2:58 PM Kyotaro Horiguchi
wrote:
> At Wed, 8 Mar 2023 16:30:05 -0500, Robert Haas wrote
> in
> > I'm not sure how messy it's going to be to clean this up. I think each
> > tablespace really needs to go into a separate ${TSOID}.tar file,
> > because we've got tons of code
On Wed, Mar 8, 2023 at 6:17 PM Melih Mutlu wrote:
>
> On 7 Mar 2023 Tue at 04:10 Amit Kapila wrote:
>>
>> As per what I could read in this thread, most people prefer to use the
>> existing binary option rather than inventing a new way (option) to
>> binary copy in the initial sync phase. Do you
On Mon, Mar 6, 2023 18:17 PM Wang, Wei/王 威 wrote:
> On Mon, Mar 6, 2023 14:34 AM Ajin Cherian wrote:
> > Changes are in patch 1 and patch 2
>
> Thanks for updating the patch set.
>
> Here are some comments:
Here are some more comments for v-75-0002* patch:
1. In the function
Hi,
On 2023-03-09 09:36:52 +0900, Michael Paquier wrote:
> On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote:
> > On 2023-02-26 16:52:39 -0600, Justin Pryzby wrote:
> >> Also, e6927270c added ZSTD to src/bin/pg_basebackup/meson.build, but
> >> it's not in ./Makefile ?? Maybe that was
At Wed, 8 Mar 2023 16:30:05 -0500, Robert Haas wrote in
> Commit 7170f2159fb21b62c263acd458d781e2f3c3f8bb, which introduced
> in-place tablespaces, didn't make any adjustments to pg_basebackup.
> The resulting behavior is pretty bizarre.
>
> If you take a plain-format backup using pg_basebackup
Thank you to all reviewers!
This email is in answer to the three reviews
done since my last version. Attached is v2 and inline below is replies
to all the review comments.
The main difference between this version and the previous version is
that I've added a guc, buffer_usage_limit and the
On Fri, Feb 17, 2023 at 09:01:43AM -0800, Jacob Champion wrote:
> On Thu, Feb 16, 2023 at 10:59 PM Michael Paquier wrote:
>> I am adding Stephen Frost
>> in CC to see if he has any comments about all this part of the logic
>> with gssencmode.
>
> Sounds good.
Hearing nothing on this part,
On Wed, Feb 22, 2023 at 03:04:33PM -0500, Corey Huinker wrote:
> +
> +/*
> + * Return the POSIX exit code (0 to 255) that corresponds to the argument.
> + * The argument is a return code returned by wait(2) or waitpid(2), which
> + * also applies to pclose(3) and system(3).
> + */
> +int
>
On Thu, Mar 09, 2023 at 09:46:12AM +0900, Kyotaro Horiguchi wrote:
> Although I'm not strongly opposed to pfreeing them, I'm not sure I
> like the way the patch frees them. The life times of all of raw_data,
> raw_page and flags are within a block. They can be freed
> unconditionally after they
Here are my review comments for v37-0001.
==
General - should/must.
1.
In my previous review [1] (comment #1) I wrote that only some of the
"should" were misleading and gave examples where to change. But I
didn't say that *every* usage of that word was wrong, so your global
replace of
On Thu, Mar 9, 2023 at 1:16 PM Dean Rasheed wrote:
> On Wed, 8 Mar 2023 at 23:24, Thomas Munro wrote:
> > ... But Oracle, and I think
> > several other analytics-focused SQL systems, can do it in a very easy
> > built-in way. I think to get at that you probably need the t CDF, and
> > in
At Wed, 8 Mar 2023 20:18:06 +0530, Bharath Rupireddy
wrote in
> On Wed, Mar 8, 2023 at 4:23 PM Michael Paquier wrote:
> >
> > On Wed, Mar 08, 2023 at 04:01:56PM +0530, Bharath Rupireddy wrote:
> > > I understand that performance is critical here but we need to ensure
> > > memory is used
On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote:
> On 2023-02-26 16:52:39 -0600, Justin Pryzby wrote:
>> Also, e6927270c added ZSTD to src/bin/pg_basebackup/meson.build, but
>> it's not in ./Makefile ?? Maybe that was for consistency with other
>> places, or pre-emptive in case the
Hi,
On 2023-03-08 12:55:34 +0100, Drouvot, Bertrand wrote:
> On 3/7/23 7:47 PM, Andres Freund wrote:
> > On 2023-03-07 13:43:28 -0500, Melanie Plageman wrote:
> > > > Now I've a second thought: what do you think about resetting the
> > > > related number
> > > > of operations and *_time fields
On Thu, Mar 09, 2023 at 12:39:08AM +0100, Tomas Vondra wrote:
> IMO we should fix that. We have a bunch of buildfarm members running on
> Ubuntu 18.04 (or older) - it's true none of them seems to be running TAP
> tests. But considering how trivial the fix is ...
>
> Barring objections, I'll push
On Thu, Mar 09, 2023 at 12:27:47AM +, Dean Rasheed wrote:
> On Thu, 9 Mar 2023 at 00:13, Nathan Bossart wrote:
>> I'm also wondering about whether we need the isinf() checks. IIUC that
>> should never happen, but maybe you added that "just in case."
>
> I copied those from dtanh(),
On Thu, 9 Mar 2023 at 00:13, Nathan Bossart wrote:
>
> On Wed, Mar 08, 2023 at 11:29:12PM +, Dean Rasheed wrote:
> > On Wed, 8 Mar 2023 at 20:11, Nathan Bossart
> > wrote:
> >> The man pages for these seem to indicate that underflow can occur. Do we
> >> need to check for that?
> >
> > No,
Hi,
On 2023-03-08 11:42:31 -0600, Jim Nasby wrote:
> On 3/2/23 1:36 AM, Masahiko Sawada wrote:
>
> > > > > For example, I guess we will need to take care of changes of
> > > > > maintenance_work_mem. Currently we initialize the dead tuple space at
> > > > > the beginning of lazy vacuum, but
On Wed, Mar 08, 2023 at 05:23:48PM +0100, Peter Eisentraut wrote:
> The "cd" command needs to be moved after the meson commands, and the meson
> commands need to have a -C builddir option.
Still that's not mandatory, is it? The compile and test commands of
meson work as well if you are located
On Wed, Mar 8, 2023 at 10:49 AM Nathan Bossart wrote:
>
> Is there any reason to disallow 0 for the sleep argument? I often use
> commands like "\watch .1" to run statements repeatedly with very little
> time in between, and I'd use "\watch 0" instead if it was available.
>
Yes, that makes
On Wed, 8 Mar 2023 at 23:24, Thomas Munro wrote:
>
> No comment on the maths, but I'm pretty sure we won't need a fallback
> implementation. That stuff goes back to the math libraries of 80s
> Unixes, even though it didn't make it into C until '99. I just
> checked the man pages for all our
Hi,
On 2023-02-06 13:02:05 -0800, Andres Freund wrote:
> I didn't quite feel confident pushing a fix for this just before a minor
> release, so I'll push once the minor releases are tagged. A quite minimal fix
> to GetFullRecentGlobalXmin() in 12-13 (returning FirstNormalTransactionId if
> epoch
On Wed, Mar 08, 2023 at 11:29:12PM +, Dean Rasheed wrote:
> On Wed, 8 Mar 2023 at 20:11, Nathan Bossart wrote:
>> The man pages for these seem to indicate that underflow can occur. Do we
>> need to check for that?
>
> No, I don't think so. The docs indicate that if an underflow occurs,
>
On 3/8/23 20:20, Daniel Gustafsson wrote:
>> On 8 Mar 2023, at 18:55, Christoph Berg wrote:
>
>> 18.04 will be EOL in a few weeks so it might be ok to just say it's
>> not supported, but removing the input file manually after calling lz4
>> would be an easy fix.
>
> Is it reasonable to expect
On Wed, 8 Mar 2023 at 20:11, Nathan Bossart wrote:
>
> On Mon, Feb 27, 2023 at 12:54:35PM +, Dean Rasheed wrote:
> > + /*
> > + * For erf, we don't need an errno check because it never overflows.
> > + */
>
> > + /*
> > + * For erfc, we don't need an errno check because
On Tue, Feb 28, 2023 at 1:54 AM Dean Rasheed wrote:
> Now that we have random_normal(), it seems like it would be useful to
> add the error functions erf() and erfc(), which I think are
> potentially useful to the people who will find random_normal() useful,
> and possibly others.
>
> An
On Wed, Mar 8, 2023 at 11:40 AM Robert Haas wrote:
> On Wed, Mar 8, 2023 at 2:30 PM Jacob Champion wrote:
> > I don't think I necessarily like that option better than SASL-style,
> > but hopefully that clarifies it somewhat?
>
> Hmm, yeah, I guess that's OK.
Okay, cool.
> I still don't love
Jacob Champion writes:
> What I'm trying to pin down is the project's position on the reverse
> -- binary version X and SQL version X+1 -- because that seems
> generally unmaintainable, and I don't understand why an author would
> pay that tax if they could just avoid it by bailing out entirely.
On Wed, 22 Feb 2023 at 14:14, Matthias van de Meent
wrote:
>
> On Wed, 22 Feb 2023 at 13:15, Tomas Vondra
> wrote:
> >
> > On 2/20/23 19:15, Matthias van de Meent wrote:
> > > Thanks. Based on feedback, attached is v2 of the patch, with as
> > > significant changes:
> > >
> > > - We don't store
On Wed, Mar 8, 2023 at 1:47 PM Tom Lane wrote:
> Pavel's proposed check would break that too. There's going to be some
> interval where the SQL definitions are not in sync with the .so version,
> so you really want the .so to support at least two versions' worth of
> SQL objects.
I think we're
On 2023-03-08 We 08:49, Nazir Bilal Yavuz wrote:
Hi,
On Mon, 6 Mar 2023 at 18:30, Andrew Dunstan wrote:
There are two separate issues here, but let's deal with the Windows issue.
Attached is the log output and also a listing of the runpython directory in the
build directory.
Thanks for
On 2023-03-08 We 14:22, Andres Freund wrote:
Hi,
On 2023-03-02 17:35:26 -0500, Andrew Dunstan wrote:
On 2023-03-02 Th 17:06, Andres Freund wrote:
Hi
On 2023-03-02 17:00:47 -0500, Andrew Dunstan wrote:
On 2023-03-01 We 16:32, Andres Freund wrote:
This is now working
on my MSVC test rig
On Wed, Feb 15, 2023 at 10:13:17AM -0800, Nathan Bossart wrote:
> On Tue, Feb 14, 2023 at 07:32:56PM -0600, Justin Pryzby wrote:
>> On Mon, Feb 13, 2023 at 08:18:52PM -0800, Nathan Bossart wrote:
>>> I'm curious why you chose to make this a string instead of an enum. There
>>> might be little
On 08.03.2023 07:28, Thomas Munro wrote:
Sorry, I was confused; please ignore that part. We don't have a copy
of the control file anywhere else. (Perhaps we should, but that could
be a separate topic.)
That’s all right! Fully agreed that this is a possible separate topic.
Sincerely yours,
On Tue, Mar 7, 2023 at 2:40 AM Aleksander Alekseev
wrote:
> So far I only have a couple of nitpicks, mostly regarding the code coverage
> [1]:
Yeah, I need to work on error cases and their coverage in general.
There are more cases that I need to reject as well (marked TODO).
> +Datum
>
Jacob Champion writes:
> On Wed, Mar 8, 2023 at 11:11 AM Pavel Stehule wrote:
>> installation from rpm or deb packages
> Right, but I thought the safe order for a downgrade was to issue the
> SQL downgrade first (thus putting the system back into the
> post-upgrade state), and only then
On 2023-03-05 Su 22:18, Amit Langote wrote:
On Tue, Feb 28, 2023 at 8:36 PM Amit Langote wrote:
On Mon, Feb 27, 2023 at 4:45 PM Amit Langote wrote:
On Tue, Feb 21, 2023 at 2:25 AM Andres Freund wrote:
Evaluating N expressions for a json table isn't a good approach, both memory
and CPU
On Tue, Feb 7, 2023 at 10:16 AM Jacob Champion wrote:
> Even more concretely, here's a draft patch. There's no nuance --
> setting dump_version affects all past versions of the extension, and
> it can't be turned off at restore time. So extensions opting in would
> have to be written to be
On Mon, Feb 13, 2023 at 10:06:27AM +0100, Drouvot, Bertrand wrote:
> Please find attached a patch proposal to $SUBJECT: it would allow to simplify
> even more the work done to generate pg_stat_get_xact*() functions with Macros.
>
> This is a follow up for [1] where it has been suggested
> to get
Commit 7170f2159fb21b62c263acd458d781e2f3c3f8bb, which introduced
in-place tablespaces, didn't make any adjustments to pg_basebackup.
The resulting behavior is pretty bizarre.
If you take a plain-format backup using pg_basebackup -Fp, then the
files in the in-place tablespace are backed up, but
Greetings,
* Chris Travers (chris.trav...@gmail.com) wrote:
> From the documentation, the primary threat model of TDE is to prevent
> decryption of data from archived wal segments (and data files), for example
> on a backup system. While there are other methods around this problem to
> date,
On Thu, 9 Mar 2023 at 01:34, Alvaro Herrera wrote:
> David, do you intend to continue to be involved in reviewing this one?
Yes. I'm currently trying to make a few Bitmapset improvements which
include the change made in this thread's 0001 patch over on [1].
For the main patch, I've been
On Wed, Mar 8, 2023 at 11:22 AM Pavel Stehule wrote:
> There is agreement - I call this check from functions.
I think pg_auto_failover does this too, or at least used to.
Timescale does strict compatibility checks as well. It's not entirely
comparable to your implementation, though.
--Jacob
On Wed, Mar 8, 2023 at 11:11 AM Pavel Stehule wrote:
> installation from rpm or deb packages
Right, but I thought the safe order for a downgrade was to issue the
SQL downgrade first (thus putting the system back into the
post-upgrade state), and only then replacing the packages with prior
On Wed, Mar 8, 2023 at 11:18 AM Tom Lane wrote:
>
> Jacob Champion writes:
> > On Wed, Mar 8, 2023 at 10:49 AM Tom Lane wrote:
> >> This is a bad idea. How will you do extension upgrades, if the new .so
> >> won't run till you apply the extension upgrade script but the old .so
> >>
> I wonder if a solution to this problem might be to provide some kind of a
> version map file. Let's suppose that the map file is a bunch of lines of the
> form
> X Y Z, where X, Y, and Z are version numbers. The semantics could be: we (the
> extension authors) promise that if you want to
On Mon, Feb 27, 2023 at 12:54:35PM +, Dean Rasheed wrote:
> + /*
> + * For erf, we don't need an errno check because it never overflows.
> + */
> + /*
> + * For erfc, we don't need an errno check because it never overflows.
> + */
The man pages for these seem to
Hi,
On 2023-02-07 16:56:55 -0500, Robert Haas wrote:
> On Wed, Feb 1, 2023 at 4:02 PM Andres Freund wrote:
> > > + /* Is the use of a password mandatory? */
> > > + must_use_password = MySubscription->passwordrequired &&
> > > + !superuser_arg(MySubscription->owner);
> >
> >
On Wed, Mar 8, 2023 at 2:30 PM Jacob Champion wrote:
> > No, that's the opposite, and exactly the point I'm trying to make. In
> > that case, the SERVER says what it's willing to accept, and the CLIENT
> > decides whether or not to provide that. In your proposal, the client
> > tells the server
On Tue, Mar 7, 2023 at 11:04 AM Robert Haas wrote:
>
> On Thu, Feb 9, 2023 at 4:46 PM Jacob Champion wrote:
> > On 2/6/23 08:22, Robert Haas wrote:
> > > I don't think that's quite the right concept. It seems to me that the
> > > client is responsible for informing the server of what the
On 2023-03-08 13:44:32 -0500, Melanie Plageman wrote:
> However, I am concerned that, while unlikely, this could be flakey.
> Something could happen to force all of those blocks out of shared
> buffers (even though they were just read in) before we hit them.
You could make the test query a simple
st 8. 3. 2023 v 20:17 odesílatel Tom Lane napsal:
> Jacob Champion writes:
> > On Wed, Mar 8, 2023 at 10:49 AM Tom Lane wrote:
> >> This is a bad idea. How will you do extension upgrades, if the new .so
> >> won't run till you apply the extension upgrade script but the old .so
> >>
Hi,
On 2023-03-02 17:35:26 -0500, Andrew Dunstan wrote:
> On 2023-03-02 Th 17:06, Andres Freund wrote:
> > Hi
> >
> > On 2023-03-02 17:00:47 -0500, Andrew Dunstan wrote:
> > > On 2023-03-01 We 16:32, Andres Freund wrote:
> > > > > This is now working
> > > > > on my MSVC test rig (WS2019,
Hi,
On 2023-03-08 09:41:57 -0500, Andrew Dunstan wrote:
> On 2023-03-08 We 08:57, Andrew Dunstan wrote:
> > On 2023-03-07 Tu 20:29, Andres Freund wrote:
> > > On 2023-03-07 15:47:54 -0500, Andrew Dunstan wrote:
> > > Here's a prototype for that.
> > >
> > > It adds an install-test-files target,
> On 8 Mar 2023, at 18:55, Christoph Berg wrote:
> 18.04 will be EOL in a few weeks so it might be ok to just say it's
> not supported, but removing the input file manually after calling lz4
> would be an easy fix.
Is it reasonable to expect that this version of LZ4 can/will appear on any
other
st 8. 3. 2023 v 19:49 odesílatel Tom Lane napsal:
> Pavel Stehule writes:
> > I try to write a safeguard check that ensures the expected extension
> > version for an extension library.
>
> This is a bad idea. How will you do extension upgrades, if the new .so
> won't run till you apply the
Jacob Champion writes:
> On Wed, Mar 8, 2023 at 10:49 AM Tom Lane wrote:
>> This is a bad idea. How will you do extension upgrades, if the new .so
>> won't run till you apply the extension upgrade script but the old .so
>> malfunctions as soon as you do?
> Which upgrade paths allow you to have
st 8. 3. 2023 v 20:04 odesílatel Jacob Champion
napsal:
> On Wed, Mar 8, 2023 at 10:49 AM Tom Lane wrote:
> > This is a bad idea. How will you do extension upgrades, if the new .so
> > won't run till you apply the extension upgrade script but the old .so
> > malfunctions as soon as you do?
>
>
On Wed, Mar 8, 2023 at 10:49 AM Tom Lane wrote:
> This is a bad idea. How will you do extension upgrades, if the new .so
> won't run till you apply the extension upgrade script but the old .so
> malfunctions as soon as you do?
Which upgrade paths allow you to have an old .so with a new version
On Sat, Mar 4, 2023 at 8:57 AM Justin Pryzby wrote:
> pryzbyj=# CREATE TABLE t1 AS SELECT i,array_agg(j) FROM
> generate_series(1,444)i,generate_series(1,9)j GROUP BY 1;
> $ ./src/bin/pg_dump/pg_dump -d pryzbyj -Fc -Z zstd:long=1 |wc -c
> 82023
> $ ./src/bin/pg_dump/pg_dump -d pryzbyj -Fc -Z
cfbot's Windows build wasn't happy with a couple of casts. I applied a
fix similar to c6a43c2 in v2. The patch is still very much a work in
progress.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
>From 055717233c47518ae48119938ebd203cc55f7f3c Mon Sep 17 00:00:00 2001
From:
+1 for adding an iteration count argument to \watch.
+ char *opt_end;
+ sleep = strtod(opt, _end);
+ if (sleep <= 0 || *opt_end)
+ {
+ pg_log_error("Watch period must be positive
Pavel Stehule writes:
> I try to write a safeguard check that ensures the expected extension
> version for an extension library.
This is a bad idea. How will you do extension upgrades, if the new .so
won't run till you apply the extension upgrade script but the old .so
malfunctions as soon as
On Tue, Mar 7, 2023 at 2:47 PM Andres Freund wrote:
>
> Hi,
>
> LGTM. The only comment I have is that a small test wouldn't hurt... Compared
> to the other things it should be fairly easy...
So, I have attached an updated patchset which adds a test for hits. Since
there is only one call site
On Wed, 2023-03-08 at 07:21 +0100, Peter Eisentraut wrote:
> On 04.03.23 19:29, Jeff Davis wrote:
> > It looks like the way you've handled this is by inserting the
> > collation
> > with collprovider=icu even if built without ICU support. I think
> > that's
> > a new case, so we need to make sure
James Coleman wrote:
> On Mon, Feb 6, 2023 at 11:39 AM Antonin Houska wrote:
> Attached is v9.
ok, I've changed the status to RfC
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
Re: Tomas Vondra
> Add LZ4 compression to pg_dump
This broke the TAP tests on Ubuntu 18.04 (bionic):
[17:06:45.513](0.000s) ok 1927 - compression_lz4_custom: should not dump
test_table with 4-row INSERTs
# Running: pg_dump --jobs=2 --format=directory --compress=lz4:1
On Wed, 2023-03-08 at 17:30 +0100, Peter Eisentraut wrote:
> So should we withdraw the patch from the commit fest?
Withdrawn. If someone else is interested we can still pursue some
improvements.
Regards,
Jeff Davis
On 3/2/23 1:36 AM, Masahiko Sawada wrote:
For example, I guess we will need to take care of changes of
maintenance_work_mem. Currently we initialize the dead tuple space at
the beginning of lazy vacuum, but perhaps we would need to
enlarge/shrink it based on the new value?
Doesn't the dead
Hi
I try to write a safeguard check that ensures the expected extension
version for an extension library.
Some like
const char *expected_extversion = "2.5";
...
extoid = getExtensionOfObject(ProcedureRelationId, fcinfo->flinfo->fn_oid));
extversion = get_extension_version(extoid);
if
On 01.03.23 21:30, Jeff Davis wrote:
On Wed, 2023-03-01 at 11:43 -0800, Jacob Champion wrote:
I work around it by manually setting -Dextra_lib_dirs. I just tried
doing that with ICU 72, and it worked without a patch. Hopefully that
helps some?
Yes, works, thank you.
Obviously we'd like a
On 03.03.23 12:12, Michael Paquier wrote:
+
+meson setup -Db_coverage=true ... OTHER OPTIONS ... builddir/
+cd builddir/
+meson compile
+meson test
+ninja coverage-html
+
The "cd" command needs to be moved after the meson commands, and the
meson commands need to have a -C builddir option. So
Hi Vignesh C,
>
> Few comments
> 1) Maybe this change is not required:
> fallback if no other solution is possible. If a replica identity other
> than full is set on the publisher side, a replica
> identity
> - comprising the same or fewer columns must also be set on the subscriber
>
st 8. 3. 2023 v 16:35 odesílatel Dmitry Dolgov <9erthali...@gmail.com>
napsal:
> > On Wed, Mar 08, 2023 at 08:31:07AM +0100, Pavel Stehule wrote:
> > pá 3. 3. 2023 v 21:19 odesílatel Dmitry Dolgov <9erthali...@gmail.com>
> > napsal:
> >
> > > > On Tue, Feb 28, 2023 at 06:12:50AM +0100, Pavel
On 08.03.23 15:18, Laurenz Albe wrote:
On Fri, 2023-03-03 at 13:45 +0100, Peter Eisentraut wrote:
Ok, here is a version with an initdb option and also a createdb option
(to expose the CREATE DATABASE option).
You can mess with people by setting up your databases like this:
initdb -D data
Hi,
On Wednesday, March 8, 2023 11:54 AM From: wangw.f...@fujitsu.com
wrote:
> Attach the new patch.
Thanks for sharing v6 ! Few minor comments for the same.
(1) commit message
The old function name 'is_skip_threshold_change' is referred currently. We need
to update it to
> On Wed, Mar 08, 2023 at 08:31:07AM +0100, Pavel Stehule wrote:
> pá 3. 3. 2023 v 21:19 odesílatel Dmitry Dolgov <9erthali...@gmail.com>
> napsal:
>
> > > On Tue, Feb 28, 2023 at 06:12:50AM +0100, Pavel Stehule wrote:
> > >
> > > fresh rebase
> >
> > I'm continuing to review, this time going
On 02.01.23 22:32, Daniel Verite wrote:
This is a follow-up to commit d2a44904 from the 2022-11 CF [1]
The TAP tests were left out with the suggestion to use Perl instead of
cat (Unix) / findstr (Windows) as the program to pipe into.
PFA a patch implementing that suggestion.
The perl binary
On Wed, Mar 8, 2023 at 4:23 PM Michael Paquier wrote:
>
> On Wed, Mar 08, 2023 at 04:01:56PM +0530, Bharath Rupireddy wrote:
> > I understand that performance is critical here but we need to ensure
> > memory is used wisely. Therefore, I'd still vote to free at least the
> > major contributors
On 2023-03-08 We 08:57, Andrew Dunstan wrote:
On 2023-03-07 Tu 20:29, Andres Freund wrote:
Hi,
On 2023-03-07 15:47:54 -0500, Andrew Dunstan wrote:
On 2023-03-07 Tu 14:37, Andres Freund wrote:
The failures are like this:
+ERROR: extension "dummy_index_am" is not available
+DETAIL: Could
Hi,
On Wed, 8 Mar 2023 at 16:57, Andrew Dunstan wrote:
> So if I understand this right, the way to use this would be something like:
>
>
> local $ENV{DESTDIR} = $installdir;
>
> run_log("meson compile -C $pgsql install-test-files");
>
>
> Is that right? I did that but it didn't work :-(
1 - 100 of 134 matches
Mail list logo
