Re: ALTER COLUMN ... SET EXPRESSION to alter stored generated column's expression

Hi Amul, On Wed, Aug 2, 2023 at 4:06 PM Amul Sul wrote: > Hi, > > Currently, we have an option to drop the expression of stored generated > columns > as: > > ALTER [ COLUMN ] column_name DROP EXPRESSION [ IF EXISTS ] > > But don't have support to update that expression. The attached patch >

Re: subscription/015_stream sometimes breaks

On Wed, Aug 23, 2023 at 1:31 PM Alvaro Herrera wrote: > > On 2023-Aug-23, Zhijie Hou (Fujitsu) wrote: > > > [1]-- > > LWLockAcquire(LogicalRepWorkerLock, LW_SHARED); > > > > workers = logicalrep_workers_find(MyLogicalRepWorker->subid, > > true); > >

Re: [PoC] pg_upgrade: allow to upgrade publisher node

Hi Kuroda-san FYI, the v24-0003 tests for pg_upgrade did not work for me: ~~~ # +++ tap check in src/bin/pg_upgrade +++ t/001_basic.pl .. ok t/002_pg_upgrade.pl . ok t/003_logical_replication_slots.pl .. 7/? # Failed test 'run of pg_upgrade of old

Re: pg_stat_get_backend_subxact() and backend IDs?

On Wed, Aug 23, 2023 at 07:32:06PM -0700, Nathan Bossart wrote: > On Thu, Aug 24, 2023 at 10:22:49AM +0900, Ian Lawrence Barwick wrote: >> Looking at the code, this is happening because >> "pgstat_fetch_stat_local_beentry()" >> expects to be passed the backend ID as an integer representing a

Re: [PoC] pg_upgrade: allow to upgrade publisher node

On Thu, Aug 24, 2023 at 7:55 AM Peter Smith wrote: > > == > src/bin/pg_upgrade/info.c > > 4. get_logical_slot_infos > > +/* > + * get_logical_slot_infos() > + * > + * Higher level routine to generate LogicalSlotInfoArr for all databases. > + */ > +void > +get_logical_slot_infos(ClusterInfo

Re: Oversight in reparameterize_path_by_child leading to executor crash

On Thu, Aug 24, 2023 at 1:44 AM Tom Lane wrote: > Richard Guo writes: > > If we go with the "tablesample scans can't be reparameterized" approach > > in the back branches, I'm a little concerned that what if we find more > > cases in the futrue where we need modify RTEs for reparameterization.

Re: pg_stat_get_backend_subxact() and backend IDs?

On Thu, Aug 24, 2023 at 10:22:49AM +0900, Ian Lawrence Barwick wrote: > Looking at the code, this is happening because > "pgstat_fetch_stat_local_beentry()" > expects to be passed the backend ID as an integer representing a 1-based index > referring to "localBackendStatusTable", but

Re: [PoC] pg_upgrade: allow to upgrade publisher node

Thanks for the updated patches. Here are some review comments for the patch v24-0002 == doc/src/sgml/ref/pgupgrade.sgml 1. + + + All slots on the old cluster must be usable, i.e., there are no slots + whose wal_status is lost (see + ). + + + +

Re: pgbench: allow to exit immediately when any client is aborted

On Thu, 24 Aug 2023 09:15:51 +0900 (JST) Tatsuo Ishii wrote: > >> I start to think this behavior is ok and consistent with previous > >> behavior of pgbench because serialization (and dealock) errors have > >> been treated specially from other types of errors, such as accessing > >> non existing

Re: In-placre persistance change of a relation

Thank you for looking this! At Mon, 14 Aug 2023 12:38:48 -0700, Nathan Bossart wrote in > I think there are some good ideas here. I started to take a look at the > patches, and I've attached a rebased version of the patch set. Apologies > if I am repeating any discussions from upthread. > >

pg_stat_get_backend_subxact() and backend IDs?

Hi I was playing around with "pg_stat_get_backend_subxact()" (commit 10ea0f924) and see it emits NULL values for some backends, e.g.: postgres=# \pset null NULL Null display is "NULL". postgres=# SELECT id, pg_stat_get_backend_pid(id), s.*,

Re: pg_rewind WAL segments deletion pitfall

At Wed, 23 Aug 2023 13:44:52 +0200, Alexander Kukushkin wrote in > On Tue, 22 Aug 2023 at 07:32, Michael Paquier wrote: > > I don't like much this patch. While it takes correctly advantage of > > the backward record read logic from SimpleXLogPageRead() able to > > handle correctly timeline

Re: Let's make PostgreSQL multi-threaded

On Mon, Jun 12, 2023 at 5:17 PM Heikki Linnakangas wrote: > On 10/06/2023 21:01, Hannu Krosing wrote: > > On Mon, Jun 5, 2023 at 4:52 PM Heikki Linnakangas > wrote: > > <<>> > > > * The backend code would be more complex. > > -- this is still the case > > I don't quite buy that. A

Re: pgbench: allow to exit immediately when any client is aborted

>> I start to think this behavior is ok and consistent with previous >> behavior of pgbench because serialization (and dealock) errors have >> been treated specially from other types of errors, such as accessing >> non existing tables. However, I suggest to add more sentences to the >> explanation

Re: pg_upgrade - a function parameter shadows global 'new_cluster'

On Wed, Aug 23, 2023 at 6:00 PM Daniel Gustafsson wrote: > > On 23 Aug 2023, at 03:28, Peter Smith wrote: > > > PSA a small patch to remove the unnecessary parameter, and so eliminate > this shadowing. > > Agreed, applied. Thanks! > > Thanks for pushing! -- Kind Regards, Peter Smith.

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

Hi, On 2023-08-23 18:32:26 -0400, Tom Lane wrote: > Andres Freund writes: > > There are other potential uses for libpq in pg_regress though - I'd e.g. > > like > > to have a "monitoring" session open, which we could use to detect that the > > server crashed (by waiting for the FD to be become

Re: meson uses stale pg_config_paths.h left over from make

On Thu, 24 Aug 2023 at 00:52, David Rowley wrote: > Are there any objections to the attached being applied? Pushed. David

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

Andres Freund writes: > On 2023-08-23 17:55:53 -0400, Tom Lane wrote: >> The trouble with that approach is that in "make installcheck", we >> don't really want to assume we know what the installed libpq's default >> connection parameters are. So we don't explicitly know where that >> libpq will

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

Hi, On 2023-08-23 17:55:53 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2023-08-23 17:02:51 -0400, Tom Lane wrote: > >> ... unless we hit problems with, say, a different default port number or > >> socket path compiled into one copy vs. the other? That seems like it's > >> probably a

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

Andres Freund writes: > On 2023-08-23 17:02:51 -0400, Tom Lane wrote: >> ... unless we hit problems with, say, a different default port number or >> socket path compiled into one copy vs. the other? That seems like it's >> probably a "so don't do that" case, though. > If we were to find such a

Re: Fix error handling in be_tls_open_server()

> On 23 Aug 2023, at 23:47, Jacob Champion wrote: > > On Wed, Aug 23, 2023 at 6:23 AM Daniel Gustafsson wrote: >> This has the smell of a theoretical problem, I can't really imagine a >> certificate where which would produce this. Have you been able to trigger >> it? >> >> Wouldn't a better

Re: Fix error handling in be_tls_open_server()

On Wed, Aug 23, 2023 at 6:23 AM Daniel Gustafsson wrote: > This has the smell of a theoretical problem, I can't really imagine a > certificate where which would produce this. Have you been able to trigger it? > > Wouldn't a better fix be to error out on len == -1 as in the attached, maybe > with

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

Hi, On 2023-08-23 23:55:15 +0300, Nazir Bilal Yavuz wrote: > On Wed, 23 Aug 2023 at 09:58, Andres Freund wrote: > > I'm hoping to push this fairly soon, as I'll be on vacation the last week of > > August. I'll be online intermittently though, if there are issues, I can > > react > > (very

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

Hi, On 2023-08-23 17:02:51 -0400, Tom Lane wrote: > Daniel Gustafsson writes: > > On 23 Aug 2023, at 21:22, Andres Freund wrote: > >> I think there's more effective ways to make this cheaper. The basic thing > >> would be to use libpq instead of forking of psql to make a connection > >> check.

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

> On 23 Aug 2023, at 23:02, Tom Lane wrote: > > Daniel Gustafsson writes: >> On 23 Aug 2023, at 21:22, Andres Freund wrote: >>> I think there's more effective ways to make this cheaper. The basic thing >>> would be to use libpq instead of forking of psql to make a connection >>> check. > >> I

Re: PostgreSQL 16 release announcement draft

On Thu, 24 Aug 2023 at 05:55, Jonathan S. Katz wrote: > We could add something about 1349d2790 -- do you have suggested wording? I think it's worth a mention. See the text added in square brackets below: PostgreSQL 16 improves the performance of existing PostgreSQL functionality through new

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

Daniel Gustafsson writes: > On 23 Aug 2023, at 21:22, Andres Freund wrote: >> I think there's more effective ways to make this cheaper. The basic thing >> would be to use libpq instead of forking of psql to make a connection >> check. > I had it in my head that not using libpq in pg_regress was

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

Hi, Thanks for the patch! On Wed, 23 Aug 2023 at 09:58, Andres Freund wrote: > I'm hoping to push this fairly soon, as I'll be on vacation the last week of > August. I'll be online intermittently though, if there are issues, I can react > (very limited connectivity for middday Aug 29th - midday

Re: BUG #18059: Unexpected error 25001 in stored procedure

I wrote: > I started to code this, and immediately noticed that transformStmt() > already has a companion function analyze_requires_snapshot() that > returns "true" in the cases of interest ... except that it does > not return true for T_CallStmt. Perhaps that was intentional to > begin with, but

Re: False "pg_serial": apparent wraparound” in logs

Hi, I dug a bit into this and what looks to be happening is the comparison of the page containing the latest cutoff xid could falsely be reported as in the future of the last page number because the latest page number of the Serial slru is only set when the page is initialized [1]. So under the

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

> On 23 Aug 2023, at 21:22, Andres Freund wrote: > On 2023-08-23 14:48:26 +0200, Daniel Gustafsson wrote: >> I'll do another pass, but below are a few small comments so far. >> >> I don't know Windows to know the implications, but should the below file have >> some sort of warning about not

Make documentation builds reproducible

Somewhere at PGCon, I forgot exactly where, maybe in the same meeting where we talked about getting rid of distprep, we talked about that the documentation builds are not reproducible (in the sense of https://reproducible-builds.org/). This is easily fixable, the fix is available upstream

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

Hi, On 2023-08-23 14:48:26 +0200, Daniel Gustafsson wrote: > > On 23 Aug 2023, at 08:58, Andres Freund wrote: > > > I'm hoping to push this fairly soon, as I'll be on vacation the last week of > > August. I'll be online intermittently though, if there are issues, I can > > react > > (very

Re: Make all Perl warnings fatal

On 21.08.23 17:51, Andrew Dunstan wrote: Still, I guess that might not matter too much since apart from plperl we only use perl for building / testing. Regarding the dangers mentioned, I guess we can undo it if it proves a nuisance. +1 to getting rid if the unnecessary call to

Re: PostgreSQL 16 release announcement draft

On 8/23/23 8:02 AM, David Rowley wrote: On Wed, 23 Aug 2023 at 22:21, jian he wrote: PostgreSQL 16 improves the performance of existing PostgreSQL functionality through new query planner optimizations. In this latest release, the query planner can parallelize `FULL` and `RIGHT` joins,

Re: Oversight in reparameterize_path_by_child leading to executor crash

Richard Guo writes: > If we go with the "tablesample scans can't be reparameterized" approach > in the back branches, I'm a little concerned that what if we find more > cases in the futrue where we need modify RTEs for reparameterization. > So I spent some time seeking and have managed to find

Re: using SysCacheGetAttrNotNull in place of heap_getattr

Alvaro Herrera writes: > I was about to push a quick patch to replace the use of heap_getattr() > in get_primary_key_attnos() with SysCacheGetAttrNotNull(), because that > makes the code a few lines shorter and AFAICS there's no downside. > However, I realized that the commit that added the

Re: PG 16 draft release notes ready

On Tue, 2023-08-22 at 22:23 -0400, Bruce Momjian wrote: > > I notice that this item is still listed: > > > >  * Determine the ICU default locale from the environment (Jeff > > Davis) > > > > But that was reverted as part of 2535c74b1a. > > The original commit is: > > Author: Jeff Davis

Re: add timing information to pg_upgrade

On Tue, Aug 22, 2023 at 07:06:23AM -0700, Nathan Bossart wrote: > On Tue, Aug 22, 2023 at 11:49:33AM +0200, Peter Eisentraut wrote: >> Let's change MESSAGE_WIDTH to 62 in v16, and then pursue the larger >> restructuring leisurely. > > Sounds good. I plan to commit this within the next couple of

Re: Oversight in reparameterize_path_by_child leading to executor crash

On Wed, Aug 23, 2023 at 11:07 AM Richard Guo wrote: > > > On Tue, Aug 22, 2023 at 10:39 PM Tom Lane wrote: >> >> Richard Guo writes: >> > I'm wondering if we can instead adjust the 'inner_req_outer' in >> > create_nestloop_path before we perform the check to work around this >> > issue for the

Re: pgbench: allow to exit immediately when any client is aborted

On Sat, 19 Aug 2023 19:51:56 +0900 (JST) Tatsuo Ishii wrote: > > I have tested the v4 patch with default_transaction_isolation = > > 'repeatable read'. > > > > pgbench --exit-on-abort -N -p 11002 -c 10 -T 30 test > > pgbench (17devel, server 15.3) > > starting vacuum...end. > > transaction

Re: [PATCH] Add function to_oct

On Tue, Aug 22, 2023 at 04:57:02PM +0200, Peter Eisentraut wrote: > On 22.08.23 16:26, Nathan Bossart wrote: >> > I don't understand the reason for this handling of negative values. I >> > would >> > expect that, say, to_hex(-1234) would return '-' || to_hex(1234). >> For this patch set, I was

using SysCacheGetAttrNotNull in place of heap_getattr

I was about to push a quick patch to replace the use of heap_getattr() in get_primary_key_attnos() with SysCacheGetAttrNotNull(), because that makes the code a few lines shorter and AFAICS there's no downside. However, I realized that the commit that added the function (d435f15fff3c) did not make

Re: Unlogged relations and WAL-logging

On 07/07/2023 18:21, Heikki Linnakangas wrote: On 28/01/2022 15:57, Robert Haas wrote: 4. Also, the smgrwrite() calls are performed before WAL-logging the pages, so the page that's written to disk has 0/0 as the LSN, not the LSN of the WAL record. That's harmless too, but seems a bit sloppy.

Re: Fix error handling in be_tls_open_server()

> On 1 Aug 2023, at 16:44, Sergey Shinderuk wrote: > A static analyzer reported a possible pfree(NULL) in be_tls_open_server(). This has the smell of a theoretical problem, I can't really imagine a certificate where which would produce this. Have you been able to trigger it? Wouldn't a better

meson uses stale pg_config_paths.h left over from make

I've been having some problems running the regression tests using meson on Windows. This seems to be down to initdb being compiled with a version of pg_config_paths.h left over from the msvc build which had been used on that source tree previously. Generally when there are files left over the

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

> On 23 Aug 2023, at 08:58, Andres Freund wrote: > I'm hoping to push this fairly soon, as I'll be on vacation the last week of > August. I'll be online intermittently though, if there are issues, I can react > (very limited connectivity for middday Aug 29th - midday Aug 31th though). I'd >

Re: PostgreSQL 16 release announcement draft

On Wed, 23 Aug 2023 at 22:21, jian he wrote: > > >>> > PostgreSQL 16 improves the performance of existing PostgreSQL functionality > through new query planner optimizations. In this latest release, the query > planner can parallelize `FULL` and `RIGHT` joins, utilize incremental sorts > for >

Re: pg_rewind WAL segments deletion pitfall

Hi, On Tue, 22 Aug 2023 at 07:32, Michael Paquier wrote: > > > I don't like much this patch. While it takes correctly advantage of > the backward record read logic from SimpleXLogPageRead() able to > handle correctly timeline jumps, it creates a hidden dependency in the > code between the

Re: list of acknowledgments for PG16

On Tue, Aug 22, 2023 at 6:33 PM Peter Eisentraut wrote: > As usual, please check for problems such as wrong sorting, duplicate > names in different variants, or names in the wrong order etc. (Our > convention is given name followed by surname.) I went through Japanese names on the list. I

Re: MERGE ... RETURNING

Updated version attached, fixing an uninitialized-variable warning from the cfbot. Regards, Dean diff --git a/doc/src/sgml/dml.sgml b/doc/src/sgml/dml.sgml new file mode 100644 index cbbc5e2..7f65f6e --- a/doc/src/sgml/dml.sgml +++ b/doc/src/sgml/dml.sgml @@ -283,10 +283,15 @@ DELETE FROM

Re: Synchronizing slots from primary to standby

On Wed, Aug 23, 2023 at 3:38 PM shveta malik wrote: > I have reviewed the v12-0002 patch and I have some comments. I see the latest version posted sometime back and if any of this comment is already fixed in this version then feel free to ignore that. In general, code still needs a lot more

Re: Remove distprep

On 14.07.23 10:56, Peter Eisentraut wrote: On 14.07.23 09:54, Peter Eisentraut wrote: diff --git a/src/tools/pginclude/cpluspluscheck b/src/tools/pginclude/cpluspluscheck index 4e09c4686b..287395887c 100755 --- a/src/tools/pginclude/cpluspluscheck +++ b/src/tools/pginclude/cpluspluscheck @@

Re: PostgreSQL 16 release announcement draft

>>> PostgreSQL 16 improves the performance of existing PostgreSQL functionality through new query planner optimizations. In this latest release, the query planner can parallelize `FULL` and `RIGHT` joins, utilize incremental sorts for `SELECT DISTINCT` queries, and execute window functions more

Re: Synchronizing slots from primary to standby

On Thu, Aug 17, 2023 at 4:09 PM shveta malik wrote: > > On Thu, Aug 17, 2023 at 11:55 AM shveta malik wrote: > > > > On Thu, Aug 17, 2023 at 11:44 AM Drouvot, Bertrand > > wrote: > > > > > > Hi, > > > > > > On 8/14/23 11:52 AM, shveta malik wrote: > > > > > > > > > > > We (myself and Ajin)

Re: EBCDIC sorting as a use case for ICU rules

On 17.07.23 10:10, Daniel Verite wrote: Peter Eisentraut wrote: You can use whitespace in the rules. For example, CREATE COLLATION ebcdic (provider='icu', locale='und', rules=$$ Nice, it's clearly better that the piece of code I had in the previous patch. It can also be made more

Re: pg_rewind WAL segments deletion pitfall

On 2023-08-22 14:32, Michael Paquier wrote: Thanks for your review! On Fri, Aug 18, 2023 at 03:40:57PM +0900, torikoshia wrote: Thanks for the patch, I've marked this as ready-for-committer. BTW, this issue can be considered a bug, right? I think it would be appropriate to provide backpatch.

Re: persist logical slots to disk during shutdown checkpoint

On Wed, 23 Aug 2023 at 14:21, Hayato Kuroda (Fujitsu) wrote: > > Dear Vignesh, > > > Here is a patch to persist to disk logical slots during a shutdown > > checkpoint if the updated confirmed_flush_lsn has not yet been > > persisted. > > Thanks for making the patch with different approach! Here

RE: persist logical slots to disk during shutdown checkpoint

Dear Vignesh, > Here is a patch to persist to disk logical slots during a shutdown > checkpoint if the updated confirmed_flush_lsn has not yet been > persisted. Thanks for making the patch with different approach! Here are comments. 01. RestoreSlotFromDisk ```

Re: subscription/015_stream sometimes breaks

On 2023-Aug-23, Alvaro Herrera wrote: > And the reason 0002 does not remove the zeroing of ->proc is that the > tests gets stuck when I do that, and the reason for that looks to be > some shoddy coding in WaitForReplicationWorkerAttach, so I propose we > change that too, as in 0003. Hmm,

Re: [dsm] comment typo

> On 21 Aug 2023, at 12:15, Junwang Zhao wrote: > > On Mon, Aug 21, 2023 at 5:16 PM Daniel Gustafsson wrote: >> >>> On 18 Aug 2023, at 11:10, Junwang Zhao wrote: >>> >>> In the following sentence, I believe either 'the' or 'a' should be kept, not >>> both. I here keep the 'the', but feel

Re: MERGE ... RETURNING

On Tue, 25 Jul 2023 at 21:46, Gurjeet Singh wrote: > > There seems to be other use cases which need us to invent a method to > expose a command-specific alias. See Tatsuo Ishii's call for help in > his patch for Row Pattern Recognition [1]. > I think that's different though, because in that

Re: initdb caching during tests

> On 23 Aug 2023, at 03:17, Andres Freund wrote: > On 2023-08-22 23:47:24 +0200, Daniel Gustafsson wrote: >> My only small gripe is that I keep thinking about template databases for >> CREATE >> DATABASE when reading the error messages in this patch, which is clearly not >> related to what this

Re: subscription/015_stream sometimes breaks

On 2023-Aug-23, Zhijie Hou (Fujitsu) wrote: > [1]-- > LWLockAcquire(LogicalRepWorkerLock, LW_SHARED); > > workers = logicalrep_workers_find(MyLogicalRepWorker->subid, > true); > foreach(lc, workers) > { >

Re: pg_upgrade - a function parameter shadows global 'new_cluster'

> On 23 Aug 2023, at 03:28, Peter Smith wrote: > PSA a small patch to remove the unnecessary parameter, and so eliminate this > shadowing. Agreed, applied. Thanks! -- Daniel Gustafsson

Re: list of acknowledgments for PG16

Peter Eisentraut a écrit : The list of acknowledgments for the PG16 release notes has been committed. It should show up here sometime: . As usual, please check for problems such as wrong sorting, duplicate names

Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot, etc?

Hi, On 2023-08-07 19:15:41 -0700, Andres Freund wrote: > As some of you might have seen when running CI, cirrus-ci is restricting how > much CI cycles everyone can use for free (announcement at [1]). This takes > effect September 1st. > > This obviously has consequences both for individual users