On Wed, Jul 12, 2023 at 01:47:51PM +0200, Daniel Gustafsson wrote:
> > On 12 Jul 2023, at 09:52, Masahiko Sawada wrote:
> > Agreed. The timeout can be set by manually setting
> > PG_TEST_TIMEOUT_DEFAULT, but I bump it to 10 min by default. And it
> > now require setting PG_TET_EXTRA to run it.
>
Hi.
In src/backend/executor/nodeAgg.c
817: advance_aggregates(AggState *aggstate)
Do we need to add "(void)" before ExecEvalExprSwitchContext?
On Sun, Sep 3, 2023 at 6:42 AM Andrew Dunstan wrote:
> I guess the next thing would be to test it on a few more platforms and also
> to see if we need to expand the coverage of libpq for the intended uses.
Nice. It works fine on my FreeBSD battlestation after "sudo pkg
install p5-FFI-Platypus"
> Hi,
>
> The patches compile & tests run fine but this statement from the
> documentation crashes an assert-enabled server:
>
> SELECT company, tdate, price, max(price) OVER w FROM stock
> WINDOW w AS (
> PARTITION BY company
> ROWS BETWEEN CURRENT ROW AND UNBOUNDED FOLLOWING
> AFTER MATCH SKIP
I agree that the code lacks barriers. I haven't been able to figure
out how any reordering could cause this hang, though, because in these
old branches procsignal_sigusr1_handler is used for latch wakeups, and
it also calls SetLatch(MyLatch) itself, right at the end. That is,
SetLatch() gets
Hello Robert,
01.09.2023 23:21, Robert Haas wrote:
On Fri, Sep 1, 2023 at 6:13 AM Alexander Lakhin wrote:
(Placing "pg_compiler_barrier();" just after "waiting = true;" fixed the
issue for us.)
Maybe it'd be worth trying something stronger, like
pg_memory_barrier(). A compiler barrier
On 9/1/23 16:57, Robert Haas wrote:
> On Thu, Aug 31, 2023 at 2:32 PM David Christensen
> wrote:
>> Here's a patch atop the series which converts to 16-bit uints and
>> passes regressions, but I don't consider well-vetted at this point.
>
> For what it's worth, my gut reaction to this patch
On Fri, Sep 01, 2023 at 01:52:48PM -0700, Nathan Bossart wrote:
> On Fri, Sep 01, 2023 at 04:00:44PM -0400, Robert Haas wrote:
>> In hindsight, I think that making binaryheap depend on Datum was a bad
>> idea. I think that was my idea, and I think it wasn't very smart.
>> Considering that people
On 2023-08-30 We 21:29, Thomas Munro wrote:
On Thu, Aug 31, 2023 at 10:32 AM Andrew Dunstan wrote:
#!/usr/bin/perl
use strict; use warnings;
use FFI::Platypus;
my $ffi = FFI::Platypus->new(api=>1);
$ffi->lib("inst/lib/libpq.so");
$ffi->type('opaque' => 'PGconn');
$ffi->attach(PQconnectdb
Op 9/2/23 om 08:52 schreef Tatsuo Ishii:
Attached is the v5 patch. Differences from previous patch include:
Hi,
The patches compile & tests run fine but this statement from the
documentation crashes an assert-enabled server:
SELECT company, tdate, price, max(price) OVER w FROM stock
On Thu, Aug 31, 2023 at 9:19 AM John Morris
wrote:
> Here is an updated version of the earlier work.
>
> This version:
>1) Tracks memory as requested by the backend.
>2) Includes allocations made during program startup.
>3) Optimizes the "fast path" to only update two local
On Sat, Sep 2, 2023 at 10:09 AM Amit Kapila wrote:
>
> During pg_upgrade, we start the server for the old cluster which can
> allow the checkpointer to remove the WAL files. It has been noticed
> that we do generate certain types of WAL records (e.g
> XLOG_RUNNING_XACTS, XLOG_CHECKPOINT_ONLINE,
Em sex., 1 de set. de 2023 às 17:17, Robert Haas
escreveu:
> On Fri, Sep 1, 2023 at 11:47 AM Ranier Vilela wrote:
> > If a null locale is reached in these paths.
> > elog will dereference a null pointer.
>
> True. That's sloppy coding.
>
> I don't know enough about this code to be sure whether
> attached is my refactor. there is some whitespace errors in the
> patches, you need use
> git apply --reject --whitespace=fix
> basedon_v29_matview_c_refactor_update_set_clause.patch
>
> Also you patch cannot use git apply, i finally found out bulk apply
I have no problem with applying Yugo's
I wrote:
> + # XXX This one neither, but if I add it to @skip, PerfectHash will
fail. (???)
> + #FIXME: AttributeRelationId
>
> I took a quick look at this, and attached is the least invasive way to
get it working for now, which is to bump the table size slightly. The
comment says doing this
Attached is the v5 patch. Differences from previous patch include:
* Resolve complaint from "PostgreSQL Patch Tester"
https://commitfest.postgresql.org/44/4460/
- Change gram.y to use PATTERN_P instead of PATTERN. Using PATTERN seems
to make trouble with Visual Studio build.
:
:
16 matches
Mail list logo
