Re: Patch: Add parse_type Function

Let me comment on some issues since I wrote the very first version of parse_type() on which David's patch is based. > On 2024-02-01 01:00 +0100, jian he wrote: > > cosmetic issue. Looking around other error handling code, the format > should be something like: > ` > if

035_standby_logical_decoding unbounded hang

Coincidentally, one of my buildfarm animals hanged several weeks in a different test, 035_standby_logical_decoding.pl. A LOG_SNAPSHOT_INTERVAL_MS reduction was part of making it reproducible: On Fri, Feb 02, 2024 at 04:01:45PM -0800, Noah Misch wrote: > On Fri, Feb 02, 2024 at 02:30:03PM -0800,

Re: What about Perl autodie?

Andrew Dunstan writes: > On 2024-02-08 Th 11:08, Daniel Gustafsson wrote: >> On 8 Feb 2024, at 16:53, Tom Lane wrote: >>> 2. Don't wait, migrate them all now. This would mean requiring >>> Perl 5.10.1 or later to run the TAP tests, even in back branches. >>> I think #2 might not be all that

Re: Sequence Access Methods, round two

On Thu, Feb 08, 2024 at 04:06:36PM +0100, Peter Eisentraut wrote: > On 19.01.24 00:27, Michael Paquier wrote: >> The reason why this stuff has bumped into my desk is that we have no >> good solution in-core for globally-distributed transactions for >> active-active deployments. First, anything we

Re: Patch: Add parse_type Function

+ /* + * Parse type-name argument to obtain type OID and encoded typmod. We don't + * need to check for parseTypeString failure, but just let the error be + * raised. The 0 arg works both as the `Node *escontext` arg in Postgres 16 + * and the `bool missing_ok` arg in 9.4-15. + */ + (void)

Re: Popcount optimization using AVX512

On Fri, Feb 09, 2024 at 08:33:23PM -0800, Andres Freund wrote: > On 2024-02-09 15:27:57 -0800, Noah Misch wrote: > > On Fri, Feb 09, 2024 at 10:24:32AM -0800, Andres Freund wrote: > > > On 2024-01-26 07:42:33 +0100, Alvaro Herrera wrote: > > > > This suggests that finding a way to make the ifunc

Re: glibc qsort() vulnerability

On Sat, Feb 10, 2024 at 08:59:06AM +0100, Mats Kindahl wrote: > Split the code into two patches: one that just adds the functions > (including the new pg_cmp_size()) to common/int.h and one that starts using > them. I picked the name "pg_cmp_size" rather than "pg_cmp_size_t" since > "_t" is

Re: backend *.c #include cleanup (IWYU)

On Sat, Feb 10, 2024 at 08:40:43AM +0100, Peter Eisentraut wrote: > The purpose of this patch is twofold: One, it's of course a nice cleanup. > Two, this is a test how well IWYU might work for us. If we find either by > human interpretation that a change doesn't make sense, or something breaks >

Re: [PATCH] Add native windows on arm64 support

On 2024-02-10 Sa 12:20, Dave Cramer wrote: On Sat, 10 Feb 2024 at 11:19, Andrew Dunstan wrote: On 2024-02-09 Fr 14:23, Dave Cramer wrote: Dave Cramer www.postgres.rocks On Fri, 9 Feb 2024 at 07:18, Dave Cramer

RE: Psql meta-command conninfo+

>Database | postgres >[...] >Host | 127.0.0.1 >Encryption | SSL >Protocol | PQsslAttribute(protocol) >Cipher | PQsslAttribute(cipher) >Compression| PQsslAttribute(compression) > >When GSS, like this > >Database | postgres

Re: recently added jsonpath method change jsonb_path_query, jsonb_path_query_first immutability

On 2024-02-08 Th 21:02, Jeevan Chalke wrote: On Thu, Feb 8, 2024 at 2:22 PM jian he wrote: On Thu, Feb 8, 2024 at 1:27 PM Jeevan Chalke wrote: > > > > On Wed, Feb 7, 2024 at 9:13 PM jian he wrote: >> >> On Wed, Feb 7, 2024 at 7:36 PM Jeevan Chalke

Re: [PATCH] Add native windows on arm64 support

On Sat, 10 Feb 2024 at 11:19, Andrew Dunstan wrote: > > On 2024-02-09 Fr 14:23, Dave Cramer wrote: > > > Dave Cramer > www.postgres.rocks > > > On Fri, 9 Feb 2024 at 07:18, Dave Cramer > wrote: > >> >> >> >> >> On Fri, 9 Feb 2024 at 00:26, Michael Paquier wrote: >> >>> On Tue, Feb 06, 2024 at

Re: [PATCH] Add native windows on arm64 support

On 2024-02-09 Fr 14:23, Dave Cramer wrote: Dave Cramer www.postgres.rocks On Fri, 9 Feb 2024 at 07:18, Dave Cramer wrote: On Fri, 9 Feb 2024 at 00:26, Michael Paquier wrote: On Tue, Feb 06, 2024 at 07:01:49AM -0500, Dave Cramer wrote: > Thanks, this patch

Re: Possibility to disable `ALTER SYSTEM`

On 2024-02-07 We 05:37, Gabriele Bartolini wrote: Hi Joel, On Wed, 7 Feb 2024 at 10:00, Joel Jacobson wrote: On Fri, Sep 8, 2023, at 16:17, Gabriele Bartolini wrote: > ``` > postgres=# ALTER SYSTEM SET wal_level TO minimal; > ERROR:  could not open file

Re: What about Perl autodie?

On 2024-02-08 Th 11:08, Daniel Gustafsson wrote: On 8 Feb 2024, at 16:53, Tom Lane wrote: 2. Don't wait, migrate them all now. This would mean requiring Perl 5.10.1 or later to run the TAP tests, even in back branches. I think #2 might not be all that radical. We have nothing older than

Re: Synchronizing slots from primary to standby

On Sat, Feb 10, 2024 at 5:31 PM Masahiko Sawada wrote: > > On Fri, Feb 9, 2024 at 4:08 PM Zhijie Hou (Fujitsu) > wrote: > > > Another alternative is to register the callback when calling slotsync > > functions > > and unregister it after the function call. And register the callback in > >

Re: [PoC] Improve dead tuple storage for lazy vacuum

On Tue, Feb 6, 2024 at 9:58 AM Masahiko Sawada wrote: > > On Fri, Feb 2, 2024 at 8:47 PM John Naylor wrote: > > My todo: > > - benchmark tid store / vacuum again, since we haven't since varlen > > types and removing unnecessary locks. I ran a vacuum benchmark similar to the one in [1]

Re: Thoughts about NUM_BUFFER_PARTITIONS

On 2/8/24 14:27, wenhui qiu wrote: > Hi Heikki Linnakangas > I think the larger shared buffer higher the probability of multiple > backend processes accessing the same bucket slot BufMappingLock > simultaneously, （ InitBufTable(NBuffers + NUM_BUFFER_PARTITIONS); When I > have free time, I

Re: Synchronizing slots from primary to standby

On Fri, Feb 9, 2024 at 4:08 PM Zhijie Hou (Fujitsu) wrote: > > On Friday, February 9, 2024 2:44 PM Masahiko Sawada > wrote: > > > > On Thu, Feb 8, 2024 at 8:01 PM shveta malik wrote: > > > > > > On Thu, Feb 8, 2024 at 12:08 PM Peter Smith > > wrote: > > > > > > > > Here are some review

RE: Synchronizing slots from primary to standby

On Saturday, February 10, 2024 11:37 AM Zhijie Hou (Fujitsu) wrote: > > Attach the V83 patch which addressed Peter[1][2], Amit and Sawada-san's[3] > comments. Only 0001 is sent in this version, we will send other patches after > rebasing. > > [1] >