Re: [HACKERS] More stats about skipped vacuums

ry in the backend fast enough that we can hold a lock and just queue up the stats updates during the copy? If we can copy the complete structure, that would fix one of the bigger bottlenecks with it today which is that we dump and rebuild the hashtables as we go through the tempfiles. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Typo in config_default.pl comment

On Mon, Nov 27, 2017 at 2:21 AM, Andreas Karlsson <andr...@proxel.se> wrote: > Hi, > > There is a --with-tls in the comments in config_default.pl which should > be --with-tcl. > Oops. Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hag

Re: [HACKERS] More stats about skipped vacuums

On Tue, Nov 28, 2017 at 12:16 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: > > What I've been thinking about for that one before is if we could just > > invent a protocol (shmq based maybe) whereby autovacuum can ask the stats

Re: Basebackups reported as idle

On Wed, Dec 20, 2017 at 12:50 PM, Michael Paquier <michael.paqu...@gmail.com > wrote: > On Wed, Dec 20, 2017 at 6:07 PM, Magnus Hagander <mag...@hagander.net> > wrote: > > What about the attached? > > The new positions look good to me, still aren't you missing

Re: [HACKERS] Re: proposal - psql: possibility to specify sort for describe commands, when size is printed

ad, the syntax could simply be: > +1 here as well. And anybody who is actually going to need this level of control definitely will know SQL... And if one wants to save some "standard patterns", it should be doable to save the pattern itself in a variable and then use it with so

Re: Schedule for migration to pglister

On Thu, Nov 16, 2017 at 4:51 PM, Justin Clift <jus...@postgresql.org> wrote: > On 2017-11-16 15:34, Stephen Frost wrote: > >> Magnus, all, >> >> * Magnus Hagander (mag...@hagander.net) wrote: >> >>> mbox access should now be restored, and as

Re: pgsql: Prohibit identity columns on typed tables and partitions

On Sat, Dec 9, 2017 at 10:45 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 12/9/17 05:47, Magnus Hagander wrote: > > > > > > On Sat, Dec 9, 2017 at 8:43 AM, Michael Paquier > > <michael.paqu...@gmail.com <mailto:michael.paqu...@gmail

Re: AS OF queries

hout some rather > > enormous pushups. > > The SQL standard syntax appears to be something like > > "tablename" [ AS OF SYSTEM TIME 'something' ] [ [ AS ] "alias" ] > > That's not going to be fun to parse. > There was a presentation about this given

Re: Incorrect path in header comment identification

t/inet_net_ntop.c > */ > > #if defined(LIBC_SCCS) && !defined(lint) > Failed to get the actual patch to apply (probably cut/paste issue from it being inline), but since the changes were trivial, just made those. Thanks, applied. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

pg_control read error message

give a better message. Attached is a patch that does this. Reasonable? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/> diff --git a/src/backend/access/transam/xlog.c b/src/backend/ac

Re: Postgres 11 release notes

That's what requirement means... :) What's the take of others? Magnus, Stephen or Heikki perhaps (you've > been the most involved with SCRAM early talks)? > Saw it by luck. It would probably be better if it wasn't hidden deep in a thread about release notes. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Postgres 11 release notes

On Wed, May 16, 2018 at 6:24 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > On 2018-May-16, Magnus Hagander wrote: > > > On Wed, May 16, 2018 at 4:08 PM, Alvaro Herrera < > alvhe...@2ndquadrant.com> > > wrote: > > > > I'm not sure why w

Re: SCRAM with channel binding downgrade attack

On Wed, May 23, 2018 at 11:08 AM, Heikki Linnakangas <hlinn...@iki.fi> wrote: > On 23/05/18 09:59, Magnus Hagander wrote: > >> With that, a connection would be allowed, if either the server's SSL >>> certificate is verified as with "sslmode=verify-full", *or*

Re: SCRAM with channel binding downgrade attack

th "sslmode=verify-full", *or* SCRAM > authentication with channel binding was used. Or perhaps cram it into > sslmode, "sslmode=verify-full-or-scram-channel-binding", just with a > nicer name. (We can do that after v11 though, I think.) sslmode=verify-full is very different from SCRAM with channel binding, isn't it? As in, SCRAM with channel binding at no point proves which server you're talking to -- only that you are talking to the SSL endpoint? It could be a rogue SSL endpoint unless you do certificate validation. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: SCRAM with channel binding downgrade attack

On Wed, May 23, 2018 at 10:56 AM, Michael Paquier <mich...@paquier.xyz> wrote: > On Wed, May 23, 2018 at 08:59:43AM +0200, Magnus Hagander wrote: > > On Wed, May 23, 2018 at 8:46 AM, Heikki Linnakangas <hlinn...@iki.fi> > wrote: > >> "tls-unique" and

Re: pg_replication_slot_advance to return NULL instead of 0/0 if slot not advanced

eturn InvalidXLogRecPtr (which can happen in the case of concurrent activity on the slot, I think)? In this case, maybe we should just re-check that and raise an error appropriately? (I haven't looked at the logical slot path, but I assume it would have something similar in it) -- Magnus Hag

Re: pg_basebackup -k option

ing checksums. I > > think it could be confusing to have two related tools use the same > > option letter for nearly opposite purposes. > > > How about using capital -K in pg_basebackup? Or maybe it doesn't need a > > short option at all. > > +1 for no short opti

Re: pg_control read error message

gt; Pushed a fix including the controldata_utils.c one. Per Toms comments we probably have more of these, but that's no excuse not to fix this one :) -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Commit fest 2017-11

On Tue, May 22, 2018 at 7:57 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Mar 29, 2018 at 4:19 AM, Magnus Hagander <mag...@hagander.net> > wrote: > > I wonder if we should consider adding a field to the CF app > *specifically* > > to track th

Re: Typo in planner README

On Thu, Jun 7, 2018 at 12:28 PM, Daniel Gustafsson wrote: > The README didn’t get the memo when set_base_rel_pathlist was renamed in > 6543d81d659f417. Use the right name, set_base_rel_pathlists, as per the > attached. > Applied, thanks. -- Magnus Hagander Me: https://www.

Re: Loaded footgun open_datasync on Windows

the capability > to deal with backend stuff like ereport, elog etc, if we don't want to use > FRONTEND environment. The other server applications like pg_ctl.c, > initdb.c, etc. also uses FRONTEND environment. > > Not having researched this particular case but yes, there are a number of things expected in a non-FRONTEND environment. Things that may also go unnoticed until too late (e.g. singal handling etc that needs explicit initialization). Standalong binaries should pretty much always be frontend. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Logging transaction IDs for DDL.

r your specific usecase, and until the actual logging can be rethought on it, I suggest you take a look at event triggers for it. E.g.: https://blog.hagander.net/logging-transactions-that-dropped-tables-236/ -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work:

Re: SCRAM with channel binding downgrade attack

On Tue, Jun 12, 2018 at 6:49 AM, Michael Paquier wrote: > On Mon, Jun 11, 2018 at 04:54:45PM +0200, Magnus Hagander wrote: > > I'm wondering if that means we should then also not do it specifically > for > > scram in this version. Otherwise we're likely to end up with a param

Re: SCRAM with channel binding downgrade attack

one version, and that seems like a bad idea. If nothing else we should clearly think out what the path is to make sure that doesn't happen. (e.g. we don't want a scram_channel_binding_mode=require in this version, if the next one is going to replace it with something like heikkis suggested allowed_authe

Re: Code of Conduct plan

ecent coverage of other cultures and countries as well. We can't cover them all on the committee (that would make for a gicantic committee), but we can cover it with people who are used to communicating and working with people from other areas as well, which makes for a better understanding. It won't be perfect in the first attempt, of course, but that one is covered. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: commitfest 2018-07

the system would actually react to it. Thus, if we don't want to have to risk doing surgery on the system (or guarantee we won't bounce any patches from the 07 CF, but that seems like the wrong thing to do), we should rename the existing 09 CF to 07, so all patches automatically end up there, and stick to on

Re: Add CONTRIBUTING.md

f users are used to it, so that's where they're going to go look first. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Loaded footgun open_datasync on Windows

ethrough, we actually write through the cache on the raidcontroller *even if it has bettery/flash cache*, which gives absolutely terrible performance on these platforms. It is useful if you have a consumer drive that by default does insafe caching but does respect writethrough requests. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Is a modern build system acceptable for older platforms

On Mon, May 28, 2018, 10:03 Yuriy Zhuravlev wrote: > пн, 28 мая 2018 г. в 16:42, Pierre Ducroquet : > >> On Monday, May 28, 2018 4:37:06 AM CEST Yuriy Zhuravlev wrote: >> > > Can't see getting rid of those entirely. None of the github style >> > >

Re: Incorrect fsync handling in pg_basebackup's tar_finish

shouldn't something like the attached > be done? Magnus and others, any opinions? > Yup, that seems like an issue and a correct fix to me. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: commitfest app moving patch error

rk with the first one -- patches are only supposed to be added to the one that's open... -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Online enabling of checksums

On Mon, Apr 9, 2018 at 7:22 PM, Magnus Hagander wrote: > On Sat, Apr 7, 2018 at 6:22 PM, Andres Freund wrote: > >> Hi, >> >> On 2018-04-07 08:57:03 +0200, Magnus Hagander wrote: >> > Note however that I'm sans-laptop until Sunday, so I will revert it >> t

Re: Logical decoding fast-forward and slot advance

Hi! Excellent! Just a quick note on my stab at it - it was physical only, which is more limited than this of course. My plan was to clean it up based on feedback in the next couple of days for the Jan cf, but with this submission in i think the effort is better directed there. I'll keep mine

Re: Basebackups reported as idle

On Fri, Dec 29, 2017 at 3:11 PM, David Steele <da...@pgmasters.net> wrote: > On 12/29/17 6:49 AM, Michael Paquier wrote: > > On Thu, Dec 28, 2017 at 06:21:46PM +0100, Magnus Hagander wrote: > >> On Fri, Dec 22, 2017 at 2:31 AM, Michael Paquier < > michael

Re: [HACKERS] GnuTLS support

ld actually have an openssl_dh_params_file and a gnutls_dh_params_file, but only one at any given time? Thinking on that there is also the case of file formats. What if one provider takes a cert file, but not in the same format -- should that still be ssl_cert_file, or should it be a diffe

Re: [PATCH] Atomic pgrename on Windows

ng it something similar to what we do with shared memory which is just to loop over it and try each a couple of time, before giving up and failing? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] log_destination=file

on? And if the conclusion is that hooks is the way to go for that, then is the slowdown of this patch actually a relevant problem to it? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Supporting huge pages on Windows

nfirm/deny the situation around XP and decide what to do about it, I am now happy to commit the rest of this patch. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/> diff --git a/doc/src/

Re: Use of term hostaddrs for multiple hostaddr values

t the error message when it comes to backpatching? Maybe we should leave that one to 11 only, to avoid breaking that, as the way it's written it's actually less wrong there. Thoughts? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Supporting huge pages on Windows

On Sun, Jan 21, 2018 at 2:30 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Sun, Jan 21, 2018 at 01:42:13PM +0200, Magnus Hagander wrote: > > We have traditionally supported older versions of Windows as long as > people > > build from source. But per

Re: [HACKERS] Supporting huge pages on Windows

Sat, Jan 20, 2018 at 2:33 PM, Magnus Hagander <mag...@hagander.net> wrote: > > > On Fri, Dec 1, 2017 at 5:02 AM, Michael Paquier <michael.paqu...@gmail.com > > wrote: > >> On Fri, Nov 24, 2017 at 9:28 AM, Tsunakawa, Takayuki >> <tsunakawa.ta...@jp.f

Re: Use of term hostaddrs for multiple hostaddr values

On Sun, Jan 21, 2018 at 12:45 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 1/20/18 17:39, Michael Paquier wrote: > > On Sat, Jan 20, 2018 at 08:30:43PM +0200, Magnus Hagander wrote: > >> On Tue, Jan 9, 2018 at 5:34 AM, Michael Paquier <

Re: [HACKERS] Function to move the position of a replication slot

On Wed, Nov 29, 2017 at 7:48 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Sep 5, 2017 at 11:51 AM, Andres Freund <and...@anarazel.de> wrote: > > On 2017-09-05 11:36:47 +0900, Michael Paquier wrote: > >> On Thu, Aug 31, 2017 at 9:19 PM, Magnus

Re: [HACKERS] Supporting huge pages on Windows

On Mon, Jan 22, 2018 at 4:24 AM, Thomas Munro <thomas.mu...@enterprisedb.com > wrote: > On Mon, Jan 22, 2018 at 3:45 AM, Magnus Hagander <mag...@hagander.net> > wrote: > > I got myself a working build env now so I can at least verify it builds, > > which it does.

Re: [HACKERS] Supporting huge pages on Windows

On Mon, Jan 22, 2018 at 12:13 AM, Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > > On 01/21/2018 01:02 PM, Andres Freund wrote: > > Hi, > > > > On 2018-01-21 13:42:13 +0200, Magnus Hagander wrote: > >> To add some more notes on this. Again, t

git instructions

reasons). https is also a protocol that's a lot less likely to run into firewall issues etc. Based on that, I propose the following patch which both moves https:// up to being the first-hand choice for protocol, and removes the references to it being slower. Thoughts? -- Magnus Hagander Me

Re: git instructions

On Thu, Feb 1, 2018 at 5:20 PM, Chapman Flack <c...@anastigmatix.net> wrote: > On 02/01/2018 10:54 AM, Magnus Hagander wrote: > > > in saying that git:// is faster than https://. In fact, we have some > > reports and testing that https:// can be significantly faster (du

Re: git instructions

so people have the new > paradigm in their head when they get to the quality comparison, will be > worthwhile for some period of time. > > Just "the git protocol" is probably best here, so changed to that. I also changed the http->https urls per Stefans suggestion. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Online enabling of checksums

Re-sending this one with proper formatting. Apologies for the horrible gmail-screws-up-the-text-part of the last one! No change to patch or text, just the formatting. //Magnus Once more, here is an attempt to solve the problem of on-line enabling of checksums that me and Daniel have been

Re: Typo in procarray.c

On Tue, Feb 20, 2018 at 2:47 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > Hi, > > Attached patch for fixing $subject. > > s/replicaton/replication/ > Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work:

Re: [bug fix] Produce a crash dump before main() on Windows

d before that one? It might still be useful in debugging, but in that case we might need to make it a configurable switch? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [bug fix] Produce a crash dump before main() on Windows

On Tue, Feb 20, 2018 at 3:18 PM, Craig Ringer <cr...@2ndquadrant.com> wrote: > On 20 February 2018 at 21:47, Magnus Hagander <mag...@hagander.net> wrote: > >> >> >> On Fri, Feb 16, 2018 at 8:28 AM, Tsunakawa, Takayuki < >> tsunakawa.ta...@jp.fujitsu.c

Re: Translations contributions urgently needed

setxlog > tr | plperl > zh_CN| pg_basebackup,pg_resetxlog,pltcl > zh_TW| plperl > Arent all those pg_resetxlog entries because it was renamed to pg_resetwal? Is that because they were actually not updated for the new name, or is it a reporting side effect? -- Magnus Hagander

Re: Online enabling of checksums

18:22, Peter Eisentraut <peter.eisentraut@2ndquadrant. > com> написал(а): > > On 2/21/18 15:53, Magnus Hagander wrote: > > *Two new functions are added, pg_enable_data_checksums() and > pg_disable_data_checksums(). The disable one is easy -- it just changes > to disable.

Allow workers to override datallowconn

hink about that? Are there any other caveats in doing that this actually makes it dangerous to just allow bypassing it for extensions? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/> diff --git a

Re: Online enabling of checksums

On Thu, Feb 22, 2018 at 9:23 PM, Andres Freund <and...@anarazel.de> wrote: > Hi, > > On 2018-02-22 21:16:02 +0100, Magnus Hagander wrote: > > You could do that, but then you've moving the complexity to managing that > > list in shared memory instead. > > May

Re: Allow workers to override datallowconn

On Thu, Feb 22, 2018 at 7:24 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: > > Attached is a patch that adds new Override versions of the functions to > > connect to a database from a background worker. > > >

Re: Online enabling of checksums

On Thu, Feb 22, 2018 at 8:52 PM, Andres Freund <and...@anarazel.de> wrote: > > > On February 22, 2018 11:44:17 AM PST, Magnus Hagander <mag...@hagander.net> > wrote: > >On Thu, Feb 22, 2018 at 8:41 PM, Andres Freund <and...@anarazel.de> > >wrote: >

Re: Allow workers to override datallowconn

On Thu, Feb 22, 2018 at 8:17 PM, Andres Freund <and...@anarazel.de> wrote: > Hi, > > On 2018-02-22 19:01:35 +0100, Magnus Hagander wrote: > > In working on the checksumhelper patch, we came across wanting a > background > > worker to be allowed to bypass datallowcon

Re: Allow workers to override datallowconn

safe to move it, but I haven't looked in detail. I also haven't checked if this actually helps in the pg_upgrade case, but if bypassing datallowconn is what's needed there then it shuld. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com

Re: Online enabling of checksums

On Thu, Feb 22, 2018 at 8:24 PM, Andres Freund <and...@anarazel.de> wrote: > On 2018-02-22 08:22:48 -0500, Peter Eisentraut wrote: > > On 2/21/18 15:53, Magnus Hagander wrote: > > > *Two new functions are added, pg_enable_data_checksums() and > > > pg_disable_

Re: Allow workers to override datallowconn

On Thu, Feb 22, 2018 at 8:26 PM, Andres Freund <and...@anarazel.de> wrote: > Hi, > > On 2018-02-22 20:24:03 +0100, Magnus Hagander wrote: > > In a background worker you can just set the parameter using > > SetConfigOption(), no? That seems a lot easier than turning t

Re: Online enabling of checksums

On Thu, Feb 22, 2018 at 8:41 PM, Andres Freund <and...@anarazel.de> wrote: > > On 2018-02-22 20:30:52 +0100, Magnus Hagander wrote: > > On Thu, Feb 22, 2018 at 8:24 PM, Andres Freund <and...@anarazel.de> > wrote: > > > I suspect I'm going to get some grief

Re: Online enabling of checksums

On Sat, Feb 24, 2018 at 1:34 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Feb 22, 2018 at 3:28 PM, Magnus Hagander <mag...@hagander.net> > wrote: > > I would prefer that yes. But having to re-read 9TB is still significantly > > better than not being ab

Re: Online enabling of checksums

ou say actually overloading it on the user visible GUCs seems a bit ugly. Once there I think the easiest is to just pass it down to the workers through the shared memory segment. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Online enabling of checksums

On Sat, Feb 24, 2018 at 6:14 PM, Michael Banck <michael.ba...@credativ.de> wrote: > Hi, > > On Wed, Feb 21, 2018 at 09:53:31PM +0100, Magnus Hagander wrote: > > We’ve also included a small commandline tool, bin/pg_verify_checksums, > > that can be run against an offl

Re: Online enabling of checksums

On Sat, Feb 24, 2018 at 10:49 PM, Andres Freund <and...@anarazel.de> wrote: > On 2018-02-24 22:45:09 +0100, Magnus Hagander wrote: > > Is it really that invisible? Given how much we argue over adding single > > counters to the stats system, I'm not sure it's quite that lo

Re: Online enabling of checksums

On Thu, Feb 22, 2018 at 9:09 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 2/22/18 12:38, Magnus Hagander wrote: > > I'm not entirely sure which the others ones are. Auto-Vacuum obviously > > is one, which doesn't use the worker infrastructure. But I

Re: Allow workers to override datallowconn

On Fri, Feb 23, 2018 at 7:52 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: > > Here's another attempt at moving this one forward. Basically this adds a > > new GucSource being GUC_S_CLIENT_EARLY. It now runs through the &

Re: Allow workers to override datallowconn

On Thu, Feb 22, 2018 at 9:24 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: > > I hacked up an attempt to do this. It does seem to work in the very > simple > > case, but it does requiring changing the order in InitPost

Online enabling of checksums

olation test ran into the 1024 character limit of the isolation test lexer, with a separate patch and discussion at https://www.postgresql.org/message-id/8d628be4-6606-4ff6-a3ff-8b2b0e9b4...@yesql.se <https://www.postgresql.org/message-id/8d628be4-6606-4ff6-a3ff-8b2b0e9b4...@yesql.se>* -- M

Re: The pg_indent on on ftp is outdated

On Fri, Dec 22, 2017 at 1:33 AM, Craig Ringer <cr...@2ndquadrant.com> wrote: > > > On 21 Dec. 2017 22:42, "Tom Lane" <t...@sss.pgh.pa.us> wrote: > > Magnus Hagander <mag...@hagander.net> writes: > > On Thu, Dec 21, 2017 at 12:42 P

Re: Basebackups reported as idle

On Fri, Dec 22, 2017 at 2:31 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Thu, Dec 21, 2017 at 02:46:15PM +0100, Magnus Hagander wrote: > > On Thu, Dec 21, 2017 at 1:38 AM, Michael Paquier < > michael.paqu...@gmail.com> > > wro

Re: Add default role 'pg_access_server_files'

m read. E.g. a pg_write_server_files/pg_read_server_files? ISTM that will turn into a pretty common request... * execute from read/write, so COPY FROM PROGRAM etc would be a separate role? I realize we don't want to go overboard with the number of roles here, but at least separating read from

Re: Add default role 'pg_access_server_files'

On Tue, Jan 2, 2018 at 1:08 PM, Stephen Frost <sfr...@snowman.net> wrote: > Magnus, > > * Magnus Hagander (mag...@hagander.net) wrote: > > On Sun, Dec 31, 2017 at 8:19 PM, Stephen Frost <sfr...@snowman.net> > wrote: > > > This patch adds a new default role

Re: The pg_indent on on ftp is outdated

On Thu, Dec 21, 2017 at 12:42 PM, Craig Ringer <cr...@2ndquadrant.com> wrote: > On 21 December 2017 at 18:22, Magnus Hagander <mag...@hagander.net> wrote: > >> >> >> On Thu, Dec 21, 2017 at 8:20 AM, Craig Ringer <cr...@2ndquadrant.com> >> w

Re: Basebackups reported as idle

On Thu, Dec 21, 2017 at 1:38 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Wed, Dec 20, 2017 at 9:02 PM, Magnus Hagander <mag...@hagander.net> > wrote: > > On Wed, Dec 20, 2017 at 12:50 PM, Michael Paquier > > <michael.paqu...@gmail.com> wro

Re: Tracking of page changes for backup purposes. PTRACK [POC]

nted at least partially as a walsender command. That way you can get it out through a replication connection and piggyback on things like replication slots to make sure you have the data you need, without having to send the full volume of data. And it would make it possible to do incremental/differe

Re: pg_verify_checksums review

he > tree. > > The attached patches fixes the above mentioned things (I don’t have a docs > toolchain working right now so the docs patches are best effort). > I believe both those are fine for 11, so I've pushed that. I kept it as a separate patch to make it easy enough to r

Re: Fix some error handling for read() and errno

quot;could not read from log segment %s, offset %u: read > %d bytes, expected %d", > + fname, readOff, r, XLOG_BLCKSZ))); > Yeah, I think you'd need to make a call for the individual message to see how much it helps. In this one the context definitely does, in some others it doesn't. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: pg_verify_checksums -d option (was: Re: pg_verify_checksums -r option)

t;> useful during development but does not seem very useful for a stable > > > >> release. AFAICT there is no other debug output for now. > > > >> > > > >> So it could be renamed to -v (verbose) and only mention each scanned > > > >

Re: pg_verify_checksums vs windows

On Wed, Aug 29, 2018 at 1:44 PM, Amit Kapila wrote: > On Wed, Aug 29, 2018 at 5:05 PM Magnus Hagander > wrote: > > > > On Wed, Aug 29, 2018 at 1:31 PM, Amit Kapila > wrote: > >> > >> So, I think we need to open the file in binary mode as in other part

Re: pg_verify_checksums vs windows

parts > of the code. The attached patch fixes the problem for me. > > Thoughts? > Yikes. Yes, I believe you are correct, and that looks like the correct fix. I wonder why this was not caught on the buildfarm. We do have regression tests for it, AFAIK? Or maybe we just lucked out th

Re: pg_verify_checksums and -fno-strict-aliasing

the work buffer rather than > put it on the stack.) So if I get you right, you're saying the attached patch should be all that's needed? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com

Re: pg_verify_checksums and -fno-strict-aliasing

On Thu, Aug 30, 2018 at 9:35 PM, Magnus Hagander wrote: > On Thu, Aug 30, 2018 at 4:39 PM, Tom Lane wrote: > >> Fabien COELHO writes: >> >> If I add -fno-strict-aliasing to $CFLAGS, the problem goes away. >> >> Is this something to worry about, or just pi

Re: Online verification of checksums

t one does not need the sleep? Certainly 500ms would be very long since we're just protecting against a torn page, but the comment is wrong I think, and we're actually sleeping 0.5ms? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: Extra word in src/backend/optimizer/README

On Thu, Aug 30, 2018 at 1:27 PM, Etsuro Fujita wrote: > Hi, > > Here is a small patch to remove $SUBJECT: s/has contains/contains/ > Definitely looks correct. A good first test to verify your own commit/push privileges, perhaps? -- Magnus Hagander Me: https://www.hagande

Re: pg_verify_checksums and -fno-strict-aliasing

On Thu, Aug 30, 2018 at 10:02 PM, Michael Paquier wrote: > On Thu, Aug 30, 2018 at 09:35:33PM +0200, Magnus Hagander wrote: > > Should we make it a separate test in pg_verify_checksums, or should we > > piggyback on the pg_basebackup tests (which AFAICT is the only ones that >

Re: can commitfest application resend a mail?

with mbox:es, that is (which is a non-solution for people using web based cloud mail, we're well aware and this is why we still want the functionality for resend) -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: shared-memory based stats collector

l. I think something like this could for example be used for autovacuum rechecks. On top of the file based transfer that would help very little, but through shared memory it could be a lot lighter weight. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: shared-memory based stats collector

while *also* proviiding a lower overhead interface for those that don't care about it. If it ends up that keeping the snapshots become too much overhead in either in performance or code-maintenance, then I agree can probably drop that. But we should at least properly investigate the cost. --

Re: [HACKERS] Supporting huge pages on Windows

On Sun, Jan 21, 2018 at 6:11 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Magnus Hagander <mag...@hagander.net> writes: > > With that, I'm pushing this. Let's see what the buildfarm thinks of it. > And > > if others end up complaining about the platform drop, b

Re: disable SSL compression?

On Sun, Mar 11, 2018 at 2:05 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 3/11/18 04:00, Magnus Hagander wrote: > > I am not talking about the OpenSSL disabling it. It was disabled on most > > *distributions* years ago, long before that commit. Which

Re: 2018-03 Commitfest starts tomorrow

even if there is no CF open at all..) Trivial ones can certainly be picked up as well. > There is no way that we can possibly handle 200+ CF entries in a month. > A large fraction of these are going to end up pushed to September no > matter what, and I think simple fairness dema

Re: Online enabling of checksums

ld) *and* adds a new WAL record type... -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

initdb help message about WAL segment size

I propose the attached patch, aligning the help message with the docs. Any reason not to? (yes, I confused myself by trying --wal-segsize=1MB instead of just --wal-segsize=1. I blame just stepping off an intercontinental flight and a very early morning :P) -- Magnus Hagander Me: https

Re: disable SSL compression?

Sun, Mar 11, 2018 at 12:36 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 3/9/18 09:06, Magnus Hagander wrote: > > What platform does that actually work out of the box on? I have > > customers who actively want to use it (for compression, not securi

Re: disable SSL compression?

akes sense to not have libpq enable it by default. The simple change is to just have libpq default to it being off while still allowing it to be turned on. I don't really see any downside of that at all (given the state of the libraries), and it's supposedly a trivial change. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [PATCH] Verify Checksums during Basebackups

On Tue, Apr 3, 2018 at 1:52 PM, Magnus Hagander <mag...@hagander.net> wrote: > > > On Mon, Apr 2, 2018 at 2:48 PM, Michael Banck <michael.ba...@credativ.de> > wrote: > >> Hi! >> >> On Sun, Apr 01, 2018 at 05:27:21PM +0200, Magnus Hagander wrote: &g

Re: [PATCH] Verify Checksums during Basebackups

On Mon, Apr 2, 2018 at 2:48 PM, Michael Banck <michael.ba...@credativ.de> wrote: > Hi! > > On Sun, Apr 01, 2018 at 05:27:21PM +0200, Magnus Hagander wrote: > > It might be a micro-optimisation, but ISTM that we shouldn't do the > > basename(palloc(fn)) in is_heap_fil

  1   2   3   4   5   6   7   8   9   10   >