probably look this up, but I don't think this is fundamentally
different from how VACUUM and CREATE INDEX CONCURRENTLY run inside a
portal and issue multiple transactions in sequence.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
t patch version.
It shouldn't be difficult.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
standard.
The point about the overlap refers more to the internals. The entire
parsing, look-up, type-resolution, DDL handling, and other things are
the same.
So for both of these reasons I think it's appropriate to use the same
catalog.
--
Peter Eisentraut http://www.2ndQuadrant.com/
Postgre
amount of
tweaking to make things look good before switching in 10, so that would
all have to be collected and analyzed.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 11/28/17 10:34, Simon Riggs wrote:
> Is ERRCODE_INVALID_FUNCTION_DEFINITION still appropriate?
Well, maybe not, but changing that is likely more trouble than it's worth.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Train
On 10/31/17 15:38, Peter Eisentraut wrote:
> 2) SPI needs some work. It thinks that it can clean everything away at
> transaction end. I have found that instead of TopTransactionContext one
> can use PortalContext and get a more suitable life cycle for the memory.
> I have play
xt commit fest.
I think these are SCRAM channel bindings, not SASL channel bindings, so
the parameter should be named accordingly.
I also wonder whether there should be a mechanism to turn off channel
binding from the client. Right now, there is no way to test the
non-PLUS mechanism in an
On 11/27/17 21:11, Michael Paquier wrote:
> On Fri, Sep 29, 2017 at 10:06 PM, Peter Eisentraut
> <peter.eisentr...@2ndquadrant.com> wrote:
>> On 9/22/17 15:31, Peter Eisentraut wrote:
>>> I suggest you create a patch that focuses on the --create part.
>>>
for the --with-ssl switch.
I'm not sure whether this is a great improvement. Why upset existing
build and packaging scripts? The usual options style is
--with-nameoflib. We can have separate options and error if conflicting
combinations are specified.
--
Peter Eisentraut http://www.2ndQu
n sends an
explicit NULL to insert on the remote.
I think, however, that it would be more appropriate to send DEFAULT and
let the remote side sort it out. That way, this command would work
transparently independent of how the default is defined on the remote
side. AFAICT, it is not
eans the same thing as tls-unique. In any case, some variant of
that should be fine. I don't think we need a separate server option
that this point.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
> That looks odd. Patch certainly makes this case consistent with the
> rest of acl.c, but maybe there's some deeper reason? Peter?
No I think it was just forgotten.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
re using a process manager, then trying
to control the process outside of that process manager isn't going to
work well.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 11/29/17 14:17, Andrew Dunstan wrote:
> On 11/28/2017 10:03 AM, Peter Eisentraut wrote:
>> Here is a new patch that addresses the previous review comments.
>>
>> If there are no new comments, I think this might be ready to go.
>
> Looks good to me. Marking read
vior
makes sense. Documentation is surely needed.
> The context line here looks odd:
>
> CREATE PROCEDURE test_proc2()
> LANGUAGE plpythonu
> AS $$
> return 5
> $$;
> CALL test_proc2();
> ERROR: PL/Python procedure did not return None
> CO
On 11/14/17 18:38, Peter Eisentraut wrote:
> On 10/31/17 15:38, Peter Eisentraut wrote:
>> Here is a patch that implements transaction control in PL/Python
>> procedures. (This patch goes on top of "SQL procedures" patch v1.)
>
> Here is an updated patch, now on to
would not be a single transaction, it doesn’t fit as a stored
> procedure at least in Postgres when a function is 1 transaction.
In progress: https://commitfest.postgresql.org/16/1360/
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 12/12/17 04:12, Ashutosh Bapat wrote:
> May be you should use opt_boolean_or_string instead of TRUE_P and
> FALSE_P. It also supports ON and OFF, which will be bonus.
But ON and OFF are not valid boolean literals in SQL.
--
Peter Eisentraut http://www.2ndQuadrant.com/
Post
learly confusing. The above-mentioned patch
cleans that up more thoroughly, I think.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
would appear on the logs.
It does do that already, as of commit
a4327296df7366ecc657b706a9b5e87aa921311a. Is it not working for you?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 12/11/17 17:12, Tom Lane wrote:
> Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes:
>> On 12/11/17 16:45, Tom Lane wrote:
>>> (BTW, why is it that we can't fall back on the negative-width-bitfield
>>> trick for old g++?)
>
>> The compl
t up now, we make the server compute the channel
binding data for both tls-unique and tls-server-end-point, even though
we only end up using one. This might need some restructuring so that we
only get the data we need once we have learned which channel binding
type the client requested.
--
Pete
ISTM that some of the portal-related memory context naming is a bit
antiquated and at odds with current terminology. In this patch, I
propose to rename PortalMemory to TopPortalContext and rename
Portal->heap to Portal->portalContext, and then clean up some
surrounding APIs.
--
Peter Eise
been fitted into the function.
There is an argument for having a big array versus the switch/case
approach. But most existing code around object addresses uses the
switch/case approach, so it's better to align it that way, I think.
It's weird to have to maintain two different styles.
--
Peter Eisentraut
ses handling and just paste as-is
> would be a useful (and I'm guessing relatively simple) thing to add.
You need to put
set enable-bracketed-paste on
into ~/.inputrc, then it works.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remot
grab warnings during compilation. And patch 0002 is doing it
> the correct way in aclcheck_error().
I'll fix that.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
r of
good cleanups in there at least. But could you please send patches in
git format-patch format with commit messages, so we don't have to guess
what each patch does?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
ilar problem, but they are prohibited by
> backend grammar.
Committed your fix, thanks. I took out the hint, because calling an
aggregate function is a bit more complicated than just replacing the
CALL by SELECT.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7
On 12/12/17 22:59, Michael Paquier wrote:
> Attached is what I have some up with, based on Peter's v2.
This has been committed. Thanks!
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
ust looking to execute a
use-case-specific stored procedure in the background?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
o maintain two different styles.
> Eh, really? What about the two big arrays at the top of objectaddress.c?
They are not indexed by object type. I can't find any existing array or
other structure that fits into what this patch is doing (other than the
one this patch is removing).
--
Peter E
I think I'll close this patch. I was operating under the assumption
that there is a bug of omission in PG10 here. But it seems this
combination of features just isn't meant to work together at this time.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
with a separate
> discussion thread.
Are you working on that as well?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
as the same, so there is no need to deal with any variations anymore.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From ba45631d66502600034f3d4803e35909f29d8e7c Mon Sep 17 00:00:00 2001
From: Peter Eisentraut &
On 12/15/17 17:34, Michael Paquier wrote:
> On Sat, Dec 16, 2017 at 2:39 AM, Peter Eisentraut
> <peter.eisentr...@2ndquadrant.com> wrote:
>> On 12/13/17 02:35, Michael Paquier wrote:
>>> Patch 0001 is simply removing EventTriggerSupportsGrantObjectType(),
>>>
eleting file `lcov_base.info'
> make: Leaving directory `/home/vagrant/test/build/src/bin/pg_basebackup'
The -d options should accumulate, so that it should look in both places.
Wild guess: If the /postgres directory is some kind of vboxsf mount,
there might be problems if symlinks are involved.
e this locally and it works fine. So we might have
to be more precise. Can you tell me the vagrant box you are using if
it's public, or the OS version, and the exact commands, then I can try
to reproduce it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Developmen
ing to a v10 server using a SSL context with a v11 libpq.
>> - 0004 introduces tls-server-end-point.
>> This has required some work to get it shaped as wanted, I am adding it
>> to the next CF, as version 2.
>
> Documentation in protocol.sgml has rotten again as ma
ack would necessarily be language specific. We do have some of that
for PL/pgSQL of course.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
finding the cut-off might be hard. Or maybe we'll just start with new
stuff from now on.
Any thoughts?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 11/8/17 09:54, Tom Lane wrote:
> Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes:
>> On 10/31/17 14:23, Tom Lane wrote:
>>> Why not use VOIDOID for the prorettype value?
>
>> We need a way to distinguish functions that are callable by SELECT an
On 11/8/17 12:15, Merlin Moncure wrote:
> On Wed, Nov 8, 2017 at 11:03 AM, Peter Eisentraut
> <peter.eisentr...@2ndquadrant.com> wrote:
>> On 11/8/17 11:11, Merlin Moncure wrote:
>>> On Wed, Nov 8, 2017 at 9:13 AM, Peter Eisentraut
>>> <peter.eisentr...@2ndq
have committed the patch with the above fixes.
I'll be off for a week, so perhaps by that time you could make a rebased
version of the rest? I'm not sure how much more time I'll have, so
maybe it will end up being moved to the next CF.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
which seems wasteful. We don't
create "out of memory while creating some internal list you've never
heard of" errors elsewhere either.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
some later point. So I think
this is a localized detail, not a fundamental problem.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
at transaction boundaries. This
turned out to be the easiest and cleanest. I have since the last patch
implemented the transaction control capabilities in PL/pgSQL, PL/Perl,
and PL/Tcl, and it was entirely trivial once the details were worked out
as I had shown in PL/Python. I will post an updated p
have checked with the following
> configurations with a v10 backend:
> - v11 libpq with SSL
> - v11 libpq without SSL
> - v10 libpq with SSL
> - v10 libpq without SSL
> And in all cases the connection is accepted as it should.
Committed.
--
Peter Eisentraut http://w
trolFile->backupEndRequired is *false*. So I guess that it means
> that minRecoveryPoint is incorrectly set if
> ControlFile->backupEndReuired is true. Am I missing something?
I agree with you that the logic in the comment is correct. I've
committed just the symbol change.
--
P
d the corrected version.:)
>
> Nice catch. I completely missed that. Thanks.
Committed.
I switched the if logic around even more, so that it is
! if (isatty(fileno(stderr)))
! fprintf(stderr, "\r");
! else
! fprintf(stderr, "\n");
instead
src/tools/msvc/builddoc.pl and the associated documentation (in
install-windows.sgml) is quite outdated, even for PG10. If someone has
the required knowledge, please consider supplying an update.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support
| func
> public | foo | | i integer | proc
> (2 rows)
>
> Should this now be called a "List of routines"?
Maybe, but I hesitate to go around and change all mentions of "function"
like that. That might just confuse people
On 11/30/17 00:36, Michael Paquier wrote:
> On Wed, Nov 29, 2017 at 1:04 AM, Peter Eisentraut
> <peter.eisentr...@2ndquadrant.com> wrote:
>> On 11/22/17 21:08, Michael Paquier wrote:
>>> Yes, agreed. This patch looks good to me. In fe-auth-scram.c, it would
>&g
Part of the confusion is that the huge_pages setting is only for shared
memory, whereas the kernel settings affect all memory. Is the same true
for the proposed Windows patch?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
work? Is it using one of the hidden columns on a row?
It means that for example if an update record is produced, the entire
row is included in the record as the key.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 12/4/17 10:15, Nikhil Sontakke wrote:
> PFA, latest patch for this functionality.
This probably needs documentation updates for the logical decoding chapter.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
t; Peter will pick this up at some point, since the whole transform feature
> was his work to begin with. If he doesn't want to touch it, maybe he
> should say so explicitly so that other people will feel free to take it.
I'll take a look.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 12/7/17 08:31, Peter Eisentraut wrote:
> On 12/4/17 10:15, Nikhil Sontakke wrote:
>> PFA, latest patch for this functionality.
>
> This probably needs documentation updates for the logical decoding chapter.
You need the attached patch to be able to compile without
On 12/7/17 15:21, Pavel Stehule wrote:
> 2017-12-07 20:08 GMT+01:00 Peter Eisentraut
> <peter.eisentr...@2ndquadrant.com
> <mailto:peter.eisentr...@2ndquadrant.com>>:
>
> On 11/14/17 11:51, Pavel Stehule wrote:
> > One option would be to create a new
PL/Perl in particular, the commit clears away the portal,
and the next call to spi_fetchrow() will then not find the cursor and
just return undefined. So that is not so nice. I'm thinking about
extending the portal pinning mechanism to the other languages as well,
which seems mildly useful independent
On 12/9/17 19:28, Tom Lane wrote:
> Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes:
>> On 12/8/17 10:19, Tom Lane wrote:
>>> Meh. I never thought that the "help" business was particularly well
>>> thought out, and this proposal isn't bet
if we create this extension by
> default.
OK, could it be a separate extension, but part of the same code directory?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
rtions is
g++-6, and g++-5 doesn't support it. I think that is recent enough to
be a concern.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 12/9/17 05:47, Magnus Hagander wrote:
>
>
> On Sat, Dec 9, 2017 at 8:43 AM, Michael Paquier
> <michael.paqu...@gmail.com <mailto:michael.paqu...@gmail.com>> wrote:
>
> On Sat, Dec 9, 2017 at 2:26 AM, Peter Eisentraut <pete...@gmx.net
>
we can't fall back on the negative-width-bitfield
> trick for old g++?)
The complaint is
error: types may not be defined in 'sizeof' expressions
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
ario in which user code should directly operate on a portal
created by SPI.
Comments?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From ee052fc03d51d35617935679c30041127b635e21 Mon Sep 17 00:00:00 2001
From:
plpgsql code has an additional
> src/ folder which would cause the tests to not execute. If plpgsql
> code was moved on folder down then the tests would execute properly.
OK, I hacked something up for MSVC. How about this?
--
Peter Eisentraut http://www.2ndQuadrant.com/
Post
patch in attachments to this
> message.
Why not make this part of the plpythonu extension? It doesn't have to
be a separate contrib module.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
n terms
\h for help with SQL commands
\? for help with psql commands
\g or terminate with semicolon to execute query
\q to quit
The perhaps the fix is to revert the "help" thing?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL D
0.0005% of psql users have an interest in
making psql print HTML tables, but 50% of those are struggling with it.
Which problem would really need addressing?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 12/5/17 13:33, Robert Haas wrote:
> On Tue, Dec 5, 2017 at 1:25 PM, Peter Eisentraut
> <peter.eisentr...@2ndquadrant.com> wrote:
>> I think ROLLBACK in a cursor loop might not make sense, because the
>> cursor query itself could have side effects, so a rollback wo
none of my C++ compilers seem to
> take that path, not even recent stuff like clang 9.0.0.
For clang, you apparently need to pass -std=c++11 or higher. With g++
>=6, that's the default.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
CT_CAST or
OBJECT_STATISTIC_EXT be? I think that's best filled in when we know.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
(This also appears to address some sporadic test
failures in PL/Perl.)
I have also cleaned up the changes in portalmem.c further, so the
changes are now even smaller.
The commit message in this patch contains more details about some of
these changes.
--
Peter Eisentraut http://www.2ndQu
On 11/15/17 15:13, Peter Eisentraut wrote:
> I'm going to put this patch set as Returned With Feedback for now. The
> GinNullCategory issues look like they will need quite a bit of work.
> But it will be worth picking this up some time.
I think the issue with GinNullCategory is pr
it's not possible for us ever to support an expression that includes
> top-level "AS OF" (or, pretty much, "AS anything") without some rather
> enormous pushups.
The SQL standard syntax appears to be something like
"tablename" [ AS OF SYSTEM TIME 'something' ] [
On 5/8/18 16:51, Tom Lane wrote:
> Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes:
>> On 5/8/18 13:57, Andrew Dunstan wrote:
>>> + # take executable files that file(1) thinks are perl files
>>> + find . -type f -perm -100 -exec file {} \; -prin
On 5/8/18 13:57, Andrew Dunstan wrote:
> + # take executable files that file(1) thinks are perl files
> + find . -type f -perm -100 -exec file {} \; -print |
> + egrep -i ':.*perl[0-9]*\>' |
How portable is that?
--
Peter Eisentraut http://www.2nd
for an update to PEP 394 ("and we will drive that update
if needed").
So that's all great. There are some opportunities for prep work in the
meantime that have been mentioned.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
e Aleksander Lakhin's offer to prepare patches
> was missed somehow as the discussion sidetracked to other issues
That proposal seemed to indicate not only converting the source code to
XML but also the build system to XSL. The latter is out of the
question, I think.
--
Peter Eisentraut
t; if we shouldn't also select --nooutdent-long-comments. I noticed a few
>> places where it was doing that (ie moving comments left if they went past
>> the right margin) and didn't particularly like it.
>
>
> Yeah, not a fan of the outdenting, so +1 to both o
would be a good time to move ahead with this.
> What is the project's policy about fixing those warnings in older branches?
We did backpatch the GCC 7 changes. We could do the same here, but it's
a pretty sizeable number of changes.
--
Peter Eisentraut http://www.2ndQua
the following output:
$ make -s world
Generating BKI files and symbol definition headers...
Generating fmgrtab.c, fmgroids.h, and fmgrprotos.h...
PostgreSQL, contrib, and documentation successfully made. Ready to install.
That seems kind of inconsistent and silly. I suggest we remove the
output from
code <= 0xA9FF
|| $code >= 0xB000 && $code <= 0xF7FF));
but somehow the indent runs have managed to spread this compact
expression over the entire screen.
Can we have separate settings for braces and parentheses?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 5/8/18 10:18, Alvaro Herrera wrote:
> Peter Eisentraut wrote:
>> On 5/8/18 09:19, Chapman Flack wrote:
>>> On 05/08/2018 08:57 AM, Ildar Musin wrote:
>>>>
>>>> select map (pow(2, x) - 1 for x in array[1,2,3,4,5]);
>>>
>>> I wonde
ions about the amount of added
> complexity and whether the feature is worth supporting. I'd suggest
> trying to get some community buy-in by circulating a design document
> on -hackers before you write any code.
I think there is some interest, so it's worth proceeding like that.
--
Pete
t.
>
> LGTM.
Yes, that looks better.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
you can pass a function to another function (using regprocedure or
just oid), so this should be possible entirely in user space.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 4/10/18 12:40, Peter Eisentraut wrote:
> A report from a pgbouncer user revealed that running pg_dump -C/--create
> does not work through a connection proxy if the virtual database name on
> the proxy does not match the real database name on the database server.
> That's because p
es.
Are you asking me whether I think my current reading is more correct
than my previous ones? Well, yes. But someone else should perhaps
check that. Start with the syntax rules for .
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
fit in an IV or UV.
#2 appears to be a quality of implementation issue without any
user-visible effects.
#3 is an opportunity for future improvement, but works as intended right
now.
I think patches for these issues could still be considered during beta,
but they are not release blockers IMO
values and doesn't do any explicit
decompression. Is this correct?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
ted feedback on that).
>
> PFA a patch which should remove the short option.
committed (needed test and documentation adjustments, too)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
merging either
>> I'm not set on these names by any means; anyone have a better idea?
Is "sharable" the preferred spelling, as opposed to "shareable"?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>parent = parent;
it->nElems = JsonContainerSize(container);
It's probably not a problem in practice, since the isScalar business is
apparently only used in the array case, but it's dubious to leave things
uninitialized like this nonetheless.
--
Peter Eisentraut http://www.2ndQu
in pg_basebackup? Or maybe it doesn't need a
short option at all.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
and perl -c. I have been playing with a private branch that adds 'use
warnings' next to 'use strict' across the perl scripts, and there are a
number of warnings that pop up at run time. The fact that you get even
more warnings at compile time makes me wonder.
--
Peter Eisentraut
there.
(Optionally, have contrib/xml2 depend on this new extension if it is not
ready to be removed.)
3. Add XSLT functionality to core (unlikely).
Thoughts?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 6/12/18 10:03, Andrew Gierth wrote:
>>>>>> "Peter" == Peter Eisentraut writes:
>
> Peter> The problem with these nested procedure calls is that if the
> Peter> nested call
>
> Did you miss the fact that the issue only occurs when the t
the main parser instead. That stuff has test coverage, fortunately.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From c1e8ecf95599a9085e5f16bcd4aab3f13a2d6800 Mon Sep 17 00:00:00 2001
From: Peter Eisent
which does its own snapshot
management. So perhaps a fix here is to teach the LANGUAGE SQL handler
to set a snapshot if there isn't one already. That would make the
different language handlers behave consistently. (The alternative is to
get rid of the warning in snapmgr.c.)
--
Peter Eisentraut
1 - 100 of 4646 matches
Mail list logo
