Re: Adding OLD/NEW support to RETURNING

2024-03-27 Thread Jeff Davis
On Wed, 2024-03-27 at 13:19 +, Dean Rasheed wrote: > What I'm most worried about now is that there are other areas of > functionality like that, that I'm overlooking, and which will > interact > with this feature in non-trivial ways. Agreed. I'm not sure exactly how we'd find those other

Re: Adding OLD/NEW support to RETURNING

2024-03-27 Thread Dean Rasheed
On Wed, 27 Mar 2024 at 07:47, Jeff Davis wrote: > > This isn't a complete review, but I spent a while looking at this, and > it looks like it's in good shape. Thanks for looking. > I like the syntax, and I think the solution for renaming the alias > ("RETURNING WITH (new as n, old as o)") is a

Re: Adding OLD/NEW support to RETURNING

2024-03-27 Thread Jeff Davis
On Tue, 2024-03-26 at 18:49 +, Dean Rasheed wrote: > On Mon, 25 Mar 2024 at 14:04, Dean Rasheed > wrote: > > > > v7 patch attached, with those updates. > > > > Rebased version attached, forced by 87985cc925. This isn't a complete review, but I spent a while looking at this, and it looks

Re: Adding OLD/NEW support to RETURNING

2024-03-24 Thread jian he
On Mon, Mar 18, 2024 at 6:48 PM Dean Rasheed wrote: > > On Tue, 12 Mar 2024 at 18:21, Dean Rasheed wrote: > > > > Updated version attached tidying up a couple of things and fixing another > > bug: > > > > Rebased version attached, on top of c649fa24a4 (MERGE ... RETURNING support). > hi, some

Re: Adding OLD/NEW support to RETURNING

2024-03-10 Thread jian he
On Sat, Mar 9, 2024 at 3:53 AM Dean Rasheed wrote: > > > Attached is a new patch, now with docs (no other code changes). > Hi, some issues I found, while playing around with support-returning-old-new-v2.patch doc/src/sgml/ref/update.sgml: [ RETURNING [ WITH ( { OLD | NEW } AS output_alias

Re: Adding OLD/NEW support to RETURNING

2024-02-24 Thread Tomas Vondra
On 12/4/23 13:14, Dean Rasheed wrote: > I have been playing around with the idea of adding support for OLD/NEW > to RETURNING, partly motivated by the discussion on the MERGE > RETURNING thread [1], but also because I think it would be a very > useful addition for other comm

Re: Adding OLD/NEW support to RETURNING

2023-12-16 Thread jian he
On Mon, Dec 4, 2023 at 8:15 PM Dean Rasheed wrote: > > I have been playing around with the idea of adding support for OLD/NEW > to RETURNING, partly motivated by the discussion on the MERGE > RETURNING thread [1], but also because I think it would be a very > useful addition for

Adding OLD/NEW support to RETURNING

2023-12-04 Thread Dean Rasheed
I have been playing around with the idea of adding support for OLD/NEW to RETURNING, partly motivated by the discussion on the MERGE RETURNING thread [1], but also because I think it would be a very useful addition for other commands (UPDATE in particular). This was discussed a long time ago [2