On Tue, 19 Mar 2024 at 19:17, Ayush Vatsa wrote:
>
> > I'm marking this ready-for-commit (which I'll probably do myself in a
> > day or two, unless anyone else claims it first).
>
> Thank you very much, this marks my first contribution to the open-source
> community, and I'm enthusiastic about
> I ran it through pgindent to fix some whitespace issues and added
> another test for the filter option, based on the test case you added.
Thank you for addressing those whitespaces issues and adding more tests. I
appreciate your attention to detail and will certainly be more vigilant in
future.
> On 19 Mar 2024, at 12:19, Dean Rasheed wrote:
> I'm marking this ready-for-commit (which I'll probably do myself in a
> day or two, unless anyone else claims it first).
LGTM too from a read through. I did notice a few mistakes in the --filter
documentation portion for other keywords but
On Sat, 16 Mar 2024 at 17:36, Ayush Vatsa wrote:
>
> Attached is the complete patch with all the required code changes.
> Looking forward to your review and feedback.
>
This looks good to me. I tested it and everything worked as expected.
I ran it through pgindent to fix some whitespace issues
Hi,
> In my opinion the order of options in pg_dump.sgml and the --help
> output is fine. Keeping this new option together with -e/--extension
> makes it easier to see, while otherwise it would get lost much further
> down.
I agree with your suggestion, so I'll maintain the original order as
On Mon, 1 Jan 2024 at 13:28, Ayush Vatsa wrote:
>
> According to the documentation of pg_dump when the --extension option is not
> specified, all non-system extensions in the target database will get dumped.
> > Why do we need to explicitly exclude extensions?
> Hence to include only a few we
Hi,
> Aren't extensions excluded by default? That's why we have --extension.
According to the documentation of pg_dump when the --extension option is
not specified, all non-system extensions in the target database will get
dumped.
> Why do we need to explicitly exclude extensions?
Hence to include
On Mon, Dec 25, 2023 at 3:48 PM Ayush Vatsa wrote:
>
> Hi PostgreSQL Community,
> Recently I have been working on pg_dump regarding my project and wanted to
> exclude an extension from the dump generated. I wonder why it doesn't have
> --exclude-extension type of support whereas --extension
Hi,
> long options should not mess with short options, does the following
> make sense to you?
Yes that makes sense, a reason to keep them together is that they are of
the same kind
But I will update the patch accordingly.
One more thing I wanted to ask is, Should I separate them in the
Hi
On Mon, Dec 25, 2023 at 6:22 PM Ayush Vatsa wrote:
>
> Added a CF entry for the same https://commitfest.postgresql.org/46/4721/
>
> Regards
> Ayush Vatsa
> Amazon Web Services (AWS)
>
> On Mon, 25 Dec 2023 at 15:48, Ayush Vatsa wrote:
>>
>> Hi PostgreSQL Community,
>> Recently I have been
Added a CF entry for the same https://commitfest.postgresql.org/46/4721/
Regards
Ayush Vatsa
Amazon Web Services (AWS)
On Mon, 25 Dec 2023 at 15:48, Ayush Vatsa wrote:
> Hi PostgreSQL Community,
> Recently I have been working on pg_dump regarding my project and wanted to
> exclude an extension
Hi PostgreSQL Community,
Recently I have been working on pg_dump regarding my project and wanted to
exclude an extension from the dump generated. I wonder why it doesn't have
--exclude-extension type of support whereas --extension exists!
Since I needed that support, I took the initiative to
12 matches
Mail list logo
